From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.126 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793015210; b=qZ0S2k4a0sE3ldjzuzZEKcvkDL/uBDzUeZ5XBTLiSkka5uMWM1I8QzWsL+FCV87pTB9z a0C2NEQN/yChlVm48QmtEpvSMc0bdPVBTBHEly5t+s8d+NnTmV0SWksEAESEeaXIVqsWr iAXLzBXM/Swt66OnnVwibegRZl+dsxwccjXg6LWtglvwkxUG4TTaIxlRAmB0dQEnUxEmA iQO5E+lu6Ehwasdmv2OhIba4wGE8jdkuhXAoQsnd+DYYeKzhnN4yg3qmHKcxf5vvTR5ZT Wbo7u3ocPDHgY6e94+FBtUPnuHItSWJog6wPa6hlKMVEkJFKtZQRn+gs9WdAHOHif/Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793015210; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Message-ID:In-Reply-To: References:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:X-Correlation-ID; bh=aA+RABdiaQH3eDPzAi8KDo+ifW5jkwRRbEaeVSZdO2o=; b=tnKBboU5ZQkVEY0OjYq+1TPvrjYykjp+OAHVcblIRv7jpSNdompOY+OKMgwm7oT8TfjB QR0kdFcGzj8J5wkw/OrD/pFa/G1yjLY5XSKe9rFEXcK53gESLZBlKxbD5p9OUxqiyIQ0V H4fceSeDz3n3j6tcm/r+DPQK6VEEd8JN84+i3hqpndm+DRwZ5VsX5jVCVxwCtZXf7689F vu/fosY51JEzu+jRua3ndIew/GFRG3o/7En3TVjOlSmxVPVSUkGl8VWU4WSI1IEHhclh8 97gc3OiIArrVsTWYQrMWhqaPpyPFun8cJYp3Ovvqel0sZ5tftx9Otfw7BY2GkjmW3iw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=iGIlgk1A; arc=none smtp.remote-ip=95.215.58.126 Received: from mta1.migadu.com (out-126.mta1.migadu.com [95.215.58.126]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19797606A31D for ; Mon, 26 Oct 2026 11:46:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 19797606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=iGIlgk1A X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=aA+RABdiaQH3eDPzAi8KDo+ifW5jkwRRbEaeVSZdO2o=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793015206; v=1; x=1793620006; b=iGIlgk1Apfxec717PTeu5qTQ0No/XM1AwL20j0qOYYpL2UtrJ13UaVH0mpgg25aFTPlAw9lA 4J3PuCbM21FIioloSUJqyrUyAKph7wynxIixa5yHTh9sXs2RIMhL+3HKdHmQ5KsTbzVgmKmCMZQ uOcvIhw97h7pXfsjX8YzDWrQ= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 7e4d008dd8e6585e; Mon, 26 Oct 2026 11:46:46 +0000 X-Mizu-Trace-ID: 7e4d008dd8e6585e X-Migadu-Flow: FLOW_OUT Date: Mon, 26 Oct 2026 12:46:44 +0100 From: Denis Benato To: Sakari Ailus Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Benjamin Tissoires , Jiri Kosina , "Luke D . Jones" , Mateusz Schyboll , Denis Benato , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Message-ID: <9556d920-a04c-4919-8c16-c346fbd0bf75@linux.dev> In-Reply-To: References: <20260216175539.12415-1-denis.benato@linux.dev> <20260216175539.12415-2-denis.benato@linux.dev> <6b5fd961-245f-4b19-9007-03af59170ca3@linux.dev> Subject: Re: [PATCH 2/2] hid: asus: always fully initialize devices X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <9556d920-a04c-4919-8c16-c346fbd0bf75@linux.dev> 26 ott 2026 12:39:44 Sakari Ailus : > Hi Denis, > > Thanks for your reply. > > On Mon, Oct 26, 2026 at 11:00:52AM +0100, Denis Benato wrote: >> 26 ott 2026 10:55:55 Sakari Ailus : >> >>> Hi Benato, >>> >>> On Mon, Feb 16, 2026 at 06:55:39PM +0100, Denis Benato wrote: >>>> ASUS has more devices other than laptop keyboards which needs >>>> to be initializated: the init sequence is the same as keyboards. >>>> >>>> ID1 and ID2 are USB report IDs that are correctly enumerated: >>>> send init commands to all devices that supports those reports IDs. >>>> >>>> Signed-off-by: Denis Benato >>> >>> This patch appears to break input devices on Asus T100TA. With the patc= h >>> applied, I'm getting a steady flow of: >>> >>> [=C2=A0 256.358075] usb 1-3: USB disconnect, device number 120 >>> [=C2=A0 257.034324] usb 1-3: new full-speed USB device number 121 using= xhci_hcd >>> [=C2=A0 257.175003] usb 1-3: New USB device found, idVendor=3D0b05, idP= roduct=3D17e0, bcdDevice=3D 2.49 >>> [=C2=A0 257.175050] usb 1-3: New USB device strings: Mfr=3D1, Product= =3D2, SerialNumber=3D0 >>> [=C2=A0 257.175073] usb 1-3: Product: ASUS Base Station(T100) >>> [=C2=A0 257.175091] usb 1-3: Manufacturer: ASUSTek COMPUTER INC. >>> [=C2=A0 257.180978] input: ASUSTek COMPUTER INC. ASUS Base Station(T100= ) as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:0B05:17E0.02DB/= input/input749 >>> [=C2=A0 257.266585] asus 0003:0B05:17E0.02DB: input,hidraw1: USB HID v1= .11 Keyboard [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00= :14.0-3/input0 >>> [=C2=A0 257.270711] asus 0003:0B05:17E0.02DC: Fixing up Asus T100 keyb = report descriptor >>> [=C2=A0 257.272302] input: ASUSTek COMPUTER INC. ASUS Base Station(T100= ) as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.1/0003:0B05:17E0.02DC/= input/input750 >>> [=C2=A0 257.327059] asus 0003:0B05:17E0.02DC: input,hiddev0,hidraw2: US= B HID v1.11 Device [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0= 000:00:14.0-3/input1 >>> [=C2=A0 257.332642] input: ASUSTek COMPUTER INC. ASUS Base Station(T100= ) as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.2/0003:0B05:17E0.02DD/= input/input751 >>> [=C2=A0 257.334115] asus 0003:0B05:17E0.02DD: input,hiddev1,hidraw3: US= B HID v1.11 Mouse [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-00= 00:00:14.0-3/input2 >>> [=C2=A0 257.336098] asus 0003:0B05:17E0.02DD: Asus handshake 5d failed = to send: -71 >>> [=C2=A0 257.336263] asus 0003:0B05:17E0.02DD: Failed to initialize 0x5d= : -71. >>> [=C2=A0 257.336605] asus 0003:0B05:17E0.02DD: Asus failed to start mult= itouch: -71 >>> [=C2=A0 257.367022] asus 0003:0B05:17E0.02DD: probe with driver asus fa= iled with error -71 >>> [=C2=A0 257.367917] usb 1-3: USB disconnect, device number 121 >>> >>> I haven't tried to debug this yet so just FYI. >>> >> >> Hi Sakari, >> >> Thanks for testing this! Is that device of yours a touchpad? This commit= has been bugfixed before and the issue is related to report sizes being se= nt as 64 bytes (and also additional unsupported messages in the case of tou= chpads). >> >> Can you try linux-next please? That has all bugfixes for already known p= roblems. > > I can confirm the issue has been fixed in next. > Splendid! Thanks for testing! A few hours ago I sent the v11 of the ally patchset that also detects the r= eport size from the hid device so these things doesn't happen anymore, coul= d you try it please? It would be very good to know that no more regressions are being introduced= . > -- > Kind regards, > > Sakari Ailus