From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.227.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793093224; b=VMJ8DAS9ISq3d6QwEbme5GvWZvifVZ7MSsEzjPu9FPNl+tTvgIG1y3LmLxKg02aB5JQz Xk+67GXdBUFAB9OC8YPD0cZLtLpOA+rQaKdiBiTX9vhgFei54HV1xNebxdzE+jGYMa2MZ q7UUN0oQNWqCIA9byD/6rknf0Nafd7Q/HLXoD2quRtfLIFLhSuxTUordcD/CMfKq/T2yX 1EBx75em9P3cdkNuKuxGy+xUAbwvllnWjRuA3Mn8I7G4011E2w1pM4EhGpRkIrvfUQYHa cwu2xnZX+dv1IwFjbB4iF9zFCXxlI4F+X85Omci8tLnzPt1YtIDXFEZrMeUyWJJlzqg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793093224; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=h4/IEEwDZXLw/hZQAesBTnBi16Rhs6f/cohcUh8FEIY=; b=SNWPBsaKDDRLAhdt59OYpqsGyMjOgZKD9DK9fBszntlYlNN9ZgqAEpVhYNKGNFMTeOmj ZYzX9f9+G9XHkQfF6A4Aylx31nx+/hBZIR0QYOABbzWg59ErUJBJKXStg4PsVmhMlFhca kjn85nYbDzpoRp8nvreGEavC/u/Z6fiPmAu7ARIKpvV3IbyQdd3zzLRCpCUEzwy1BINdH O9llJ9YKIlt17e6hmkLa1NEXsnxFva41A434n9lfFPNoSDucEos93KgDBpLtml6eyvyoT Dry7yl1b7C54exXCiSFEb0vmx6OcIB2Xr3LhIs8UF/ebiBhwP05osV0OTjseGnXVrZQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=cD2Yk047; arc=none smtp.remote-ip=74.125.227.130 Received: from mail-pj2-f2.google.com (mail-pj2-f2.google.com [74.125.227.130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89DAE606A31B for ; Tue, 27 Oct 2026 09:27:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 89DAE606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=cD2Yk047 Received: by mail-pj2-f2.google.com with SMTP id d9443c01a7336-2e613f813b0so7205885ad.1 for ; Tue, 27 Oct 2026 02:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1793093223; x=1793698023; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=h4/IEEwDZXLw/hZQAesBTnBi16Rhs6f/cohcUh8FEIY=; b=cD2Yk047GntO8zsfZbdXM51UwnSmlkiujCDjVKBZKHjlEC4pxvmDWLLt7xtffKKM4Z 8zB+imfN4ACLWzc1EijhmoVLfxUXQHib690/YCPcklWWxT9MXSH1GIOOSLorLaHI91YG b3rnFOL1WdDzIXN8TUlajdbY8wwjJJfkZrm8DjM0OTDLvMG/colNHSQYb4a+25wNsxbf WRPQyYNcWsfZke5O6U36AyP/bCSV4MIr3ABqlyDPCu+X+Weajhrh2yQDfBXEjXGcPm1w P/En+NESa6dRXtUXTHGEDgfI2PRplY9SX2qFXVTXdO7CMkeP8tCuSTHVuMkKKW8fxZLR PvgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793093223; x=1793698023; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=h4/IEEwDZXLw/hZQAesBTnBi16Rhs6f/cohcUh8FEIY=; b=W8s+4qs1Frlg2CTECroJ2SFR9vfbWhsFCvNKr/Stl4EwsJwJgylOccX4x8sSilaPRA z1JqmIpZlAEBtNB++xLhYyeiCG6obzNwZc9GjK32ALmhITLFv7CFKshgaQQcfH5LbVh8 XsCYV497FyVSm15HJ8GpcdOfAVgxl1p4oV657tXpZENjqS4dpohiJ2ybdNhquAJiqvMW 0SACJ/QSbWBb1XvdW3yoeGfOVaweVRyPcOZqWHUmxeRhXk1n84ldElgvcvcbRiQirA1U KakC4QOJupA+b0iBfWOHpT4q/2odRcldMLUnUoFG3O38q/zQk910duLRCkGcnxWUgpmB 54Iw== X-Forwarded-Encrypted: i=1; AKwUvBxN0xa8mz3QmgysDKpTEN2ZdKzRGsyYlvVIj9+kTUO4SHvf0MtDV1dRUhI8l7jg2S/gkVFlbFhl7wriVvU=@vger.kernel.org X-Gm-Message-State: AFq9FYLp1rV3NwwtTtCnMseL6Yhg6YeYnlac95YJQfgt7pewL3VgF47S LY0XtjAJpXZC87zbyNkTRB5Q3UAAMsd5HtT+OQwB+5ypPgIZ3SJXivNsCDw6Z8bo4rGQoUOn X-Gm-Gg: AYBFou1hapgW6Z9NwtkyuVAlq64BFzV3Ud5NMGQQOFNCNXZpCfwM9OhMagAdYuYkPd0 86r+J6jWujO4nGFVwwIJhJMuUroM02NWB7Ad3IAGawGiK6FHI3ezrYHitRmHDnz2nyhqmWqLp4r ATJeQAYgsxBkUQnP4j8SCqaUStheYFJcnpQ8Q2g7KRm/SFBO5NqZmj+IaHUwSVMiIVTshmfwrnn YAQqYp+L03L14OjdKD74/PYsg9DIhuPAKLxJ0FBPKM6ny9Y4ctPRsia8njN3aAzlPnKdVL04XKd yLs3demVWMFepVwf5AeLvgc8BD4XkFIDpHutHZkts9Qdu80hHUTB5Fc+3tuVl29WNUaO0WWDbEA pbOfcpxgeY6+XjZFVyDXRJ1UIzxifALwmrrX4aHsWsrJJUAjoqWVxUT5yPU6kF/bTcVbMtodtuP dh/5CkYVtg/fvFmaBAi2Yzm0rh5m75zVvj/LBASBIi9yIP3l/g4de3CRo8eOzteJPmSqurT52Ao VIgtA9wPeURbIg3Y6ARF1R5RgX0173oQudIUc5dPlrxTXhyXxTjh1zzteFUvfx7Msz2I/QEgOFF 7wYxb4K0cQM0Ds2bpOdNX8VD9XUw X-Received: by 2002:a17:903:19f0:b0:2e9:3dd2:a8f6 with SMTP id d9443c01a7336-2eae3942024mr14409105ad.9.1793093222853; Tue, 27 Oct 2026 02:27:02 -0700 (PDT) Received: from [0.0.0.0] ([129.126.71.118]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2eae6b7a216sm6149335ad.16.2026.10.27.02.26.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2026 02:26:59 -0700 (PDT) Message-ID: <9556e959-daf3-4c85-8794-9613e7e7a9ae@gmail.com> Date: Tue, 27 Oct 2026 17:26:44 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] cpufreq: add an Amlogic speed-bin driver To: Viresh Kumar , Jerome Brunet Cc: christian.koever-draxl@student.uibk.ac.at, neil.armstrong@linaro.org, sboyd@kernel.org, bmasney+clk@redhat.com, khilman@baylibre.com, martin.blumenstingl@googlemail.com, rafael@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, =?UTF-8?Q?Christian_Stefan_K=C3=B6v=C3=A9r-Drax?= =?UTF-8?Q?l?= References: <20261025192219.209137-1-christian.koever-draxl@student.uibk.ac.at> <20261025192219.209137-5-christian.koever-draxl@student.uibk.ac.at> <1jbj8gkff1.fsf@starbuckisacylon.baylibre.com> From: Chuan Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Viresh, Christian, Could you please hold off for now on the patches adding cpufreq driver support on S4? There are still two issues that need to be resolved first: - The clock driver currently does not support setting the CPU clock. - The CPU regulator needs some time to stabilize after the voltage is changed. Without a proper delay, the CPU clock frequency may be raised before the regulator voltage has actually reached the target value, which can hang the system. The S4 CPU regulator handling currently lacks the logic to wait for the regulator voltage to settle, so this part needs to be completed first. We are currently working on submitting our own cpufreq driver. We are considering how to address the issues above, taking into account the hardware characteristics of previous SoCs and evaluating factors such as the transition latency. S4 will be covered by that work (as well as SoCs from S4 onward, such as C3, T7, ..., A9). So please give us some time. On 10/26/2026 4:59 PM, Viresh Kumar wrote: > On 26-10-26, 09:57, Jerome Brunet wrote: >> On lun. 26 oct. 2026 at 11:00, Viresh Kumar wrote: >> >>> On 25-10-26, 20:22, christian.koever-draxl@student.uibk.ac.at wrote: >>>> From: Christian Stefan Kövér-Draxl >>>> >>>> Every S4 speed bin runs the same CPU frequencies but needs its own >>>> voltage curve, and the bin can only be read through the secure monitor. >>>> >>>> Read the bin from the firmware, select the matching >>>> "opp-microvolt-speed" property for all CPUs, then register >>>> cpufreq-dt. Bins outside the known range fall back to bin 0, which >>>> has the highest voltages. Like sun50i-cpufreq-nvmem, the driver binds >>>> on the SoC compatible and needs no node of its own, and S4 is added to >>>> the cpufreq-dt-platdev blocklist so cpufreq-dt is only created after >>>> the bin has been applied. >>>> >>>> Signed-off-by: Christian Stefan Kövér-Draxl >>>> --- >>>> MAINTAINERS | 1 + >>>> drivers/cpufreq/Kconfig.arm | 14 ++ >>>> drivers/cpufreq/Makefile | 1 + >>>> drivers/cpufreq/amlogic-cpufreq.c | 184 +++++++++++++++++++++++++++ >>>> drivers/cpufreq/cpufreq-dt-platdev.c | 2 + >>>> 5 files changed, 202 insertions(+) >>>> create mode 100644 drivers/cpufreq/amlogic-cpufreq.c >>> >>> Is it safe to apply just this one ? I can take this via the PM tree then. >> >> I would advise to wait a little for Amlogic to chime in. > > Sure, I wasn't going to wait for the maintainers to respond anyway. > -- Best regards, Chuan