From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D69354763 for ; Fri, 9 Jan 2026 15:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767972031; cv=none; b=GmnXSRIhW/CtSwTqVZp3aygpFeYhb2uEwRVW2Fb+2wnQpB5Rkh05vCz1y9EDmJ7eaznEYRHTwMLZWg+P1P8AByEM0u1lt6aKdtUUp0LVHpyEX/mecRXIuJRiO8zJzeL7XypNHnSCPukqZtDv2kCcvC6AmMwzZocsiKAIn2J3iTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767972031; c=relaxed/simple; bh=7OoT8ZPcTVUu34J0z/Lza2gdt2rcWcp79sDbJOJ8v5Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mXw9ZXzoTJyxj9eW7l6WdU0z87gHlMwX9QAkp+37b2FRYRhkYl7Q36as0SgrTGkmf+vKOKWUo7WhdUWFZCYXFFv9dS8cwAioJjLUI3M8OnkwYUm+N9yXzF9mw5Xqa1mD6SReTue2aoycvGUXoAuCXwg/UlZBgksh8RvmEtvW1Ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KxPoJCGM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d2c6yrYb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KxPoJCGM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d2c6yrYb" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6099N6jw472726 for ; Fri, 9 Jan 2026 15:20:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 49tXLgJm9KB8UQ6tr2ES8NVrNO8u4KMgkHOdrGNgtn0=; b=KxPoJCGMd2q3ygLU Hq8LIjz4xl5PNqjiQ5vpUjELOg4YFU0Galj1+LDodqf1jmHCZyBHtpXc0zsWDQHq AOnk6oLA6TWcPSkliboJhzvpqJqSi+P8fIRapAv3PpEVjUkuBLYM2bq2JSm3t3LX mixYHafZqiZQmE5Xbph8rV1OkitED2NJGLwjSRoGw3DRMCWs56awEQYiRrtCVKoq 3/HUzuiYfRnUL8DUErBdscKxUBEwLSOGvYYuYLW2zURUcBqQ2Z9lcqOAPGwt7tp7 vlPzObkiYa/JfA4PDQb8kYaUu3rObLeJRAylvPJDpxR+xVuPrdMTiE61ynlbtaY7 hINskA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bjy0a103p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Jan 2026 15:20:29 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b6963d163eso1042048485a.3 for ; Fri, 09 Jan 2026 07:20:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767972028; x=1768576828; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=49tXLgJm9KB8UQ6tr2ES8NVrNO8u4KMgkHOdrGNgtn0=; b=d2c6yrYbl0TgKmD+juhL6xH2wpnMe4+yaRi2WULjsyLp6MzWt10GiuuF4625FLjAFM 6FWNjO58HuMukqILSlqoEEYchadF+rLO9t/u4luZYEY5NJnxSY2/9iqVib6yVcGfla6P gTeeZLdWO42XoFpgbrdben0QoK09OIusbcPTliaiM+DjJu2QFURXKjvo6fJFN9J229/b PCDpZIr2az1Hw5uvhAMXofl1fPYOhhptc4NzNJpH9mO5JQi4s4tH2A5C1S6p2Lom1rAQ teHUxEAdNRy7ZbFdceMzO0FIS69ZXxupEj2F7Sa5u5wEd5JDEiktk/uGhE4Egp+Bo79z sMxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767972028; x=1768576828; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=49tXLgJm9KB8UQ6tr2ES8NVrNO8u4KMgkHOdrGNgtn0=; b=wMejI2m/+a6t69x5nYfq0GBx5Z8BRZ9sw5lBLp7x3s5Ns01L9JYKAMYfyocKVzBoFb KOsK3Od79SrIc+e2qoC1ruap2XneBno+Jf84kAK0hNxOOQlBkU+urHLaA1DY4XdxQ8QU n8KxgOMkxYlnhty6r40izNvIQ2IKnrsy/hpDOpxCrL1Z40z0YkZ2UJ9nzSYgLAL6YZmU 04uw7mRE6kzRlMqPITd0vxTSOxLxtGpDx9JSTnZTgPWilIFCLOHKJK5G9x2koomVG6CH OFdLtoQck9LHUjeKNVpEkbtTBSKUHwAnCE6C54UvylQ8Yeqk1PYts4voD01vx8ji9zIo LDLA== X-Forwarded-Encrypted: i=1; AJvYcCWsN96uAoNdMwX0CcTf2ylcjTjJY6Bjdx1Ej7UaQql2pCwLudnFF4AGXFJA+8toqKQOGyraaruu5vgusuA=@vger.kernel.org X-Gm-Message-State: AOJu0YwEn1N6V5AAWoxlyBaU98cN/8n46Pd4xINbKlkpStgZS4ucRRwS 7tDDU/+Z39adr1j5JkHSoza/IunukVAirZe5+9RvgeVjmJ4JVErH3Pv1c4OnnobC/e11fhTPAmT HBPURjP/PZKPHKh8Hq4n+YLixVzv/8+tvYZfnbroc1DiapYPeEDRyRDA9HEx31QSX8ho= X-Gm-Gg: AY/fxX61+yccxFuUcQkcLTXnGmtQHVYOwtYhhkfnL/hXM63zJFKZgY63o8nwGUlerdO ygEKz4SjvlkSCcRubksTeGOskkyaUHUAWElFYBj1Vc1QJTaocEwnrB2nemrFH4THMT8jhXiA/nh JeEd/c7dfCO9hXldlJfi3NLwRrEtRO5KrkDkG3raImJnQTARbbndLvVtEaDEObukko1f5Hihbsy m3a19z2W2FDM0FjFcUmh+ex/1q9RK+VrnEhaOTLB240lZnokwYolC/yn8BG/aQDHQCkCH14o7Kv CXEtDYrUfqj6kxEFYpSMz8uzGdH1bLeCGEIJIgHYN31xvL2SSbtNi/g83tSwWYfHSMcGPRxj4Jt hD7CmhqgUD3Je7gt2oTI0aUk92+hUk9PLZX9sdg== X-Received: by 2002:a05:620a:191b:b0:8b2:e8a0:f4e with SMTP id af79cd13be357-8c389411a4emr1096205985a.77.1767972028267; Fri, 09 Jan 2026 07:20:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4T7EpPkz3EWkla3fr6+RN+eZME331kblvXjFVWSsrchwbSfgu8tBxJVnkAZJ/PMc9qkoTFg== X-Received: by 2002:a05:620a:191b:b0:8b2:e8a0:f4e with SMTP id af79cd13be357-8c389411a4emr1096199885a.77.1767972027621; Fri, 09 Jan 2026 07:20:27 -0800 (PST) Received: from [192.168.1.29] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f6ef885sm209365935e9.9.2026.01.09.07.20.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 07:20:27 -0800 (PST) Message-ID: <955e5ed7-6469-4f17-9e8c-3ee06f5dc3bc@oss.qualcomm.com> Date: Fri, 9 Jan 2026 16:20:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] bus: stm32_firewall: Use scoped allocation to simplify cleanup To: Gatien CHEVALLIER , Bjorn Andersson , Konrad Dybcio , Maxime Coquelin , Alexandre Torgue , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Jonathan Cameron References: <20260105143657.383621-4-krzysztof.kozlowski@oss.qualcomm.com> <20260105143657.383621-6-krzysztof.kozlowski@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA5MDExNCBTYWx0ZWRfXzbUqzQSWfgqH /Kvl2zGNs3ZKx3WGLhiWyXFA3eUUbouBM2NyD2lC84zvIrgNSL7s9MIOUW3DRgLnac0xHl8YCHW XUxqcGuVPD7jFKBf2Gw7cksDNy06ZCLyfN9vDfy9ishSPl7TR9QIsHFmv47pEE8vGtkcMSXFgpF mBQT0ddiNOOYwVuFb0fo7TlZLkHbKBgJNK8CUUNkXkg81P5fum/Lzolg2kmLlHlAkb8ZgED0OBO MoxnvYf6/WOk/b6nb4KGpT0m8tGQ9B6QxaPfnhw2RBYmr5IUcycyZe8x+BWVp5Qcl4WfzGleDcQ 351A2ktpPILyIix83nh+qFkFghoaaR8VQenfXtFXG7Mr6F4ImlGehAMmY0FzzgiF5s7MKOWpNmw Mnhe9fD2oFjIKjjhqntbdL24by6pJCtsG6XziKyqnDzpTqbdBiK5AwHLil3lFCE0ySk75wbyOnA 4/kboWFkDngxxtH/gMA== X-Proofpoint-ORIG-GUID: wKiBwTlkiQSuk46HndXtt3j8ho-v4AeL X-Proofpoint-GUID: wKiBwTlkiQSuk46HndXtt3j8ho-v4AeL X-Authority-Analysis: v=2.4 cv=QPFlhwLL c=1 sm=1 tr=0 ts=69611cbd cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=i0EeH86SAAAA:8 a=EUspDBNiAAAA:8 a=xCSfWrHGVKLGKJWD7hwA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-09_04,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601090114 On 09/01/2026 13:34, Gatien CHEVALLIER wrote: > > > On 1/9/26 12:55, Krzysztof Kozlowski wrote: >> On 09/01/2026 11:37, Gatien CHEVALLIER wrote: >>> On 1/5/26 15:37, Krzysztof Kozlowski wrote: >>>> Allocate the memory with scoped/cleanup.h to reduce error handling and >>>> make the code a bit simpler. >>>> >>>> Suggested-by: Jonathan Cameron >>>> Signed-off-by: Krzysztof Kozlowski >>>> >>>> --- >>>> >>>> Changes in v2: >>>> 1. New patch >>>> --- >>>> drivers/bus/stm32_firewall.c | 10 +++------- >>>> 1 file changed, 3 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/drivers/bus/stm32_firewall.c b/drivers/bus/stm32_firewall.c >>>> index fae881cea9a0..92414a4c7bb1 100644 >>>> --- a/drivers/bus/stm32_firewall.c >>>> +++ b/drivers/bus/stm32_firewall.c >>>> @@ -240,7 +240,6 @@ EXPORT_SYMBOL_GPL(stm32_firewall_controller_unregister); >>>> >>>> int stm32_firewall_populate_bus(struct stm32_firewall_controller *firewall_controller) >>>> { >>>> - struct stm32_firewall *firewalls; >>>> struct device *parent; >>>> unsigned int i; >>>> int len; >>>> @@ -257,15 +256,14 @@ int stm32_firewall_populate_bus(struct stm32_firewall_controller *firewall_contr >>>> if (len <= 0) >>>> return -EINVAL; >>>> >>>> - firewalls = kcalloc(len, sizeof(*firewalls), GFP_KERNEL); >>>> + struct stm32_firewall *firewalls __free(kfree) = >>>> + kcalloc(len, sizeof(*firewalls), GFP_KERNEL); >>> >>> Hello, >>> >>> I'd prefer to keep declarations separated. >> >> Separated how? This is the coding style of cleanup (which is quite >> explicit around other styles)? Or you meant one line without wrapping? >> > > I found odd to declare and assign a variable mid-loop but I found > multiple occurrences of the same kind of cleanup. > > You can drop my comment, I'm fine with how it is. Thanks for the > cleanup. > Sure, just to let you know - it is fair to reject cleanup.h entirely for code you maintain (like netdev did). I only disagree with sort of semi-cleanup.h without following its declaration and initialization rules, because it is more error-prone, leads to bugs and often does not make the code easier to read/simpler. Best regards, Krzysztof