From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AFE4C43334 for ; Tue, 21 Jun 2022 17:44:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231295AbiFURoX (ORCPT ); Tue, 21 Jun 2022 13:44:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232708AbiFURoV (ORCPT ); Tue, 21 Jun 2022 13:44:21 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 509D81C910 for ; Tue, 21 Jun 2022 10:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1655833460; x=1687369460; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=gONKT1UPriQCs/i3OvZ6WzWauKCzmlMlPLxa3MCvwkQ=; b=Evx/DSML6HFSu5Ut1TNDoYfjf1jquYzE7Aq/5PIgoi4dlBPS8MiuIfiw JMICzAcm2EFxSgmYK/n1WjKIDtmooXsdy4TKvU8VXxG6CjANHj04YBK0o 6fdURb6BkjTH3aceJ8a2IQ03S2iGcN1i734BDmxATLcqqxJa3IKeY34ZN Q=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 21 Jun 2022 10:44:20 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 10:44:19 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 10:44:19 -0700 Received: from [10.38.247.150] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 10:44:17 -0700 Message-ID: <955f881c-7731-a337-3ff9-e58863c41976@quicinc.com> Date: Tue, 21 Jun 2022 10:44:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] drm/msm/dpu: Fix variable dereferenced before check Content-Language: en-US From: Abhinav Kumar To: sunliming , , CC: , , "kernel test robot" , Dan Carpenter , freedreno References: <20220621110634.368913-1-sunliming@kylinos.cn> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Copying freedreno On 6/21/2022 10:42 AM, Abhinav Kumar wrote: > > > On 6/21/2022 4:06 AM, sunliming wrote: >> Fixes the following smatch warning: >> >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:261 >> dpu_encoder_phys_wb_atomic_check() warn: variable dereferenced before >> check 'conn_state' >> >> Reported-by: kernel test robot >> Signed-off-by: sunliming > Reported-by: Dan Carpenter > Reviewed-by: Abhinav Kumar > >> --- >>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 10 +++++----- >>   1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c >> index 59da348ff339..0ec809ab06e7 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c >> @@ -252,11 +252,6 @@ static int dpu_encoder_phys_wb_atomic_check( >>       DPU_DEBUG("[atomic_check:%d, \"%s\",%d,%d]\n", >>               phys_enc->wb_idx, mode->name, mode->hdisplay, >> mode->vdisplay); >> -    if (!conn_state->writeback_job || !conn_state->writeback_job->fb) >> -        return 0; >> - >> -    fb = conn_state->writeback_job->fb; >> - >>       if (!conn_state || !conn_state->connector) { >>           DPU_ERROR("invalid connector state\n"); >>           return -EINVAL; >> @@ -267,6 +262,11 @@ static int dpu_encoder_phys_wb_atomic_check( >>           return -EINVAL; >>       } >> +    if (!conn_state->writeback_job || !conn_state->writeback_job->fb) >> +        return 0; >> + >> +    fb = conn_state->writeback_job->fb; >> + >>       DPU_DEBUG("[fb_id:%u][fb:%u,%u]\n", fb->base.id, >>               fb->width, fb->height);