From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE69728FFE7 for ; Sat, 16 Aug 2025 10:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755339329; cv=none; b=ma8XSruwHpaiNKeGRfq0eQjIxgTJm7FLIiiUHWJ49syeF8bmCdryYmofycSFvjRtGbKLSwj8ZiEwyVg7TW23MlAVqbJX8efwN2ca8Z3DdoCgolyg+rP53qBHbL2RA21ULCqrI3BNhJ3A1cdguZrOkuTITZzqIOu54YmWMSHQnq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755339329; c=relaxed/simple; bh=Nh3NrLx9OEag4aosCiVt6RzyBczUYLkKTLWOeNhbtQs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nyrqfP2tCMonMt5Idy3ssWWMNGaPPFD9is2VUpJquHsLZVBn9ai1uLPcc+dfNWU4RDIjewT6qjjO76M9/4FSXjfWnrLi5QQaLVVmObvvHU3n8+hXF5jfJoRcD5UbRwurvTrxEWPP8QLBtR0rPUG85Kohp4dRit91FxAwSueJXmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ggbz/Z/p; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ggbz/Z/p" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3b9d41baedeso1476154f8f.0 for ; Sat, 16 Aug 2025 03:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755339326; x=1755944126; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lGt82GlIKWDzCqErqhiqhcXLyT50Jvw2mM2mW/AA2Dw=; b=Ggbz/Z/p/nBIjYYEAMC69itrPy04Uw77np836rOtmdq5YPDh2v2TYrKzt4qDWtUKc3 wmn7bKpE7wtqOTqeEAflMooNtM0YuLU0hLvUrvinalQ6JI0i7/FJ77FZJvlSms5Wh6yx YLImcbfxnNQr6hC8A5ZzsdhwG8ETaKZi/haREoE8AOGQ/fGTWKZN9Mdk0jc6Q0lhz73u MlsEF31lKZh6RETIshtWuYm3q+CHmrOnmgWysSteRaIATyZMn2f5tyzFWx/Kt2FDVkvw JxPDMKNoZ/MvhgBjjUl2ZpWRiM7OqSuYcLeYLkbz8cYxv/hISLVI7DG3NP2kkXs5h14b mOQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755339326; x=1755944126; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lGt82GlIKWDzCqErqhiqhcXLyT50Jvw2mM2mW/AA2Dw=; b=OoQOdlkcLdCiCMIMmHwauc0WCeXiAYg0wdYYENfmtl3/7/asBlNZ9RNojpEm272vIZ kxvrzB/8DS3OBp7F9gWMU7fpMquhZ8dkBTnG6fVwNSkD/R0DExx4O1S0Gjc2fNdhyLpr 5E22H6Ipsr7NBQSrlCEEGT7IPHYOvnAAGrs1UH0NYqe+nuGkO8CzkeQxNbdEcS1wsNRf mmknQVj2VOxeobmFXpP76XLoKHZo+GZweTFXU/W7qf1cid+4f5wJpHudSt76lQPYYYAJ dxLoGw9iMdoK29L5/lYXVtIAPTqv9OoStsp+U6RNUPx95SOVhU8lcGtmcNlX7X/Z5dk/ tRqA== X-Forwarded-Encrypted: i=1; AJvYcCU7tqqxoekqeZuZIxndZ4cduRVBLB2RmDFlOCgauvxn6TGEO9sfKw27ezsCLL2KbcEQpEfLsFbOIiAlQ20=@vger.kernel.org X-Gm-Message-State: AOJu0YynPdNdPsdcxEzB9uWbnWwNX3CNGLRlbdhO50ExaajGQcZnen5a M9EQ0UtJMFFhguL81rkINnGCfE6fT/Y+5OKdVrlo3xBLRKJjpCVlXmMG2Bw5eEWzVVA= X-Gm-Gg: ASbGncsQ6oA7GYh6SSqN4toZy1jkH1q6c6KyIX+RuXauPD6F1j9nBFrNwlEuZTAgv4L kf6fXdLiRrlMS+gyZoZLHYsKrHZW3vvHpLeAiIpLyxXKmIuBwyPaCDekJgghJKeju7D8+uGpbZC ijH0yOjOMRTh1VY8Md1y3qgIQ6+eE/49s1bvKGWfboh6J8DhoJ2q3NlfI1tTF7e15HqYReeOxMN sJkJgEVF/E7Yrw/sv5XqqeImuRm/jjL3GoyhpBopspxOo0mFEDSJlqylJpnjs9vWp751yPoJqzP 95WHleL5+LHR33Oohk8sseCckxNuR0/DqSQhDlxOrLIaUo5tqgENdKrewltsklkQJTqeqGyGZqR WrnJuT8Jh1qJbDQRfphGRQN8MZqHj0aZIQXBYty8oXNHBdTDC2gTbnLZuyujhCno5 X-Google-Smtp-Source: AGHT+IGmLANuUFgyoBXIF4SnP+CvmH/WZED91QLhAbarFtBDm+auOklS8ukCHnJhlG0Pcv8G6VzDtQ== X-Received: by 2002:a05:6000:420a:b0:3b7:886b:fb76 with SMTP id ffacd0b85a97d-3bb6636cb0emr4085932f8f.12.1755339326328; Sat, 16 Aug 2025 03:15:26 -0700 (PDT) Received: from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a22319780sm50655435e9.7.2025.08.16.03.15.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Aug 2025 03:15:25 -0700 (PDT) Message-ID: <956110cf-d309-430c-b30f-a9c442e015cf@linaro.org> Date: Sat, 16 Aug 2025 11:15:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/24] media: iris: Fix memory leak by freeing untracked persist buffer To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Vedang Nagar Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Renjiang Han , Wangao Wang References: <20250813-iris-video-encoder-v2-0-c725ff673078@quicinc.com> <20250813-iris-video-encoder-v2-3-c725ff673078@quicinc.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250813-iris-video-encoder-v2-3-c725ff673078@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/08/2025 10:37, Dikshita Agarwal wrote: > One internal buffer which is allocated only once per session was not > being freed during session close because it was not being tracked as > part of internal buffer list which resulted in a memory leak. > > Add the necessary logic to explicitly free the untracked internal buffer > during session close to ensure all allocated memory is released > properly. > > Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue internal buffers") > Reviewed-by: Vikash Garodia > Tested-by: Vikash Garodia # X1E80100 > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c > index 6425e4919e3b0b849ba801ca9e01921c114144cd..9f664c241149362d44d3a8fa65e2266f9c2e80e0 100644 > --- a/drivers/media/platform/qcom/iris/iris_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_buffer.c > @@ -413,6 +413,16 @@ static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane, bool > } > } > > + if (force) { > + buffers = &inst->buffers[BUF_PERSIST]; > + > + list_for_each_entry_safe(buf, next, &buffers->list, list) { > + ret = iris_destroy_internal_buffer(inst, buf); > + if (ret) > + return ret; > + } > + } > + > return 0; > } > > Why is the logic here not to simply release every index of the enum iris_buffer_type ? If I'm reading the code right here, len indicates the list of linked lists to free, adding BUF_PERSIST appends to the list that may be freed if force is true but, then what about the remaining entries BUF_SCRATCH_1 ? Is it valid to leave this routine with force = true but BUF_SCRATCH_1 not specifically indexed, if so why ? --- bod