From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9D2644B66E for ; Tue, 20 Jan 2026 15:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768921480; cv=none; b=MCuLKL50KEJT2G8WVQK0jefAmSYH8lJ5sQOkrMQW5tUtNYNtCWmv2DWApbVOyTyU1EilGH/NPEwMHmyKCVNHSXhhK/bRcBn88T62v2lfZb6d7Ha1eGozXSj7mBj/LaJ8crASzqXwcogdq9JbdZbsBC+NvRwEQQKKFa98xJFa/ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768921480; c=relaxed/simple; bh=8TWiJFVAWlmQSOEJlWT81c5vMI/uHXJlD/VJBUMnX9Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LSLq1hmpvwF96RIu/SenrZ2Xf3kO4aadbIheR6t2q/halEHdX7p1uXgzSto0tWp0zlLi4fR9QDXDXBkHtZdyBNvCF9WvetpsVWb7StMEiHwmvLIB34wNiZ+AcPFlKrd/mAzHZNpJihLP7DIP8CgxLR0IszjPilj33prS57MyFF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tzs4kiRR; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tzs4kiRR" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47d63594f7eso39062175e9.0 for ; Tue, 20 Jan 2026 07:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768921475; x=1769526275; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=azo35AVekaAyEmPEGy67XUVv//bc0OPEwvS/iMUEgX0=; b=tzs4kiRRn2BHVfNossy1WlMmS5KHzyhHZVZVJiXPIZy6J5PKkzSP92UJgY8svAFVaa kSvVz3LTtC6cKTLtew7PsGvkNHjd8RGeyiGNEa4sTImSgLYSxp3sa9vUaO8ZacfsFUbG mgtz/qt43m+KSfYsuQ22a/ksscQYGKMJ3PxmbLFW/zTg7iu6xPPy9oUa8x2EPkRQl54f tH8e46eeS20bkPdbB8v+vwsukY0gVcdcRDreh162pLrxOmY+I6n7dPd+LQSNVWtYp/3v HV/Rj3/QhvK0QqlFhvvK0bAQidw93kRDABUi9rR2tctr/98zgYwcpk02biMK7U4n7m+E /rsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768921475; x=1769526275; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=azo35AVekaAyEmPEGy67XUVv//bc0OPEwvS/iMUEgX0=; b=A+XrvVTchu2qni/aYdIaj+5js9eUKbpERIpNxhzZZkMaMm30Gz9umtamMxxa/u8aOP OmgWJhdS4IulM94on0ncv/UGW7QXt2kzu5+nU8LXJOFW7LY4yVT5U3uVNL3OffPR40kb DnefJ8GZk5xqVvOolVnxjGOzZzvFWQoifezdtcDtgswiPJ8tkshGhrDXlmghEUptOkeR Oy7usP3pbYNAZq0w3AD00DTeUWGU6KyJUbEXbtJARH+IZhMNKtUMqbEFGA8oG9R+D/IO lGZIu6/RgKUr65D7QIqHPzlbb7HWWf5s3SseBZOGYb/D1AuDt+/DKKMLcSpG1ZBhOIq2 C3PQ== X-Forwarded-Encrypted: i=1; AJvYcCVPSFl4OtEPsLYhzUwShIYHeEa1HU2iq0xfys1RJq87urbfRJ7mrXfWX38bcsMexKk99XtftlLBP9NPF+g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/Rm8FwTUbmcUl9lq+gjAGiWGUxTtQnPu02BvZeGyfeMAUPuZI SeLoubqBhm0naM8D3svcQek0KZsuW19SuyqxBh4HaKrw7NEDV02PrrztUojSsLkF4aM= X-Gm-Gg: AY/fxX7WtMao2NLHwYb1mOYbSlMYAw1DJNp0iHMHUtOBbDIdwr3QTgaOq68Mq68rJ34 D45l3+XkT5n4YHUkX6pPd33bNudRVM2zBbtBytx+VkVpsr7r0ei7E86SjOtbp7QLKcX1DCtSjj6 NkVJP4H6b+pmESQPCmK0DKeCJ+nYn13Qkj8ftavCtOzjZnwErwQ0nrpbpyIp64Mviw+5UjX1rVZ q6W0WQPvXxsHG2o1qvpnsTT7PShmG1aEPfkOD0wXhWabLvSvyfX/oZo4CsEa+gyugQDky8xsWoE d/DA2d05+z9k8YQNwysJlytYgli/uem+BgzF4GhLsQnBqp8CBlz4DL0jZ+QwvcsWs01olvGLpqy Lttlt5te3ihmx1+A2SoHVzST3dM94q1IkpgVLje7gB/0FR7fUGsI5jTKZW++Wdk5P/TnVW7NArH 0+d1PE89HhYHsMc4xNeqrO74mCv+oumhjmc6FaqbBi7DLLXFmh+BkZjbAcxm1h7YVDOQ== X-Received: by 2002:a05:600c:8b58:b0:47b:e2a9:2bd9 with SMTP id 5b1f17b1804b1-4801e345987mr218981265e9.31.1768921475003; Tue, 20 Jan 2026 07:04:35 -0800 (PST) Received: from ?IPV6:2a05:6e02:1041:c10:73c1:f0e1:c420:e523? ([2a05:6e02:1041:c10:73c1:f0e1:c420:e523]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4801fe3ae95sm110898435e9.4.2026.01.20.07.04.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 07:04:34 -0800 (PST) Message-ID: <9563edd5-aa0c-4a43-9a42-15fd34e1c918@linaro.org> Date: Tue, 20 Jan 2026 16:04:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] clocksource/drivers/timer-ti-dm: Add clocksource support To: "Markus Schneider-Pargmann (TI.com)" , Thomas Gleixner Cc: Vishal Mahaveer , Kevin Hilman , Dhruva Gole , Sebin Francis , Kendall Willis , Akashdeep Kaur , linux-kernel@vger.kernel.org References: <20251216-topic-ti-dm-clkevt-v6-16-v2-0-bfd7dd085c19@baylibre.com> <20251216-topic-ti-dm-clkevt-v6-16-v2-2-bfd7dd085c19@baylibre.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20251216-topic-ti-dm-clkevt-v6-16-v2-2-bfd7dd085c19@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/16/25 21:03, Markus Schneider-Pargmann (TI.com) wrote: > Add support for using the TI Dual-Mode Timer as a clocksource. The > driver automatically picks the first timer that is marked as always-on > on with the "ti,timer-alwon" property to be the clocksource. > > The timer can then be used for CPU independent time keeping. > > Signed-off-by: Markus Schneider-Pargmann (TI.com) > --- [ ... ] > +static int omap_dm_timer_setup_clocksource(struct dmtimer *timer) > +{ > + struct device *dev = &timer->pdev->dev; > + struct dmtimer_clocksource *clksrc; > + int err; > + > + __omap_dm_timer_init_regs(timer); > + > + timer->reserved = 1; > + > + clksrc = devm_kzalloc(dev, sizeof(*clksrc), GFP_KERNEL); > + if (!clksrc) > + return -ENOMEM; [ ... ] > + clksrc->timer = timer; > + timer->clksrc = clksrc; This is a cyclic dependency which is not desired in general. I suggest to have struct dmtimer_clocksource containing struct dmtimer timer [ ... ] -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog