mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Rob Herring <robh@kernel.org>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Gerald Loacker" <gerald.loacker@wolfvision.net>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Shawn Tu" <shawnx.tu@intel.com>,
	"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	"Mikhail Rudenko" <mike.rudenko@gmail.com>,
	"Krzysztof Hałasa" <khalasa@piap.pl>,
	"Marek Vasut" <marex@denx.de>
Subject: Re: [PATCH 1/2] dt-bindings: media: i2c: add imx415 cmos image sensor
Date: Wed, 18 Jan 2023 20:00:17 +0100	[thread overview]
Message-ID: <956672cf-a228-54c9-bd79-14b7b0621c59@wolfvision.net> (raw)
In-Reply-To: <20230118154852.GA55989-robh@kernel.org>

Hi Rob,

On 1/18/23 16:48, Rob Herring wrote:
> On Wed, Jan 18, 2023 at 11:32:38AM +0100, Michael Riesch wrote:
>> Add devicetree binding for the Sony IMX415 CMOS image sensor.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>>  .../bindings/media/i2c/sony,imx415.yaml       | 120 ++++++++++++++++++
>>  MAINTAINERS                                   |   7 +
>>  2 files changed, 127 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
>> new file mode 100644
>> index 000000000000..ae54834a2341
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
>> @@ -0,0 +1,120 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/i2c/sony,imx415.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Sony IMX415 CMOS Image Sensor
>> +
>> +maintainers:
>> +  - Michael Riesch <michael.riesch@wolfvision.net>
>> +
>> +description: |-
>> +  The Sony IMX415 is a diagonal 6.4 mm (Type 1/2.8) CMOS active pixel type
>> +  solid-state image sensor with a square pixel array and 8.46 M effective
>> +  pixels. This chip operates with analog 2.9 V, digital 1.1 V, and interface
>> +  1.8 V triple power supply, and has low power consumption.
>> +  The IMX415 is programmable through I2C interface. The sensor output is
>> +  available via CSI-2 serial data output (two or four lanes).
>> +
>> +allOf:
>> +  - $ref: ../video-interface-devices.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: sony,imx415
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    description: Input clock (24 MHz, 27 MHz, 37.125 MHz, 72 MHz or 74.25 MHz)
>> +    items:
>> +      - const: inck
>> +
>> +  avdd-supply:
>> +    description: Analog power supply (2.9 V)
>> +
>> +  dvdd-supply:
>> +    description: Digital power supply (1.1 V)
>> +
>> +  ovdd-supply:
>> +    description: Interface power supply (1.8 V)
>> +
>> +  reset-gpios:
>> +    description: Sensor reset (XCLR) GPIO
>> +    maxItems: 1
>> +
>> +  flash-leds: true
>> +
>> +  lens-focus: true
>> +
>> +  orientation: true
>> +
>> +  rotation: true
>> +
>> +  port:
>> +    $ref: /schemas/graph.yaml#/properties/port
> 
> /properties/port is for when there are no extra properties. You need 
> /$defs/port-base here since there are extra properties in the endpoint 
> node.

Aaahhh, thanks for the pointer! I was really out of ideas what causes
this error. dt_binding_check now completes successfully.

I'll fix it in v2.

Best regards,
Michael

> 
>> +
>> +    properties:
>> +      endpoint:
>> +        $ref: /schemas/media/video-interfaces.yaml#
>> +        unevaluatedProperties: false
>> +
>> +        properties:
>> +          data-lanes: true
>> +          link-frequencies: true
>> +
>> +        required:
>> +          - data-lanes
>> +          - link-frequencies
>> +
>> +    required:
>> +      - endpoint
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clocks
>> +  - clock-names
>> +  - avdd-supply
>> +  - dvdd-supply
>> +  - ovdd-supply
>> +  - port
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/gpio/gpio.h>
>> +
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        imx415: camera-sensor@1a {
>> +            compatible = "sony,imx415";
>> +            reg = <0x1a>;
>> +            avdd-supply = <&vcc2v9_cam>;
>> +            clocks = <&clock_cam>;
>> +            clock-names = "inck";
>> +            dvdd-supply = <&vcc1v1_cam>;
>> +            ovdd-supply = <&vcc1v8_cam>;
>> +            lens-focus = <&vcm>;
>> +            rotation = <180>;
>> +            orientation = <2>;
>> +            reset-gpios = <&gpio_expander 14 GPIO_ACTIVE_LOW>;
>> +
>> +            port {
>> +                imx415_ep: endpoint {
>> +                    remote-endpoint = <&mipi_in>;
>> +                    clock-lanes = <0>;
>> +                    data-lanes = <1 2>;
>> +                };
>> +            };
>> +        };
>> +    };
>> +...
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index f61eb221415b..c9fa893bf649 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -19493,6 +19493,13 @@ T:	git git://linuxtv.org/media_tree.git
>>  F:	Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
>>  F:	drivers/media/i2c/imx412.c
>>  
>> +SONY IMX415 SENSOR DRIVER
>> +M:	Michael Riesch <michael.riesch@wolfvision.net>
>> +L:	linux-media@vger.kernel.org
>> +S:	Maintained
>> +T:	git git://linuxtv.org/media_tree.git
>> +F:	Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
>> +
>>  SONY MEMORYSTICK SUBSYSTEM
>>  M:	Maxim Levitsky <maximlevitsky@gmail.com>
>>  M:	Alex Dubov <oakad@yahoo.com>
>> -- 
>> 2.30.2
>>

  reply	other threads:[~2023-01-18 19:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 10:32 [PATCH 0/2] media: i2c: add imx415 cmos image sensor driver Michael Riesch
2023-01-18 10:32 ` [PATCH 1/2] dt-bindings: media: i2c: add imx415 cmos image sensor Michael Riesch
2023-01-18 15:26   ` Rob Herring
2023-01-18 15:48   ` Rob Herring
2023-01-18 19:00     ` Michael Riesch [this message]
2023-01-18 10:32 ` [PATCH 2/2] media: i2c: add imx415 cmos image sensor driver Michael Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=956672cf-a228-54c9-bd79-14b7b0621c59@wolfvision.net \
    --to=michael.riesch@wolfvision.net \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=gerald.loacker@wolfvision.net \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@pengutronix.de \
    --cc=khalasa@piap.pl \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=marex@denx.de \
    --cc=mchehab@kernel.org \
    --cc=mike.rudenko@gmail.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shawnguo@kernel.org \
    --cc=shawnx.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®