From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6ED0C48BD7 for ; Thu, 27 Jun 2019 07:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8257205C9 for ; Thu, 27 Jun 2019 07:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbfF0HjJ convert rfc822-to-8bit (ORCPT ); Thu, 27 Jun 2019 03:39:09 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:41424 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbfF0HjI (ORCPT ); Thu, 27 Jun 2019 03:39:08 -0400 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 94EBF608933C; Thu, 27 Jun 2019 09:39:05 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Ivp6XWU4T35t; Thu, 27 Jun 2019 09:39:03 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id D96256058370; Thu, 27 Jun 2019 09:39:03 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id egR4gjt9nay2; Thu, 27 Jun 2019 09:39:03 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 97FE5608F445; Thu, 27 Jun 2019 09:39:03 +0200 (CEST) Date: Thu, 27 Jun 2019 09:39:03 +0200 (CEST) From: Richard Weinberger To: Masahiro Yamada Cc: Vignesh Raghavendra , Boris Brezillon , linux-kernel , Marek Vasut , linux-mtd , Miquel Raynal , Brian Norris , David Woodhouse Message-ID: <957967732.18164.1561621143523.JavaMail.zimbra@nod.at> In-Reply-To: References: <20190618030926.30616-1-yamada.masahiro@socionext.com> <1318390798.95477.1560838785550.JavaMail.zimbra@nod.at> Subject: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF60 (Linux)/8.8.12_GA_3809) Thread-Topic: jffs2: remove C++ style comments from uapi header Thread-Index: mLkG8opj4qiXCqlqmfdzmCV5mc5Zxg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Masahiro Yamada" > An: "richard" > CC: "Vignesh Raghavendra" , "Boris Brezillon" , "linux-kernel" > , "Marek Vasut" , "linux-mtd" , > "Miquel Raynal" , "Brian Norris" , "David Woodhouse" > > Gesendet: Donnerstag, 27. Juni 2019 09:06:31 > Betreff: Re: [PATCH v2] jffs2: remove C++ style comments from uapi header > On Tue, Jun 18, 2019 at 3:20 PM Richard Weinberger wrote: >> >> ----- Ursprüngliche Mail ----- >> > Von: "Masahiro Yamada" >> > An: "linux-mtd" >> > CC: "Boris Brezillon" , "Miquel Raynal" >> > , "Brian Norris" >> > , "Vignesh Raghavendra" , "Marek >> > Vasut" , >> > "Masahiro Yamada" , "richard" , >> > "David Woodhouse" , >> > "linux-kernel" >> > Gesendet: Dienstag, 18. Juni 2019 05:09:26 >> > Betreff: [PATCH v2] jffs2: remove C++ style comments from uapi header >> >> > Linux kernel tolerates C++ style comments these days. Actually, the >> > SPDX License tags for .c files start with //. >> > >> > On the other hand, uapi headers are written in more strict C, where >> > the C++ comment style is forbidden. >> > >> > I simply dropped these lines instead of fixing the comment style. >> > >> > This code has been always commented out since it was added around >> > Linux 2.4.9 (i.e. commented out for more than 17 years). >> > >> > 'Maybe later...' will never happen. >> >> :-) >> >> > Signed-off-by: Masahiro Yamada >> >> Acked-by: Richard Weinberger >> >> Thanks, >> //richard > > > Will this be picked up for v5.3-rc1 ? Yes. Thanks, //richard