From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E556EB64DD for ; Fri, 28 Jul 2023 21:41:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234769AbjG1Vlv (ORCPT ); Fri, 28 Jul 2023 17:41:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231244AbjG1Vls (ORCPT ); Fri, 28 Jul 2023 17:41:48 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 739F94209 for ; Fri, 28 Jul 2023 14:41:47 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-780c89d1998so35725139f.1 for ; Fri, 28 Jul 2023 14:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1690580507; x=1691185307; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PUeGfALAME/y+62b/SXO+hiWPsPSwFR5PHWXvkAU+T8=; b=Mw+UzKX+v2AR5xR6CrIngAYGwUYqbH+HJAyGE/yOu3fpBBRlrUWaQJ+7vWH45qAe+7 2d0oZycCE9+uPTmHpUPshSXv+vktEYQC7Zfy3+BW2aOuIEyvwuYBKQjoy0AngU6vBWZy MY8MIQ3KF5JbE0gGT27G+628Jc8JCS7tAWGbk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690580507; x=1691185307; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PUeGfALAME/y+62b/SXO+hiWPsPSwFR5PHWXvkAU+T8=; b=QyV5M/9VyEdCiO4vnwY2mCzSmBlCRoY4JDDETsB6OxWl2ProC+uOXCNIawHoBWpt0b d26/LGZB0hnQ6IMEbWluLXoWAGYMICLlPeASeQI1WtG3j99RRFCzlK8rxLrgr7ogVbSu 1K+PX3vjI2QYyyUrcLy0qJ1rRufjKMkTqUDYJLyISebbNUQZcKzGp8b0Lopg9c8h9agd sRM1C0hEu0/wTfLshLqPoUqfN2VDDO2BPu5D8fgZKXUmwUCa/VDdIr/BzpcaVGdw7Ep0 TBxb5dn3qUQ5lzX/jpVxAbDIAfpR0z6cGzjBXvoWvecUzQ1M0qNtKVG760DLZi06XPwj AiNA== X-Gm-Message-State: ABy/qLaURM7l6c3T2CyJKM27m2W6Af+VUQaVvvkTjn7rJxQFNGD+fawE JRYtqvcrYIKcfZ3FTUZFtEzMPg== X-Google-Smtp-Source: APBJJlFyBQa1mgyamrkCASTogeoUQVKr+RzrDBBpAvt2qCZaEbqOU6HCiCKufm+Pr1tdeGiROiuUEA== X-Received: by 2002:a05:6602:1543:b0:780:c6bb:ad8d with SMTP id h3-20020a056602154300b00780c6bbad8dmr1061026iow.0.1690580506837; Fri, 28 Jul 2023 14:41:46 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id h3-20020a02c723000000b0041fb2506011sm1338239jao.172.2023.07.28.14.41.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 14:41:46 -0700 (PDT) Message-ID: <957be0e8-2bdf-80f4-92b7-3b9070c546b3@linuxfoundation.org> Date: Fri, 28 Jul 2023 15:41:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH next 3/3] selftests:connector: Add root check and fix arg error paths to skip To: Anjali Kulkarni Cc: Shuah Khan , Liam Howlett , "kuba@kernel.org" , "davem@davemloft.net" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Shuah Khan References: <2c0ac97f9c8e6bd46b60854c136099c0dd4a09f6.1690564372.git.skhan@linuxfoundation.org> <0CB227BA-69FD-447F-BE73-2482A6998F7E@oracle.com> <5b283f3b-f176-7f19-5db0-1332a94a44be@linuxfoundation.org> <16B47831-5F53-4BAF-B347-A1404D2ED264@oracle.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <16B47831-5F53-4BAF-B347-A1404D2ED264@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/23 15:21, Anjali Kulkarni wrote: > > >> On Jul 28, 2023, at 12:44 PM, Shuah Khan wrote: >> >> On 7/28/23 13:06, Shuah Khan wrote: >>> On 7/28/23 12:10, Anjali Kulkarni wrote: >>>> >>>> >>>>> On Jul 28, 2023, at 10:29 AM, Shuah Khan wrote: >>>>> >>>>> proc_filter test requires root privileges. Add root privilege check >>>>> and skip the test. Also fix argument parsing paths to skip in their >>>>> error legs. >>>>> >>>>> Signed-off-by: Shuah Khan >>>>> --- >>>>> tools/testing/selftests/connector/proc_filter.c | 9 +++++++-- >>>>> 1 file changed, 7 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c >>>>> index 4fe8c6763fd8..7b2081b98e5c 100644 >>>>> --- a/tools/testing/selftests/connector/proc_filter.c >>>>> +++ b/tools/testing/selftests/connector/proc_filter.c >>>>> @@ -248,7 +248,7 @@ int main(int argc, char *argv[]) >>>>> >>>>> if (argc > 2) { >>>>> printf("Expected 0(assume no-filter) or 1 argument(-f)\n"); >>>>> - exit(1); >>>>> + exit(KSFT_SKIP); >>>>> } >>>>> >>>>> if (argc == 2) { >>>>> @@ -256,10 +256,15 @@ int main(int argc, char *argv[]) >>>>> filter = 1; >>>>> } else { >>>>> printf("Valid option : -f (for filter feature)\n"); >>>>> - exit(1); >>>>> + exit(KSFT_SKIP); >>>>> } >>>>> } >>>>> >>>>> + if (geteuid()) { >>>>> + printf("Connector test requires root privileges.\n"); >>>>> + exit(KSFT_SKIP); >>>>> + } >>>>> + >>>> >>>> I am not sure why you have added this check? proc_filter does not need root privilege to run. >>>> >>> It failed for me when I ran it saying it requires root privileges. >>> I had to run it as root. >> >> The following is what I see when I run the test as non-root >> user: >> >> bind failed: Operation not permitted >> > > Yes, that’s expected on a kernel which does not have the kernel patches submitted with this selftest installed on it. > So this check for root needs to be removed. > I will send v2 for this patch without root check. I should have split the argument error paths and root check anyway. However, what is strange is if the test run by root, bind() doesn't fail. This doesn't make sense to me based on what you said about bind() fails if kernel doesn't support the new feature. That sounds like a problem if the test can be run by non-root user and it should fail if kernel doesn't have the feature included. I would think the bind() should fail for root and non-root users. The bind() failure should be skip if it is an indication of feature not being supported on the kernel. thanks, -- Shuah