From: Julia Lawall <julia.lawall@inria.fr>
To: Sasha Levin <sashal@kernel.org>
Cc: workflows@vger.kernel.org, ksummit@lists.linux.dev,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Mark Brown <broonie@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Leon Romanovsky <leon@kernel.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Thorsten Leemhuis <linux@leemhuis.info>,
"Michael S. Tsirkin" <mst@redhat.com>,
Kees Cook <kees@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Dan Carpenter <error27@gmail.com>,
Miguel Ojeda <ojeda@kernel.org>
Subject: Re: [PATCH v3 6/7] agents: add a skill to find other instances of a fixed bug
Date: Fri, 16 Oct 2026 14:00:15 -0400 (EDT) [thread overview]
Message-ID: <957f530-7954-3e2c-9975-d369af37270@inria.fr> (raw)
In-Reply-To: <20261016152828.3765695-7-sashal@kernel.org>
On Fri, 16 Oct 2026, Sasha Levin wrote:
> A bug fixed in one place often exists elsewhere, in copied code, sibling
> drivers, or other users of the same interface, and reviewers routinely
> ask whether that was checked. Left alone, agents tend to audit the whole
> tree by reading it. Add a skill that states the defect as a rule,
> searches for it through shared interfaces, copied code, the introducing
> series and earlier fixes, and verifies each candidate before reporting
> it.
>
> When Coccinelle is available, the skill searches with a semantic patch:
> it looks for an existing one under scripts/coccinelle/, checks that the
> rule marks the fixed site in the code before the fix, runs it over the
> whole tree with coccicheck, and checks which code spatch could not
> parse. These steps live in references/coccinelle.md, which the agent
> reads only when it uses Coccinelle.
Could I get some feedback from this? I would be interested to know about
code that it can't parse. Maybe AI could write a semantic patch and try
it?
julia
>
> Tested on the parent of commit 989fe6771266 ("drm/nouveau/gsp: fix
> mismatched alloc/free for kvmalloc()"): both the existing
> api/kfree_mismatch.cocci and the example rule mark the two kfree() calls
> that commit fixed, and a whole-tree run found the same bug in four other
> drivers that were later fixed separately.
>
> The sites found are reported, not fixed; each needs its own fix, Fixes
> tag and stable decision. Point the bug-fix procedure in
> coding-assistants.rst at the skill.
>
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> Documentation/process/coding-assistants.rst | 5 +-
> agents/skills/find-siblings/SKILL.md | 31 +++++++++
> .../find-siblings/references/coccinelle.md | 66 +++++++++++++++++++
> 3 files changed, 101 insertions(+), 1 deletion(-)
> create mode 100644 agents/skills/find-siblings/SKILL.md
> create mode 100644 agents/skills/find-siblings/references/coccinelle.md
>
> diff --git a/Documentation/process/coding-assistants.rst b/Documentation/process/coding-assistants.rst
> index fc4e98fd96e11..a89a33980c41f 100644
> --- a/Documentation/process/coding-assistants.rst
> +++ b/Documentation/process/coding-assistants.rst
> @@ -39,6 +39,8 @@ The following skills are available:
> checks an existing one.
> * agents/skills/stable-tag/SKILL.md decides whether a fix goes to stable and
> returns its stable tag, or checks an existing one.
> +* agents/skills/find-siblings/SKILL.md looks for the same bug elsewhere in the
> + tree.
>
> Licensing and Legal Requirements
> ================================
> @@ -101,7 +103,8 @@ these steps:
> 5. Build and verify that the fix works either using the reproducer or by
> re-running a complete analysis; drop any fix that doesn't work and try
> another one. The fix must not add build warnings and must pass the
> - checkpatch.pl checks (see submitting-patches.rst).
> + checkpatch.pl checks (see submitting-patches.rst). Then look for the same
> + bug elsewhere with the find-siblings skill.
> 6. Commit the working fix with a detailed message describing the problem, the
> solution, a Fixes tag determined with the find-fixes skill, and a stable tag
> if the stable-tag skill calls for one. Do not add a Signed-off-by tag, and
> diff --git a/agents/skills/find-siblings/SKILL.md b/agents/skills/find-siblings/SKILL.md
> new file mode 100644
> index 0000000000000..471ce8d9c0bd6
> --- /dev/null
> +++ b/agents/skills/find-siblings/SKILL.md
> @@ -0,0 +1,31 @@
> +---
> +# SPDX-License-Identifier: GPL-2.0-only
> +name: find-siblings
> +description: >-
> + Find other places in the Linux kernel tree that have the same defect as a
> + bug being fixed, and verify each candidate. Use after fixing or reviewing
> + a bug fix, or when asked whether the same bug exists elsewhere.
> +---
> +
> +# Find other instances of a bug
> +
> +Follow the rules for skills in Documentation/process/coding-assistants.rst.
> +
> +- State the defect as a rule that does not depend on local names, such as
> + "memory from kvmalloc() is released with kfree()".
> +- Search the tree as it was before the fix, not the working tree. Look at
> + other users of the same interface, field or lock, code copied from the same
> + origin, the rest of the series that introduced the bug, and earlier fixes
> + for the same defect. Limit history searches to the relevant directories.
> +- If Coccinelle is available (`spatch --version` works), search for the
> + defect with a semantic patch as
> + [references/coccinelle.md](references/coccinelle.md) describes. Otherwise
> + use text searches and report that limit.
> +- A match is a lead. Read each candidate with its callers, locking and object
> + lifetimes, and classify it as confirmed, safe or undetermined, with the
> + reason. Check whether a confirmed site is already fixed in the current tree
> + or in a pending tree such as linux-next.
> +
> +Return the searches you ran and their scope, and the classified sites with
> +their maintainers. Do not fix the sites: each confirmed one is a separate bug
> +that needs its own fix, Fixes tag and stable decision.
> diff --git a/agents/skills/find-siblings/references/coccinelle.md b/agents/skills/find-siblings/references/coccinelle.md
> new file mode 100644
> index 0000000000000..6b09ce9d04c8c
> --- /dev/null
> +++ b/agents/skills/find-siblings/references/coccinelle.md
> @@ -0,0 +1,66 @@
> +<!-- SPDX-License-Identifier: GPL-2.0-only -->
> +
> +# Searching for a bug pattern with Coccinelle
> +
> +Documentation/dev-tools/coccinelle.rst describes `make coccicheck` and its
> +options. The semantic patch language is documented at
> +https://coccinelle.gitlabpages.inria.fr/website/docs/.
> +
> +1. Look under `scripts/coccinelle/` for a semantic patch that already covers
> + the defect. Read its rules rather than its name: `kfree()` of memory from
> + `kvmalloc()` is covered by `api/kfree_mismatch.cocci`, while
> + `api/kvmalloc.cocci` only flags an open-coded `is_vmalloc_addr()` test.
> +
> +2. Otherwise, write a semantic patch outside the repository. Match only what
> + the defect needs, not names or statements specific to the fixed site. Mark
> + the lines of interest with `*`, and declare `virtual context`: coccicheck
> + passes `-D context`, and spatch rejects a mode the file does not declare.
> + A minimal rule for memory from `kvmalloc()` released with `kfree()`, a
> + case that `api/kfree_mismatch.cocci` covers more completely:
> +
> + virtual context
> +
> + @@
> + expression E;
> + @@
> + E = \(kvmalloc\|kvzalloc\|kvcalloc\|kvmalloc_array\)(...);
> + ...
> + * kfree(E);
> +
> +3. Check that it finds the site you fixed. Coccinelle reads the files on
> + disk, where the fix is usually already applied, so copy the file as it was
> + before the fix to a directory outside the repository and run
> + `spatch -D <mode> --very-quiet --sp-file <rule> <copy>`, with a mode the
> + rule declares on a `virtual` line, such as `context` or `report`. Without
> + `-D`, rules that depend on a mode do not run and nothing is reported. The
> + rule must mark the fixed site in that copy, and nothing in the fixed
> + version. If it misses the site, correct the rule before searching further.
> +
> +4. Search the whole tree:
> +
> + make coccicheck MODE=context COCCI=<rule> DEBUG_FILE=<new log file>
> +
> + - Use a `MODE` the rule declares on a `virtual` line, as in step 3.
> + - In context mode the output is a diff, and each line starting with `-`
> + is a line the rule marked; report mode prints one warning per site.
> + coccicheck searches the files on disk, so a site you already fixed
> + there is not marked; step 3 covers it.
> + - The kernel's `.cocciconfig` makes spatch skip files that do not contain
> + the rule's identifiers, so a whole-tree search is usually quick when the
> + rule names distinctive functions. Add `M=<dir>/` only if it is not.
> + - Give `COCCI` and `DEBUG_FILE` as absolute paths. With `M=`, coccicheck
> + runs from that directory.
> + - Read the log. Without `DEBUG_FILE`, spatch errors are discarded and a
> + broken rule shows only as "coccicheck failed". coccicheck refuses to
> + reuse an existing log file.
> + - Header files are searched only with `SPFLAGS=--include-headers`, or with
> + a `// Options: --include-headers` line at the top of the rule.
> +
> +5. Check what was not searched. Coccinelle skips code it cannot parse without
> + saying so. Run `spatch --parse-c` on the searched files or directories: a
> + nonzero `nb bad` count means part of them was skipped. Search those files
> + another way and report the gap.
> +
> +If the rule marks many sites that turn out to be safe, tighten it, for example
> +with `when !=` constraints, and run it again rather than discarding candidates
> +by hand.
> --
> 2.53.0
>
>
>
next prev parent reply other threads:[~2026-10-16 18:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 15:28 [PATCH v3 0/7] agents: add skills for Fixes tags, stable tags, similar bugs, and commit messages Sasha Levin
2026-10-16 15:28 ` [PATCH v3 1/7] agents: add infrastructure for agent resources Sasha Levin
2026-10-16 16:02 ` Bradley Morgan
2026-10-20 13:29 ` Sasha Levin
2026-10-16 15:28 ` [PATCH v3 2/7] docs: submitting-patches: say which commit a Fixes tag names Sasha Levin
2026-10-16 16:03 ` Bradley Morgan
2026-10-17 8:07 ` Thorsten Leemhuis
2026-10-20 13:54 ` Sasha Levin
2026-10-20 14:26 ` Thorsten Leemhuis
2026-10-16 15:28 ` [PATCH v3 3/7] docs: stable-kernel-rules: drop rules the stable trees do not apply Sasha Levin
2026-10-16 15:59 ` Greg Kroah-Hartman
2026-10-16 16:01 ` Bradley Morgan
2026-10-20 13:29 ` Sasha Levin
2026-10-17 16:44 ` SJ Park
2026-10-16 15:28 ` [PATCH v3 4/7] agents: add a skill to determine Fixes tags Sasha Levin
2026-10-16 16:04 ` Bradley Morgan
2026-10-16 15:28 ` [PATCH v3 5/7] agents: add a skill to determine stable tags Sasha Levin
2026-10-16 16:04 ` Bradley Morgan
2026-10-16 15:28 ` [PATCH v3 6/7] agents: add a skill to find other instances of a fixed bug Sasha Levin
2026-10-16 16:05 ` Bradley Morgan
2026-10-16 18:00 ` Julia Lawall [this message]
2026-10-16 18:09 ` Sasha Levin
2026-10-16 18:17 ` Julia Lawall
2026-10-16 18:32 ` Sasha Levin
2026-10-16 15:28 ` [PATCH v3 7/7] agents: add a skill to write commit messages Sasha Levin
2026-10-16 16:05 ` Bradley Morgan
2026-10-20 13:29 ` Sasha Levin
2026-10-16 16:00 ` [PATCH v3 0/7] agents: add skills for Fixes tags, stable tags, similar bugs, and " Miguel Ojeda
2026-10-20 13:31 ` Sasha Levin
2026-10-20 16:23 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=957f530-7954-3e2c-9975-d369af37270@inria.fr \
--to=julia.lawall@inria.fr \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=error27@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=ksummit@lists.linux.dev \
--cc=laurent.pinchart@ideasonboard.com \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=mst@redhat.com \
--cc=ojeda@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®