From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88B7F33E4 for ; Mon, 13 Jan 2025 19:25:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736796354; cv=none; b=KtDwbNX2ZdF4/3nuiTxo2AXRrwf/nJUj9BUaXIXH0zU0wi6gvxonnf56Tb4I+cIqxXeat8qXUOhh6cMvXCIliWHi6hG2cE9IqIBX/DV7F9cA+6UKl8UkBbiXh3NJQU9hDktt1k2V6Kl8QDPfR5O6dcL69l8nT8NL6m+ouy43WKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736796354; c=relaxed/simple; bh=LStohHgNqiB9a0jWMdSVDJvUGVGBBdfj7CNP5EUqMuU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fYbiI9md6oJq6pqeZk/pHmTM2F/B2SET0LLGqUy249EI7m4P5oSfoWnUN59E0+C00sDY9vlYkTw9gctCEnPLkotds6aT/WeT8rGW0HxVX1LkP0iXHBWMKgIRMZMOkG1Zwt5TT/1EeRYQpzui1gZFtG9rKPxfBgyFAKdsSsFXUfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GlvDxaH0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GlvDxaH0" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50DH3h1v020108 for ; Mon, 13 Jan 2025 19:25:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Lz34Xw3X4pr4DZA43rFUVWHHhjQk9s60FAWJ/bqHi0A=; b=GlvDxaH0g+9AZ3TJ xg+L3dX/5VpW2802mQ0uNVWgpIKQcVoZv1/cBCx6L/YPVGk52yiia6ciVKEkqMkt KoivWKPACrP2x354SCrbAUd6RTFzH00N5t87yNk+/FmP4as7MEEbMKElpaKCc2CQ sxMrx3IsOeCmT4pLSpPGkxS3hNklakxecnA+MWHkAyM3ZDMwlNn65bdHruE8DXuD YXviuBp7R5U62Bf2jNRw36IRn2cbL7gj4SLKOj7rJxIwUrzy+Lr9aWRJ2ecZspbk rJNeW1s116yPvHj7eajg1Jgn7QYAVE2DYIFjdKMiGm/WZ1nkcGEAi+R5a4wLWiaF rtttMg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4456wa8bp1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 13 Jan 2025 19:25:52 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-216387ddda8so89692955ad.3 for ; Mon, 13 Jan 2025 11:25:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736796351; x=1737401151; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lz34Xw3X4pr4DZA43rFUVWHHhjQk9s60FAWJ/bqHi0A=; b=jcGr25tYaTxeUsa/R1gvNYIddOYkIevc+5jsCWR2cpndi9R4sBLyoXE0HJytNk+hKf Z+URVz+bxQ5tu/wPiCQZuMQEHl57ArB8zQ/ED0Rl9WVg8tGFyeTNGzY4uj9URmDN2FgS deporo4wAcRwsvUgONbpgIpxgTW7YQsX5nryWZOY1KwzJ5yVfP0znZAtBLbBvPfgzpFG O6iw7QmX5r9ksg3BaRkalH9mCqNlT9vMLA+zo7cUeSpCzqfGn6GjLTsYudErUE39rumJ KHonPnIzYpYEtBbgV50hMM8TkSNVnf5ggenchTAKYUamdV3AINAWpRW8QwvMIp8SXjp3 MgUw== X-Forwarded-Encrypted: i=1; AJvYcCW0srVJapL/7K9VuedFXg/Z+YIcLI/MSGeiHBfj9N+TKZH2iptOuf/EPp9B0iQ/zefbyJ5gLg6tCB+LxsU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx6LnYftMfXqEWMmt3EDtw9PNGRD31qIP5OPyrB1in+fnh7YKQ tWc8rpGa+zndHhdyhtuGhpIEDmxaUrY+0kpH06E4dRuu6tdl+xN3m9qn7/qZEnn3rzaMDblNjTa fb1Xvda+X5cGQ/NCscOcTKDHrCiWR9PiEhu97hiA5codiOUugTFaCZ6UUQXgYpzQ= X-Gm-Gg: ASbGncvJ/8H76ceVmIawTcxG5zXI1OjeNsZrESLeEl3DHXuJdKtjHkXsynolrdT0+03 rxAS1LxXDtsyzcS3fKlNIrJyGfHoau0vwv2cLngp2hXupIrZOHH3SZhGrXx3aPO/WCBl40E+6Up VyyBomvg8ruHruxSQ4oq3XG7mskh5Bpoho2RyVKFW2BHG3CEtbo5wZsE0MN1gLrrcX8zFaIMg2m FiNVowj05W3T25jXA5TRHIY/4/EJhX34em4PX2idUfQbHLV9obFho3ygPUVnomP757H3k0xlG9T AG4poyvxVck9aqKrO3M6odioMCFgaTo7yPVla56CYGKJTV2UUw== X-Received: by 2002:a17:902:f54a:b0:216:2426:7668 with SMTP id d9443c01a7336-21a83f4bce1mr244800215ad.13.1736796350908; Mon, 13 Jan 2025 11:25:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLpebPF/QX+eZca/ElBLEy2ZhA5voD5qQJNkfygzbLSge2xYPad5A1qUYhWuTSY9XvssJUew== X-Received: by 2002:a17:902:f54a:b0:216:2426:7668 with SMTP id d9443c01a7336-21a83f4bce1mr244799945ad.13.1736796350513; Mon, 13 Jan 2025 11:25:50 -0800 (PST) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f254040sm56419705ad.232.2025.01.13.11.25.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 11:25:50 -0800 (PST) Message-ID: <95825ece-cb16-4010-b189-092c39b6a7a5@oss.qualcomm.com> Date: Mon, 13 Jan 2025 11:25:49 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/10] wifi: ath12k: reset MLO global memory during recovery To: Aditya Kumar Singh , Kalle Valo , Jeff Johnson , Karthikeyan Periyasamy , Harshitha Prem Cc: Kalle Valo , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250109-fix_reboot_issues_with_hw_grouping-v1-0-fb39ec03451e@quicinc.com> <20250109-fix_reboot_issues_with_hw_grouping-v1-10-fb39ec03451e@quicinc.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20250109-fix_reboot_issues_with_hw_grouping-v1-10-fb39ec03451e@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: EabXVRc17Fi7SgSerfe0r_1nnkyAAp8f X-Proofpoint-ORIG-GUID: EabXVRc17Fi7SgSerfe0r_1nnkyAAp8f X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 mlxlogscore=980 priorityscore=1501 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501130155 On 1/8/2025 8:25 PM, Aditya Kumar Singh wrote: > When operating with multiple devices grouped together, the firmware stores > data related to the state machine of each partner device in the MLO global > memory region. If the firmware crashes, it updates the state to 'crashed'. > During recovery, this memory is shared with the firmware again, and upon > detecting the 'crashed' state, it reasserts. This leads to a loop of > firmware asserts and it never recovers. > > Hence to fix this issue, once all devices in the group have been asserted > and powered down, reset the MLO global memory region. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Aditya Kumar Singh Acked-by: Jeff Johnson