From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753429AbbJOO3B (ORCPT ); Thu, 15 Oct 2015 10:29:01 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:61095 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbbJOO27 (ORCPT ); Thu, 15 Oct 2015 10:28:59 -0400 From: Arnd Bergmann To: Eric Auger Cc: Christoffer Dall , linux-arm-kernel@lists.infradead.org, eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, thomas.lendacky@amd.com, patches@linaro.org, suravee.suthikulpanit@amd.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] VFIO: platform: AMD xgbe reset module Date: Thu, 15 Oct 2015 16:28:17 +0200 Message-ID: <9585756.nfBEboTrrV@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <561FB63E.4070404@linaro.org> References: <1444836792-2405-1-git-send-email-eric.auger@linaro.org> <20151015121228.GA965@cbox> <561FB63E.4070404@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:yoehANfyQPubrCjrdiVfG25GEawHfzAN8L/6k7ciCkEmQ500ZgJ KmYPDMTIN5lT6YH1D898sdPeEkd6sNz/yCGtOxmZ0gMB6VsMHR+rKPM79eah5/0RNPPH2XR LtMThsm/cyiTULGhC4TdZE1EJBUBi3Q+XVsNl7nw8i190wvo3+SWWpMb3pE+CCpr7pn/x6o RfsB6nBnk9Uuds0YAt6hg== X-UI-Out-Filterresults: notjunk:1;V01:K0:/lFaJE6wGB8=:IjNGSt4olOyLNP1+tkGMfa ynVDKaIg1OgIzQVFQae/Ql0LZX3cC8w0aT82Tqja6FHLRLsrlOSkKmTOAohdipwJQ6LMPZ87k jZVVS3vyTM7rrU3HWTih0Xza6TTbxPuMtpdVNhz38ycFj7hf3nrbaUQMziTz705yF0t2WIYCd MIgfgE2ZkNSyHwhn4ekOshW30SG0OZU5nw56qeBrqVWvVw3IZNDAXRRs5v0ZDABrCaxI8GDGQ yt/hWKsp45nVE7Q/tzyxSAnpBBvcLivF0WtTFwWZWjZ5TNUDix+xbQhBYuR5jAjyPV4nsmo1E QjSMs9lwPjy1QoaAhYZ8Vv1RP/wWmXOcMDzyPM437glE+uhTT/6rWPgGTzOqgQVuMneG11i9H b+AJ5QcsOvES8q3LuIuraEI5sH82BHJWg6Q4TVZCi3uIehnDZSO4qFggxNF9l/mFN9oi2pQ2a /L4p1B8FmVXgMd61NODR9Q60qfGU/ImGFS8lMYDKsyGcwMi0YkkIR9TJwJCtxEirzRSKh21Zk L4xwnH8k6CHRK2fXW/FFGvsFxwLRCBX6Qa/psuiKBwbMNoFq3DLH2LzNcWVxLbIJNncPZgNsQ mHIjcZa/3PcBk+527wMk0TsGkI3bTr5EC8T8DcRZv4sK74FBsjuuKGIlby/U1bBNPSzxPfoSD +9dcp/kqoFp6KLQNXBMTtRWOKb8wiCKaqUP/LTcx08b54hupQrP+oHpokCNgH9KvNubiKSTTk 4aFCZ0ddMKjvZsR1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 15 October 2015 16:20:46 Eric Auger wrote: > On 10/15/2015 02:12 PM, Christoffer Dall wrote: > > On Thu, Oct 15, 2015 at 01:21:55PM +0200, Arnd Bergmann wrote: > >> On Thursday 15 October 2015 10:08:02 Eric Auger wrote: > >>> On 10/14/2015 05:38 PM, Arnd Bergmann wrote: > >>>> On Wednesday 14 October 2015 15:33:12 Eric Auger wrote: > >> A possible solution could be something inside the xgbe driver like > >> > >> > >> static void xgbe_init_module(void) > >> { > >> int ret = 0; > >> > >> if (IS_ENABLED(CONFIG_AMD_XGBE_ETHERNET) > >> ret = platform_driver_register(&xgbe_driver); > >> if (ret) > >> return ret; > >> > >> if (IS_ENABLED(CONFIG_VFIO_PLATFORM)) > >> ret = vfio_platform_register_reset(&xgbe_of_match, xgbe_platform_reset); > >> > >> return ret; > >> } > >> > >> This way you have exactly one driver module that gets loaded for the > >> device and you can use it either with the platform_driver or through > >> vfio. > If I understand it correctly you still need 2 loaded modules (VFIO > driver & XGBE driver which implements the reset function) or am I > missing something? That is correct, yes. > I had a similar mechanism of registration in my PATCH v1 but I did the > registration from the reset module itself instead of in the native > driver, as you suggest here. Right. The main difference is that you don't have two modules fighting over the same device with the approach here. Arnd