From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F9FC77B7D for ; Fri, 5 May 2023 10:54:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231866AbjEEKyT (ORCPT ); Fri, 5 May 2023 06:54:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbjEEKyK (ORCPT ); Fri, 5 May 2023 06:54:10 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A3B34F4; Fri, 5 May 2023 03:54:08 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A18C51FB; Fri, 5 May 2023 03:54:52 -0700 (PDT) Received: from [10.57.21.147] (unknown [10.57.21.147]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6EF23F64C; Fri, 5 May 2023 03:54:04 -0700 (PDT) Message-ID: <958ae925-dee2-3273-0cd6-b5edc891ba70@arm.com> Date: Fri, 5 May 2023 11:54:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 2/3] dt-bindings: arm: Add Coresight Dummy Trace To: Hao Zhang , Mike Leach , Leo Yan , Alexander Shishkin , Mathieu Poirier , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Andy Gross , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jonathan Corbet Cc: Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Jinlong Mao , Yuanfang Zhang , Tao Zhang , Trilok Soni , linux-arm-msm@vger.kernel.org, Bjorn Andersson , linux-doc@vger.kernel.org References: <20230505092422.32217-1-quic_hazha@quicinc.com> <20230505092422.32217-3-quic_hazha@quicinc.com> From: Suzuki K Poulose In-Reply-To: <20230505092422.32217-3-quic_hazha@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/2023 10:24, Hao Zhang wrote: > Add new coresight-dummy.yaml file describing the bindings required > to define coresight dummy trace in the device trees. > > Signed-off-by: Hao Zhang > --- > .../bindings/arm/arm,coresight-dummy.yaml | 102 ++++++++++++++++++ > 1 file changed, 102 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dummy.yaml > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy.yaml > new file mode 100644 > index 000000000000..126518863eea > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy.yaml > @@ -0,0 +1,102 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/arm,coresight-dummy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ARM Coresight Dummy component > + > +description: | > + Coresight Dummy Trace Module is for the specific devices that kernel > + don't have permission to access or configure, e.g., CoreSight TPDMs > + on Qualcomm platforms. So there need driver to register dummy devices > + as Coresight devices. It may also be used to define components that > + may not have any programming interfaces (e.g, static links), so that > + paths can be established in the driver. Provide Coresight API for > + dummy device operations, such as enabling and disabling dummy devices. > + Build the Coresight path for dummy sink or dummy source for debugging. > + > + The primary use case of the coresight dummy is to build path in kernel > + side for dummy sink and dummy source. > + > +maintainers: > + - Mao Jinlong > + - Tao Zhang > + - Hao Zhang > + - Yuanfang Zhang Given this is a generic "CoreSight" component, I would prefer to have the CoreSight subsystem maintainers listed here (too). I don't mind the entries above, but would like to make sure that the subsystem people are aware of the changes happening here. Please use: Mike Leach Suzuki K Poulose Leo Yan With the above: Acked-by: Suzuki K Poulose > + > +properties: > + compatible: > + items: > + - enum: > + - arm,coresight-dummy-sink > + - arm,coresight-dummy-source > + > + out-ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port: > + description: Output connection from the source to Coresight > + Trace bus. > + $ref: /schemas/graph.yaml#/properties/port > + > + in-ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port: > + description: Input connection from the Coresight Trace bus to > + dummy sink, such as Embedded USB debugger(EUD). > + $ref: /schemas/graph.yaml#/properties/port > + > +required: > + - compatible > + > +if: > + # If the compatible contains the below value > + properties: > + compatible: > + contains: > + const: arm,coresight-dummy-sink > + > +then: > + required: > + - in-ports > + > +else: > + required: > + - out-ports > + > +additionalProperties: false > + > +examples: > + # Minimum dummy sink definition. Dummy sink connect to coresight replicator. > + - | > + sink { > + compatible = "arm,coresight-dummy-sink"; > + > + in-ports { > + port { > + eud_in_replicator_swao: endpoint { > + remote-endpoint = <&replicator_swao_out_eud>; > + }; > + }; > + }; > + }; > + > + # Minimum dummy source definition. Dummy source connect to coresight funnel. > + - | > + source { > + compatible = "arm,coresight-dummy-source"; > + > + out-ports { > + port { > + dummy_riscv_out_funnel_swao: endpoint { > + remote-endpoint = <&funnel_swao_in_dummy_riscv>; > + }; > + }; > + }; > + }; > + > +...