From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751353AbdJWDGF (ORCPT ); Sun, 22 Oct 2017 23:06:05 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52664 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbdJWDGE (ORCPT ); Sun, 22 Oct 2017 23:06:04 -0400 Subject: Re: [PATCH V3] selftests/vm: Add tests validating mremap mirror functionality To: Mike Kravetz , Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20171018055502.31752-1-khandual@linux.vnet.ibm.com> <472ed67c-7c14-29d3-ac22-e9340a05bc06@oracle.com> Cc: mhocko@kernel.org, shuahkh@osg.samsung.com, Andrew Morton From: Anshuman Khandual Date: Mon, 23 Oct 2017 08:35:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <472ed67c-7c14-29d3-ac22-e9340a05bc06@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17102303-0008-0000-0000-000004A2C1E5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17102303-0009-0000-0000-00001E35254C Message-Id: <958ed0c9-6c52-ce4e-e347-eb5d11e84e5f@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-23_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710230043 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/20/2017 04:54 AM, Mike Kravetz wrote: > On 10/17/2017 10:55 PM, Anshuman Khandual wrote: >> This adds two tests to validate mirror functionality with mremap() >> system call on shared and private anon mappings. After the commit >> dba58d3b8c5 ("mm/mremap: fail map duplication attempts for private >> mappings"), any attempt to mirror private anon mapping will fail. >> >> Suggested-by: Mike Kravetz >> Signed-off-by: Anshuman Khandual > The tests themselves look fine. However, they are pretty simple and > could very easily be combined into one 'mremap_mirror.c' file. I > would prefer that they be combined, but it is not a deal breaker. > > Reviewed-by: Mike Kravetz > Hello Andrew/Shuah, Is this okay or should I resend this patch with both tests folded into one test case file ? - Anshuman