From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 023EF2E22A3 for ; Wed, 26 Nov 2025 09:44:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764150283; cv=none; b=l0T6Gk5dzbbbXsnbtrsqIaPtd8csnxp5FRoS4iSEI+aNkjccV0SOND2koxBjiUOzU/RI8Ejy6Sf9nGIFHAQItzzO3cC/Fs5bPVVTDsNITDbQjCeM9FdJx0h2VkQzA4qdvkz95dSPEFUmQEgbAzunDzdFhVBqQneRYrTdteLL1dY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764150283; c=relaxed/simple; bh=pNqR9AEM7+ZOakg8yrIPpT3k6keMkYWNBi3+IO8DwOw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oza1fATPJGqOWwqr5HJ4emmFmqF2UhgdlBr0m2uZbrXuXSeIAhLyQrV18A2pv885rFMkViHyslwPSZDuoXq6DWiQtszd9SR8iXjp942EJBiEaOXVZVPcc4oPTnlUQFpymFJ6grpWAlPF2oA9NwvTul3TYPjcxJePgm6R/aBeuuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iOJ+n71O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ggmS0kWy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iOJ+n71O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ggmS0kWy" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AQ8thbE1522166 for ; Wed, 26 Nov 2025 09:44:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /EmFx9kDHRG496LzQmpF29635F3Dw2LR3j2y5b5Nff8=; b=iOJ+n71Ou8wceuNs +ES47Rs4zm6+tXhuLyI3r3VQWmyQGaxn6YY1Uw4qTqxqdb+Hb8TB+Sl3OtTtF8x5 ngOSdK6aK/djQTYfFdzuw7MiKsAlTsjYzvP0uNMY/VYbEP2KhNDQChA+TORhZpdE hnTDAz80hmPQ1HNkhyueje/9vAZxLvGzAP9rdU8CfaX8CutsGyVitk5KoOj+HCOR D1sd8F3ZUvUELIGU94qvya22Q5g5La75G0kpmqynuuY0KJSx0GWQK+1Ttrk2uZSD 1lQaLl9a7ZzlnZl2CENuAkt1gv/yeWIJNLuk1VO0EhHTQmUWRrg+nQOq1e/W0PwG C8JRxA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4anxfk05vt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Nov 2025 09:44:41 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3418ad76023so12814709a91.0 for ; Wed, 26 Nov 2025 01:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764150281; x=1764755081; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/EmFx9kDHRG496LzQmpF29635F3Dw2LR3j2y5b5Nff8=; b=ggmS0kWyCHIcyfEWds0ekyv57gtd0sToukczu9eU9T20WEcw3Yx8tXkOw7/xDGpwic YJ5V6r+aOZiAAdWFLGx6ykudhBvGhia/lk2rknokQKBUtNxcGQv3BKDLvxAbiE5gbGkv kQQgk24V58pb2NNKYcbwdbNPKyb5ZPGMT48GWnW/8BmeNMgpF8SvsHjXaa7vgQyQs7oF fhWW3zuCrMku8bygCYhodKu/h6uSbY62ry3pT5OMmy8xCaihLntSauxcHhBYCyvfNU8/ sEhoRXa8hdhNM/91wxl6IqL9jQ647hN+xKbB4fr1fMJInor96l2F/RAVq0r5FDEkL44r BXQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764150281; x=1764755081; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/EmFx9kDHRG496LzQmpF29635F3Dw2LR3j2y5b5Nff8=; b=NEqS8qM7YvrmVLEPtAQ/oAiLXm/S+LeCdetozrnorHKuWu9PHCFy4lwq0MKka2Ady7 kuaJddZfLfrJd1ZU7wRfZ21toFeZiYuhOpKY4s8yT10Ta9rmfZW767pfJs49Ne7rNsVj 84+YdKs41nz555Ye1I6oa6PmE5FYYuFjYpVwaxquHPJaXzI97SplPzmJZdbX+OnmO0UF hymJDesDuSi0+b5uqumdtpf+njPv1llXqlbMAk0+jlDV3x9T+l/KvttStmXHQfUbk5bw 9yUo/5bFim4gBKu+B1UmQFs76zNFhWi4CEfDYrHemgWrbY7427l9EbvEGJxcYBkb3JKj zNpw== X-Forwarded-Encrypted: i=1; AJvYcCVd2p4vN5tMDKk3GUMfkqOLamwnV1wvS01ykkcdzZy6RyUDS0FB4UxqOgf2/1oZvGQR2c1OpbPLp1Q8DG0=@vger.kernel.org X-Gm-Message-State: AOJu0YyI8o0HBwRO9MrVTPsRl5qmfMK8VjSCeN+ZjJ0x8yYkQEu3osqw KML9yDWVyFh5oZuXdKep7otlS07m8GfwKSGftjfyAGPRpkgySMlbne7BBQTTDDTW08NZTpS+yyE P04uFDuZv9NwrAV79r2E0YhrKsghCX11xeYsYFcsXLa85UHRI7BVPJCEBAP9AmiyNNmc= X-Gm-Gg: ASbGnctApzcqvucUhvG3EwR0RwIx8oHVGuklfchGo6gz1zMtgkOBuw/sW8mygK3CuPQ T4ZIsQ9yUA7+Z1MEU5/V3lTBxf/NcwHi034mDv8a7ptNMrTcc8mtnb55yOxHFgNUd3FHqbCSiS+ aEPuHEhnOG2pmDkHw3pg+MK72n5uUU8DAlO5WdpPQdB9GYjBiAZrJBWCJuHSP0AW2TYwjSayvcG 8H9PXqbkfJWaNGNp2a5a86VqFpwmcOu+xgQ4n1B8YCpDqKCO/UcphVr+MEczAJS5B6tXWzJU5ii FN6112Hg4kmSYGBVzhHSbcGB4nAYHgtRJHCg7exOwQ/UjYOPHvAeV0gOlDVv3TVEIPIvHo0RxUr hZbMfcpfce2l8sl5pYmoa8tmri0KTDwHMmubETw== X-Received: by 2002:a17:90b:17d1:b0:340:b1b1:3d28 with SMTP id 98e67ed59e1d1-34733f332a8mr16329721a91.25.1764150280648; Wed, 26 Nov 2025 01:44:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQWtfU4EwU3gf/sMuRF13SIm7OqPr00Bhxi3ZsMwr+VwCTnT9swDjrZG7lGrH6JtHUpscU+A== X-Received: by 2002:a17:90b:17d1:b0:340:b1b1:3d28 with SMTP id 98e67ed59e1d1-34733f332a8mr16329694a91.25.1764150280165; Wed, 26 Nov 2025 01:44:40 -0800 (PST) Received: from [10.217.217.147] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3476a54a5a8sm2024876a91.4.2025.11.26.01.44.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Nov 2025 01:44:39 -0800 (PST) Message-ID: <95918b3b-7cba-4c40-a405-b8d7d0a9fa1e@oss.qualcomm.com> Date: Wed, 26 Nov 2025 15:14:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] clk: qcom: gcc-sm4450: Update the SDCC RCGs to use shared_floor_ops To: Jagadeesh Kona , Bjorn Andersson , Michael Turquette , Stephen Boyd , Vinod Koul , Konrad Dybcio , Dmitry Baryshkov , Taniya Das , Melody Olvera , Ajit Pandey , Imran Shaik , Luca Weiss Cc: Ajit Pandey , Imran Shaik , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251126-sdcc_shared_floor_ops-v1-0-9038430dfed4@oss.qualcomm.com> <20251126-sdcc_shared_floor_ops-v1-3-9038430dfed4@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <20251126-sdcc_shared_floor_ops-v1-3-9038430dfed4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Gp9dSopE_Ca6Vo4hHY1adPlMbCLsCbXz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDA3OSBTYWx0ZWRfXw6eolXKXhCMy P5pc/uwxMJixJTrIDRkGOnUimkkesstYIGDisHjdFFH9ocmJLLvJNTi4mUtWCwQYRzfkPaOsXus rN+bm6ZPL1Lig6i3lZoYWw3P0irrBpk1dYbopPNbnhFhJ8HshX9clWAD6rdvs6+KuNtPb4GE11Z AuQ6gmLRjf4r4zP7O7P6wqqoqA77264TUgwsiCEFXk1qsSi3wE/W44C5Glj1FHTM1vTJ7AHQjcH YIds4w/dR2bK3n3yl9Uy99gX+52hPu0kLXyVPDBMnwlSJleliTYJrxspvzSpTrST+YXX6Ee2Cc8 Qz0frqls15jBIYAC6EVFUoIUlaKxOH1T5c9AhPt1gLnmiRQilr7FH9NSWSw+K8YgkPiCLOZWR5l fegm9MNjXs6r8fF+wI03WN98JTmPYw== X-Authority-Analysis: v=2.4 cv=H4LWAuYi c=1 sm=1 tr=0 ts=6926cc09 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=BxFOA6ydGOS16N4CFHUA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: Gp9dSopE_Ca6Vo4hHY1adPlMbCLsCbXz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 impostorscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260079 On 11/26/2025 9:45 AM, Jagadeesh Kona wrote: > Use shared_floor_ops for the SDCC RCGs so the RCG is safely parked > during disable and the new parent configuration is programmed in > hardware only when the new parent is enabled, avoiding cases where > the RCG configuration fails to update. > > Fixes: c32c4ef98bac ("clk: qcom: Add GCC driver support for SM4450") > Signed-off-by: Jagadeesh Kona > --- > drivers/clk/qcom/gcc-sm4450.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sm4450.c b/drivers/clk/qcom/gcc-sm4450.c > index e2d9e4691c5b719adfa86b904394ba85d086c12c..023d840e9f4ef0d6e9e7f16372cb9eb493f623d3 100644 > --- a/drivers/clk/qcom/gcc-sm4450.c > +++ b/drivers/clk/qcom/gcc-sm4450.c > @@ -769,7 +769,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = { > .parent_data = gcc_parent_data_4, > .num_parents = ARRAY_SIZE(gcc_parent_data_4), > .flags = CLK_SET_RATE_PARENT, > - .ops = &clk_rcg2_floor_ops, > + .ops = &clk_rcg2_shared_floor_ops, > }, > }; > > @@ -791,7 +791,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = { > .parent_data = gcc_parent_data_4, > .num_parents = ARRAY_SIZE(gcc_parent_data_4), > .flags = CLK_SET_RATE_PARENT, > - .ops = &clk_rcg2_floor_ops, > + .ops = &clk_rcg2_shared_floor_ops, > }, > }; > > @@ -815,7 +815,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { > .parent_data = gcc_parent_data_6, > .num_parents = ARRAY_SIZE(gcc_parent_data_6), > .flags = CLK_SET_RATE_PARENT, > - .ops = &clk_rcg2_floor_ops, > + .ops = &clk_rcg2_shared_floor_ops, > }, > }; > > Reviewed-by: Taniya Das -- Thanks, Taniya Das