From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752786AbbG1PuI (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jul 2015 11:50:08 -0400
Received: from mail-pa0-f53.google.com ([209.85.220.53]:34919 "EHLO
	mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750883AbbG1PuG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jul 2015 11:50:06 -0400
Date: Tue, 28 Jul 2015 08:50:04 -0700 (PDT)
X-Google-Original-Date: Tue, 28 Jul 2015 08:50 -0700
From: Joshua Clayton <stillcompiling@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Nitin Kuppelur <nitinkuppelur@gmail.com>,
        Dan Carpenter <dan.carpenter@oracle.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates
Message-ID: <9594685.hpOiZGHKrk@jclayton-pc>
User-Agent: KMail/4.14.6 (Linux/3.19.0-21-generic; KDE/4.14.6; x86_64; ; )
In-Reply-To: <alpine.DEB.2.10.1507281735430.2343@hadrien>
References: <cover.1438057939.git.stillcompiling@gmail.com> <ab892a76a6b2b320906357569fde7fa33ff04920.1438057939.git.stillcompiling@gmail.com> <alpine.DEB.2.10.1507281735430.2343@hadrien>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote:
> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > index 83d4bca..1ded691 100644
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > @@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
> >  	/* Add the protocol name */
> >  	iwe.cmd = SIOCGIWNAME;
> >  	if ((r8712_is_cckratesonly_included(pnetwork->network.
> > -	     SupportedRates)) == true) {
> > +	     rates)) == true) {
> >  		if (ht_cap == true)
> >  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
> >  		else
> >  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
> >  	} else if ((r8712_is_cckrates_included(pnetwork->network.
> > -		    SupportedRates)) == true) {
> > +		    rates)) == true) {
> >  		if (ht_cap == true)
> >  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
> >  		else
> 
> The placement of the line breaks here is partucularly unpleasant.  Perhaps
> that could be adjusted now that the field name is shorter.  Theer may be
> some other cases in the patch where the line breaks could be adjusted to
> improve readability.
> 
> julia
I agree. Dan Carpenter earlier complained about me fixing up the lines
while changing the variable name. Should that be a separate patch?

-- 
~Joshua Clayton