From: "Ard Biesheuvel" <ardb@kernel.org>
To: yoxcu <mick@yoxcu.de>, "Georgi Djakov" <djakov@kernel.org>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] interconnect: qcom: sdm845: Own the ALC BCM to drop its boot vote
Date: Tue, 10 Nov 2026 15:13:25 +0100 [thread overview]
Message-ID: <959a716b-c055-4fb5-8b37-04bcb2c382d5@app.fastmail.com> (raw)
In-Reply-To: <20261013202611.3070778-3-mick@yoxcu.de>
On Tue, 13 Oct 2026, at 22:26, yoxcu wrote:
> From: Michael Auer <mick@yoxcu.de>
>
> On the OnePlus 6 the bootloader leaves a vote on the ALC BCM
> (rpmh_read() on the APPS DRV returns 0x2000000f). No driver owns this
> BCM, so the vote is never removed and the SoC never reaches AOSS sleep
> or CX collapse (qcom_stats aosd and cxsd stay at 0).
>
> Add a node without consumers for the ALC BCM on mem_noc. The provider
> then owns the BCM and drops the vote at sync_state.
>
> With this change ALC reads 0 after boot and suspend reaches CX
> collapse. The average current in an idle push standby test (Wi-Fi on)
> was 35.6 mA, against 43.7 mA with the ALC vote kept in the sleep set.
>
> Assisted-by: LLM
> Signed-off-by: Michael Auer <mick@yoxcu.de>
> ---
> drivers/interconnect/qcom/sdm845.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
Tested-by: Ard Biesheuvel <ardb@kernel.org> # Lenovo C630 Yoga
With this change (and a few others), my Yoga now suspends properly,
to the point where it shows the pulsating LED in the power button.
Battery seems much happier too.
next prev parent reply other threads:[~2026-11-10 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 20:26 [PATCH RFC 0/2] interconnect: qcom: sdm845: Drop the bootloader vote on ALC yoxcu
2026-10-13 20:26 ` [PATCH RFC 1/2] dt-bindings: interconnect: qcom,sdm845: Add MASTER_ALC yoxcu
2026-10-13 20:26 ` [PATCH RFC 2/2] interconnect: qcom: sdm845: Own the ALC BCM to drop its boot vote yoxcu
2026-11-10 14:13 ` Ard Biesheuvel [this message]
2026-10-19 12:22 ` [PATCH RFC 0/2] interconnect: qcom: sdm845: Drop the bootloader vote on ALC Konrad Dybcio
2026-10-23 20:02 ` Michael Auer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=959a716b-c055-4fb5-8b37-04bcb2c382d5@app.fastmail.com \
--to=ardb@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mick@yoxcu.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®