From: Ben Dooks <ben.dooks@codethink.co.uk>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Baruch Siach" <baruch@tkos.co.il>,
"Eric Anholt" <eric@anholt.net>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Lee Jones" <lee@kernel.org>, "Chen-Yu Tsai" <wens@csie.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-snps-arc@lists.infradead.org,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Ray Jui" <rjui@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Barry Song" <baohua@kernel.org>,
"Scott Branden" <sbranden@broadcom.com>,
"Vineet Gupta" <vgupta@synopsys.com>,
"Uwe Kleine-König" <kernel@pengutronix.de>,
"Carlo Caione" <carlo@caione.org>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH] clocksource: add missing line break to error messages
Date: Tue, 14 Mar 2017 09:40:07 +0000 [thread overview]
Message-ID: <959bfbfb-177f-3e92-0a2c-1e283966b961@codethink.co.uk> (raw)
In-Reply-To: <20170309094710.31003-1-zajec5@gmail.com>
On 09/03/17 09:47, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Printing with pr_* functions requires adding line break manually.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
I've had a quick look over and there are no obvious errors.
I wonder if the of_iomap() and related calls should print an
error if they fail as all the examples here are of the form
of:
ptr = of_iomap(reource)
if (!ptr) {
pr_err("cannot remap resource\n");
...
return ERR;
}
Maybe we should look into this post this patch series.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
prev parent reply other threads:[~2017-03-14 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 9:47 Rafał Miłecki
2017-03-13 17:51 ` Thierry Reding
2017-03-14 9:40 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=959bfbfb-177f-3e92-0a2c-1e283966b961@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=baohua@kernel.org \
--cc=baruch@tkos.co.il \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=carlo@caione.org \
--cc=daniel.lezcano@linaro.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gnurou@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=lee@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=rafal@milecki.pl \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=swarren@wwwdotorg.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vgupta@synopsys.com \
--cc=wens@csie.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®