From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754682AbcH0P6P convert rfc822-to-8bit (ORCPT ); Sat, 27 Aug 2016 11:58:15 -0400 Received: from linuxhacker.ru ([217.76.32.60]:56018 "EHLO fiona.linuxhacker.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753511AbcH0P6O (ORCPT ); Sat, 27 Aug 2016 11:58:14 -0400 Subject: Re: [PATCH] bridge: Fix format string for %ul Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=windows-1252 From: Oleg Drokin In-Reply-To: <11e50e3c-2e1f-4614-07e3-3bd144af4f94@cogentembedded.com> Date: Sat, 27 Aug 2016 11:58:00 -0400 Cc: Stephen Hemminger , "David S. Miller" , bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <95BF7F27-59F7-4BDA-941B-BB00C60423A4@linuxhacker.ru> References: <1472267428-810527-1-git-send-email-green@linuxhacker.ru> <11e50e3c-2e1f-4614-07e3-3bd144af4f94@cogentembedded.com> To: Sergei Shtylyov X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Aug 27, 2016, at 11:13 AM, Sergei Shtylyov wrote: > Hello. > > On 8/27/2016 6:10 AM, Oleg Drokin wrote: > >> %ul would print an unsigned value and a letter l, >> likely it was %lu that was meant to print the long int, >> but in reality the values printed there are just regular signed > > Signed? Then you need probably "%d" or "%i"… They are signed in the struct definition, but in reality they designate time, so could not be negative, I imagine? > >> ints, so just dropping the l altogether. >> >> Signed-off-by: Oleg Drokin > [...] > > MBR, Sergei