From: Justin Mattock <justinmattock@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: trivial@kernel.org, henryp@broadcom.com, gregkh@suse.de,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8]staging: brcm80211i: sbsdio.h: change a typo comamnd to command
Date: Fri, 4 Feb 2011 13:13:17 -0800 [thread overview]
Message-ID: <95FFFE22-6CF5-4ECF-B2B4-D6835F0F100E@gmail.com> (raw)
In-Reply-To: <20110204210021.GA15713@kroah.com>
On Feb 4, 2011, at 1:00 PM, Greg KH wrote:
> On Fri, Feb 04, 2011 at 12:59:19PM -0800, Greg KH wrote:
>> On Tue, Feb 01, 2011 at 09:07:28PM -0800, Justin P. Mattock wrote:
>>> The below patch fixes a typo comamnd to command.
>>>
>>> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>>>
>>> ---
>>> drivers/staging/brcm80211/include/sbsdio.h | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/staging/brcm80211/include/sbsdio.h b/drivers/
>>> staging/brcm80211/include/sbsdio.h
>>> index 6afdbbe..c190acb 100644
>>> --- a/drivers/staging/brcm80211/include/sbsdio.h
>>> +++ b/drivers/staging/brcm80211/include/sbsdio.h
>>> @@ -144,7 +144,7 @@
>>> */
>>>
>>> #define SBSDIO_BYTEMODE_DATALEN_MAX 64 /* sdio byte mode: maximum
>>> length of one
>>> - * data comamnd
>>> + * data command
>>
>> This patch adds a trailing space, which is not allowed.
>>
>> Please fix this and resend.
>
> Nevermind, I've edited this by hand and fixed it up.
>
> Please be more careful in the future and ALWAYS run your patches
> through
> scripts/checkpatch.pl to catch these types of things.
>
> thanks,
>
> greg k-h
yep I admit I had forgotten to use that script(was focusing on
maintainers)..
I will remember that next time..
Thanks..
Justin P. Mattock
prev parent reply other threads:[~2011-02-04 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 5:07 [PATCH 6/8]drivers:staging:brcm80211i:sbsdio.h " Justin P. Mattock
2011-02-04 20:59 ` [PATCH 6/8]staging: brcm80211i: sbsdio.h: " Greg KH
2011-02-04 21:00 ` Greg KH
2011-02-04 21:13 ` Justin Mattock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95FFFE22-6CF5-4ECF-B2B4-D6835F0F100E@gmail.com \
--to=justinmattock@gmail.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=henryp@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®