From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB15C169C4 for ; Thu, 31 Jan 2019 09:09:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A98B02086C for ; Thu, 31 Jan 2019 09:09:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728701AbfAaJJs (ORCPT ); Thu, 31 Jan 2019 04:09:48 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38564 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725932AbfAaJJr (ORCPT ); Thu, 31 Jan 2019 04:09:47 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0V99ZZU020031 for ; Thu, 31 Jan 2019 04:09:46 -0500 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qbuc5fpbs-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 31 Jan 2019 04:09:45 -0500 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 31 Jan 2019 09:09:44 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 31 Jan 2019 09:09:43 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0V99fQD2097552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 31 Jan 2019 09:09:41 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ED44F42059; Thu, 31 Jan 2019 09:09:40 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 498E842049; Thu, 31 Jan 2019 09:09:40 +0000 (GMT) Received: from [9.152.224.140] (unknown [9.152.224.140]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 31 Jan 2019 09:09:40 +0000 (GMT) Reply-To: pmorel@linux.ibm.com Subject: Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command To: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, freude@linux.ibm.com, pasic@linux.ibm.com, cohuck@redhat.com References: <1548870526-30595-1-git-send-email-akrowiak@linux.ibm.com> From: Pierre Morel Date: Thu, 31 Jan 2019 10:09:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1548870526-30595-1-git-send-email-akrowiak@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19013109-0016-0000-0000-0000024E3729 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19013109-0017-0000-0000-000032A844B7 Message-Id: <95a29dd5-11d5-0984-ffbd-73ef92ed1aba@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-31_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901310073 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/01/2019 18:48, Tony Krowiak wrote: > The current AP bus implementation periodically polls the AP configuration > to detect changes. When the AP configuration is dynamically changed via the > SE or an SCLP instruction, the changes will not be reflected to sysfs until > the next time the AP configuration is polled. The CHSC architecture > provides a Store Event Information (SEI)command to make notification of an > AP configuration change. This patch introduces a handler to process > notification from the CHSC SEI command BY immediately kickING off an AP bus > scan. > > Signed-off-by: Tony Krowiak > Reviewed-by: Halil Pasic > --- > arch/s390/include/asm/ap.h | 12 ++++++++++++ > drivers/s390/cio/chsc.c | 12 ++++++++++++ > drivers/s390/cio/chsc.h | 1 + > drivers/s390/crypto/ap_bus.c | 12 ++++++++++++ > 4 files changed, 37 insertions(+) > > diff --git a/arch/s390/include/asm/ap.h b/arch/s390/include/asm/ap.h > index 1a6a7092d942..c778593d509f 100644 > --- a/arch/s390/include/asm/ap.h > +++ b/arch/s390/include/asm/ap.h > @@ -360,4 +360,16 @@ static inline struct ap_queue_status ap_dqap(ap_qid_t qid, > return reg1; > } > > +/* > + * Interface to tell the AP bus code that a configuration > + * change has happened. The bus code should at least do > + * an ap bus resource rescan. > + */ > +#if IS_ENABLED(CONFIG_ZCRYPT) > +void ap_bus_cfg_chg(void); > +#else > +#error "no CONFIG_ZCRYPT" > +static void ap_bus_cfg_chg(void){}; > +#endif > + > #endif /* _ASM_S390_AP_H_ */ > diff --git a/drivers/s390/cio/chsc.c b/drivers/s390/cio/chsc.c > index a0baee25134c..dccccc337078 100644 > --- a/drivers/s390/cio/chsc.c > +++ b/drivers/s390/cio/chsc.c > @@ -586,6 +586,15 @@ static void chsc_process_sei_scm_avail(struct chsc_sei_nt0_area *sei_area) > " failed (rc=%d).\n", ret); > } > > +static void chsc_process_sei_ap_cfg_chg(struct chsc_sei_nt0_area *sei_area) > +{ > + CIO_CRW_EVENT(3, "chsc: ap config changed\n"); > + if (sei_area->rs != 5) Why just return if the rs code is 5? The event content code concerns the AP configuration change. Should the source of the reporting of this change hold us from rescanning the available AP? Regards, Pierre > + return; > + > + ap_bus_cfg_chg(); > +} > + > static void chsc_process_sei_nt2(struct chsc_sei_nt2_area *sei_area) > { > switch (sei_area->cc) { > @@ -612,6 +621,9 @@ static void chsc_process_sei_nt0(struct chsc_sei_nt0_area *sei_area) > case 2: /* i/o resource accessibility */ > chsc_process_sei_res_acc(sei_area); > break; > + case 3: /* ap config changed */ > + chsc_process_sei_ap_cfg_chg(sei_area); > + break; > case 7: /* channel-path-availability information */ > chsc_process_sei_chp_avail(sei_area); > break; > diff --git a/drivers/s390/cio/chsc.h b/drivers/s390/cio/chsc.h > index 78aba8d94eec..5651066c46e3 100644 > --- a/drivers/s390/cio/chsc.h > +++ b/drivers/s390/cio/chsc.h > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > > #define CHSC_SDA_OC_MSS 0x2 > > diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c > index 48ea0004a56d..94f621783d6b 100644 > --- a/drivers/s390/crypto/ap_bus.c > +++ b/drivers/s390/crypto/ap_bus.c > @@ -35,6 +35,7 @@ > #include > #include > #include > +#include > > #include "ap_bus.h" > #include "ap_debug.h" > @@ -860,6 +861,17 @@ void ap_bus_force_rescan(void) > EXPORT_SYMBOL(ap_bus_force_rescan); > > /* > +* A config change has happened, Force an ap bus rescan. > +*/ > +void ap_bus_cfg_chg(void) > +{ > + AP_DBF(DBF_INFO, "%s config change, forcing bus rescan\n", __func__); > + > + ap_bus_force_rescan(); > +} > +EXPORT_SYMBOL(ap_bus_cfg_chg); > + > +/* > * hex2bitmap() - parse hex mask string and set bitmap. > * Valid strings are "0x012345678" with at least one valid hex number. > * Rest of the bitmap to the right is padded with 0. No spaces allowed > -- Pierre Morel Linux/KVM/QEMU in Böblingen - Germany