From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5476EC433EF for ; Wed, 4 May 2022 06:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345101AbiEDGzX (ORCPT ); Wed, 4 May 2022 02:55:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345108AbiEDGzT (ORCPT ); Wed, 4 May 2022 02:55:19 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2435220BC7 for ; Tue, 3 May 2022 23:51:44 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id m20so1042796ejj.10 for ; Tue, 03 May 2022 23:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IjvhY+zx5+cDpT9+ShvD2wIBZoNgfMhne2yk1qc9gqc=; b=eic7UFuqSIPHIgZ3jSbVJ+u7i6PpSPVY7e3+WBdyR38qmzv+FWuisIiMkWe2KpzS4R UnwvMe2voQGKKSuW8ZMI5JMcJuI3KmJ8A1rPmi9AAtCmgjaT0GP0zo5gAqixMJ8VDV0A ZWXOYJlyVr6o+MnZZ6r5g2M58A7uEP4AHQtRmLBwEd6U/CAxwh0Rj84HbMsS1dJMUkQe 6PXQTqyiXSz90DZ2JHQG9chh1I2MpCxYverENN9RufkpiACPTDTLdX76RjFtceWLbva6 Ewux8w8+l0bPoexCeRMh+kTwR6MujG9lElvDL0zkzoJvMFTp3ZomeFypBMZbY7WGWlPH fuBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IjvhY+zx5+cDpT9+ShvD2wIBZoNgfMhne2yk1qc9gqc=; b=CRVZyEZv0/sVMi9imKvk4g029v4taLIhhbChmsuBuqjVa0aM7A+cfLoO5QFBbJMmwE 9zz+O/VHQWWf2zGFmvfGPYf+QTzKTNP0RrymaiKzjnylUxe///qPv/G1AMPrRPNl9EJQ l/Nv2JUy4y2GANnCdhHOjyA7G/KtLNkrEw9EywB9ECJzoH/9R6WCi2G3wuJ7sSQ5Qpyv R4Of94rMgm8O7Af3gRFCyzZmG3AJ2gYHPidaHETNQySpc/oe1nT+sGIHH5ndEDGeSMDp 6nxhT73LVpOi50hJnglhzTwu5BMQxOwr8tEqzCRemShLGM3IHN6VzjlIKwuoVmrkL8Lg HWHw== X-Gm-Message-State: AOAM531Dw0F35ZOf3vUbtNsDw8lfj4i0A7TBoOi3+2FgNU4FCKz5jcgG S6lfATdR2mdlCEFe3DhsNsbkXQ== X-Google-Smtp-Source: ABdhPJwsbQjpa6yGQ2U7HY/Ae/uny1/EgLYf0Rw+8IrJbKAirCTUtkOfDH52DAkl4hVSuhbxoPgI8w== X-Received: by 2002:a17:906:a089:b0:6ef:e9e6:1368 with SMTP id q9-20020a170906a08900b006efe9e61368mr18809029ejy.626.1651647102720; Tue, 03 May 2022 23:51:42 -0700 (PDT) Received: from [192.168.0.208] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id el8-20020a170907284800b006f3ef214e0asm5370519ejc.112.2022.05.03.23.51.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 23:51:42 -0700 (PDT) Message-ID: <95aea078-3e85-79c3-79c0-430bd7c0fbae@linaro.org> Date: Wed, 4 May 2022 08:51:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: Aw: Re: Re: [RFC v1] dt-bindings: net: dsa: convert binding for mediatek switches Content-Language: en-US To: Frank Wunderlich Cc: Greg Ungerer , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Mauro Carvalho Chehab , Frank Wunderlich , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220502153238.85090-1-linux@fw-web.de> <10770ff5-c9b1-7364-4276-05fa0c393d3b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/2022 17:03, Frank Wunderlich wrote: > > have not posted this version as it was failing in dtbs_check, this was how i tried: > > https://github.com/frank-w/BPI-R2-4.14/blob/8f2033eb6fcae273580263c3f0b31f0d48821740/Documentation/devicetree/bindings/net/dsa/mediatek.yaml#L177 You have mixed up indentation of the second if (and missing -). (...) >>> >>> basicly this "ports"-property should be required too, right? >> >> Previous binding did not enforce it, I think, but it is reasonable to >> require ports. > > basicly it is required in dsa.yaml, so it will be redundant here > > https://elixir.bootlin.com/linux/v5.18-rc5/source/Documentation/devicetree/bindings/net/dsa/dsa.yaml#L55 > > this defines it as pattern "^(ethernet-)?ports$" and should be processed by dsa-core. so maybe changing it to same pattern instead of moving up as normal property? Just keep what is already used in existing DTS. >>> for 33 there seem no constant..all other references to pio node are with numbers too and there seem no binding >>> header defining the gpio pins (only functions in include/dt-bindings/pinctrl/mt7623-pinfunc.h) >> >> ok, then my comment > > you mean adding a comment to the example that GPIO-flags/constants should be used instead of magic numbers? I think something was cut from my reply. I wanted to say: "ok, then my comment can be skipped" But I think your check was not correct. I looked at bpi-r2 DTS (mt7623n) and pio controller uses GPIO flags. Best regards, Krzysztof