From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E6721A2C0B for ; Wed, 21 Jan 2026 17:43:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769017389; cv=none; b=gJ1AB5wGURto7ajs39/W860bVu3TyDZvMyvjHz/tlzt4e5bv6wifydg0qHjwdmEuZNZOXG2V7vcpw1csIIq9iMX60LuXggTlqjVkP+0RXCKZN2ZQh6u/dPgRzYPZlRhds7XyR3THZid70NpC9BnmmTOItQcbJqpXH+HTRWBrtU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769017389; c=relaxed/simple; bh=KCp/PHafNusEm2mfmFDT5kqNhBPSp5+sK77Cir7m40E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XMpB1Sd1/ghbZJjr13qNUL7xsg251RsgofMqcrTlJKhnShefrUj/TMwnRYRCtHlSN8S3eQgB9pBrJn+o5MIMLKA5/nmS/XnxSjhLF7egDdeYsstF1XdM1i7Tyc7boOxMdD3OrxK7O05CKaxcK6CvmpoMWOH7XjLIvKJ9oJn2X8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ZIFME/Fu; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ZIFME/Fu" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-45c78da5936so582326b6e.1 for ; Wed, 21 Jan 2026 09:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1769017386; x=1769622186; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=avyvpoQXDRAmKtq315EuJLUT0g5dGnGHq3S82pBKxXk=; b=ZIFME/FupEiel1u9wI3vCxL++b4ucSKbY9zLu39ahCfkV4mmw09WCQc82Oq+zb35IV FeE7Rofp7yvw1EGh9Wj8bAR8umcEMz32FrfxL0to82pAhpSkJQW5rEzOlMekCrHIwKX8 4KEaJ7QQkNapWY4mTrOJEW0WzZMdDDtOBDhQg5lFzTGqvMSjBoub9CxdkMIeDPBBGPh8 BZa/laCmru+zIHKYK9BHFaeK1sAN1NiSpHqbGQpx+AmwdC0O1vQIcCDIXRd88XB9FVd/ I+ru2bcGDyBTuBsLZBB7/ubn+nktaqZ8uyG9UIw6djtq8VSwMZWpNK6WXwpGoih9V34Y N66w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769017386; x=1769622186; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=avyvpoQXDRAmKtq315EuJLUT0g5dGnGHq3S82pBKxXk=; b=qLSxMFgQBKpxr4m2sCjl/0FWaQ5ZgH+SCfWY4U1tFn4KScttFIFetAcY2SSEDRO6HO xfeGV4TtClx7y+bOuGNue8MUbleOUhi/eL6dyVpPxyu4ka/IvnKVzZVlTRYCNcmeE14a Bm+RLnyTtBpKnNfwsiwTT/f4iRZFjazOKuilAjVBueHr2Ko6WfDE7noOe/R3u1RxFdYZ bl8TkQ+BBbpMUdbqPM0VujN9wLqnxOChJmR7EJenjIgX3vANQte36ugFCG5JrfW6fsdy WG9Ftep4kNOPwmiQigLz47yj8WiSrvK4tVzxy/LB2a7L6wlYZO7Uq8zBeiSzxWdUySks NtyA== X-Forwarded-Encrypted: i=1; AJvYcCXhk6yWlWaBsQaSxDdBrX5/Kkj8kCM4mqQIKUv/yFsCEkXLW0YvNKMvNCZ4w6CbmFUILsIdiqo2ItE1bMs=@vger.kernel.org X-Gm-Message-State: AOJu0YxGBNZy8aY65l4GM5MwRNE39N3s91mNjpvUtF3kTuhy5AoBGCiY uOGtGfzAXUZoauiAcnigLd/4LQEZ+M7lgANIB6PlbSUK6loQrDxU6mWlVo3Mvq4PoQw8Ne0wEHn yCfNc X-Gm-Gg: AZuq6aLRsRHgG5FwSdq21DJ01i4+sEKtZHE6VMZuf/rCDdWI9cARp2s1Aoz4qFFJiUZ ytMRM0mNx5gKlBhhcGGfV0r/Xv9FGzrATuReQtRJ5J8DTmQ0qBfE17IfidNBpYSVF1ciQ5fOFzh 3br9iOFbuv9YY34lFGQ6UAa8n+6sZXQFZ9pLyOd0QWhLv47sq7RfuBU/NZoKI+PMiIlkhXu4xAf 55FGP2tbSk9k0iFNBaZ9K2TBpxIOMit23sggB9Su+oT6wJUIe0xzU4YEJnYeZfm5wR+wuld5Oif +1U19jEUWNzlJBe3GZFjE8UR2UB3qnz0FBhPLiMyG7/ckn12FXrTFqWfPRwPhqAeiTSf3Ur9Cjm Vp86EmOqAKBx/DRKEF3sPS5igh0mjAjCedLbneklysbwzix8up0kD7MeFZwneSpW+Fpni5NMXN4 pL77WwoEE15BcgOhecd8ADICjFuBfJkTE2WnqJnhM5qb4xfTchlymC9uE= X-Received: by 2002:a05:6808:150f:b0:457:a9bc:dbf7 with SMTP id 5614622812f47-45ea3d89eb7mr105116b6e.20.1769017386123; Wed, 21 Jan 2026 09:43:06 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:9a8b:7a9:24fa:a0a? ([2600:8803:e7e4:500:9a8b:7a9:24fa:a0a]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45c9dbcdcd3sm8784078b6e.0.2026.01.21.09.43.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jan 2026 09:43:04 -0800 (PST) Message-ID: <95b13260-0564-445d-bff7-b3b54fa15005@baylibre.com> Date: Wed, 21 Jan 2026 11:43:03 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 0/9] iio: Expand IIO event interface for real-world unit handling To: =?UTF-8?Q?Nuno_S=C3=A1?= , Marcelo Schmitt , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jic23@kernel.org, Jonathan.Cameron@huawei.com, nuno.sa@analog.com, andy@kernel.org References: <4a04fa3f-c056-4443-a55a-e8622feb1c2a@baylibre.com> <2f9e7172885c5dd20be198f013283c6ec0513ef1.camel@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <2f9e7172885c5dd20be198f013283c6ec0513ef1.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/21/26 3:33 AM, Nuno Sá wrote: > On Sun, 2026-01-18 at 14:33 -0600, David Lechner wrote: >> On 1/18/26 12:18 PM, Marcelo Schmitt wrote: >>> This patch set adjusts and complements the IIO event ABI docs making them >>> coherent with the fact that not all threshold value attributes had a _raw/_input >>> indicator set in their names. In addition that, the latter patches on this >>> series update the IIO event infrastructure to actually enable drivers to provide >>> _input threshold value attributes. >> > > ... > >> >> Just throwing out an idea here without thinking about it too much... >> >> Instead of adding a new field/parameter for units, could we extend >> enum iio_event_info to add IIO_EV_INFO_VALUE_RAW and IIO_EV_INFO_VALUE_INPUT >> (and same for HYSTERESIS). Really, the units only make sense for these >> two info types anyway. >> > > Makes sense to me. Or we can just document that the old value is _INPUT? Or just make > it the same value in the enum. > > - Nuno Sá I don't think that works since IIO_EV_INFO_VALUE could be _RAW or _INPUT depending on the driver. And another point was that this should also control the _raw or _input in the attribute name, and we can't change the existing attribute names.