From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965415AbeBPLv6 (ORCPT ); Fri, 16 Feb 2018 06:51:58 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:38142 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964875AbeBPLv4 (ORCPT ); Fri, 16 Feb 2018 06:51:56 -0500 Subject: Re: [PATCH 7/8] arm64: dts: renesas: r8a77995-draak: Add HDMI Out through ADV7511 To: Laurent Pinchart Cc: linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kieran Bingham , Simon Horman , geert@glider.be, Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , open list References: <1518683903-10681-1-git-send-email-kbingham@kernel.org> <1518683903-10681-8-git-send-email-kbingham@kernel.org> <2517305.jdPBFiRQEk@avalon> From: Kieran Bingham Organization: Ideas on Board Message-ID: <95b1fa2c-8302-e264-2f00-eba5ac34bcd3@ideasonboard.com> Date: Fri, 16 Feb 2018 11:51:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <2517305.jdPBFiRQEk@avalon> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, On 15/02/18 14:16, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 15 February 2018 10:38:22 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide a device node for the ADV7511 as found on the Draak D3 platform. >> >> The ADV7511 is connected to the DU through a parallel mux chip, and is >> configurable in hardware whether it is connected to LVDS0 or LVDS1. >> >> Connect through to LVDS0 as a default implementation. > > You need to model the LVDS decoder in DT too. I know that no driver and no DT > bindings are available at the moment, and I'm aware that this patch enables > the HDMI output on the Draak board, but I don't think it's upstreamable as-is. Ok, understood. - I'll drop this patch for now until we can schedule time to dedicate to looking into this. I'm sure the archive's will hold on to this patch for us as a starting point :-) -- Regards Kieran > >> Signed-off-by: Kieran Bingham >> --- >> arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 56 +++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index >> 668e246dfc5d..df0c7773cb7d 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts >> @@ -27,6 +27,17 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> + hdmi-out { >> + compatible = "hdmi-connector"; >> + type = "a"; >> + >> + port { >> + hdmi_con_out: endpoint { >> + remote-endpoint = <&adv7511_out>; >> + }; >> + }; >> + }; >> + >> vga { >> compatible = "vga-connector"; >> >> @@ -124,6 +135,39 @@ >> reg = <0x50>; >> pagesize = <8>; >> }; >> + >> + hdmi@39 { >> + compatible = "adi,adv7511w"; >> + reg = <0x39>, <0x3f>, <0x38>, <0x3c>; >> + reg-names = "main", "edid", "packet", "cec"; >> + interrupt-parent = <&gpio1>; >> + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; >> + >> + adi,input-depth = <8>; >> + adi,input-colorspace = "rgb"; >> + adi,input-clock = "1x"; >> + adi,input-style = <1>; >> + adi,input-justification = "evenly"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + adv7511_in: endpoint { >> + remote-endpoint = <&lvds0_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + adv7511_out: endpoint { >> + remote-endpoint = <&hdmi_con_out>; >> + }; >> + }; >> + }; >> + }; >> }; >> >> &i2c1 { >> @@ -146,6 +190,18 @@ >> }; >> }; >> >> +&lvds0 { >> + status = "okay"; >> + >> + ports { >> + port@1 { >> + endpoint { >> + remote-endpoint = <&adv7511_in>; >> + }; >> + }; >> + }; >> +}; >> + >> &ehci0 { >> status = "okay"; >> }; > >