From: Crystal Wood <crwood@redhat.com>
To: Costa Shulyupin <costa.shul@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Tomas Glozar <tglozar@redhat.com>,
Wander Lairson Costa <wander@redhat.com>,
Ivan Pravdin <ipravdin.official@gmail.com>,
John Kacur <jkacur@redhat.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v2 0/4] tools/rtla: Consolidate nr_cpus usage
Date: Tue, 10 Feb 2026 15:07:00 -0600 [thread overview]
Message-ID: <95b45cb5db8d3f3b8202eff5c754e4c0c95769de.camel@redhat.com> (raw)
In-Reply-To: <20260209092436.2899888-1-costa.shul@redhat.com>
On Mon, 2026-02-09 at 11:24 +0200, Costa Shulyupin wrote:
> sysconf(_SC_NPROCESSORS_CONF) (via get_nprocs_conf) reflects
> cpu_possible_mask, which is fixed at boot time, so querying it
> repeatedly is unnecessary.
>
> Replace multiple calls to sysconf(_SC_NPROCESSORS_CONF) with a single
> global nr_cpus variable initialized once at startup.
>
> v2:
> - Add `#pragma once` in timerlat_u.h to avoid redefinition errors with
> pre-C23 compilers.
>
> Costa Shulyupin (4):
> tools/rtla: Consolidate nr_cpus usage across all tools
> tools/rtla: Remove unneeded nr_cpus arguments
> tools/rtla: Remove unneeded nr_cpus members
> tools/rtla: Remove unneeded nr_cpus from for_each_monitored_cpu
>
> tools/tracing/rtla/src/common.c | 7 ++-
> tools/tracing/rtla/src/common.h | 4 +-
> tools/tracing/rtla/src/osnoise_hist.c | 26 +++++------
> tools/tracing/rtla/src/osnoise_top.c | 16 ++-----
> tools/tracing/rtla/src/timerlat.c | 9 ++--
> tools/tracing/rtla/src/timerlat_aa.c | 11 ++---
> tools/tracing/rtla/src/timerlat_bpf.c | 5 +--
> tools/tracing/rtla/src/timerlat_bpf.h | 6 +--
> tools/tracing/rtla/src/timerlat_hist.c | 62 +++++++++++---------------
> tools/tracing/rtla/src/timerlat_top.c | 47 +++++++------------
> tools/tracing/rtla/src/timerlat_u.c | 9 ++--
> tools/tracing/rtla/src/timerlat_u.h | 1 +
> tools/tracing/rtla/src/utils.c | 10 +----
> 13 files changed, 80 insertions(+), 133 deletions(-)
Reviewed-by: Crystal Wood <crwood@redhat.com>
-Crystal
prev parent reply other threads:[~2026-02-10 21:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 9:24 Costa Shulyupin
2026-02-09 9:24 ` [PATCH v2 1/4] tools/rtla: Consolidate nr_cpus usage across all tools Costa Shulyupin
2026-02-11 11:03 ` Wander Lairson Costa
2026-02-11 11:15 ` Tomas Glozar
2026-02-09 9:24 ` [PATCH v2 2/4] tools/rtla: Remove unneeded nr_cpus arguments Costa Shulyupin
2026-02-11 11:03 ` Wander Lairson Costa
2026-02-09 9:24 ` [PATCH v2 3/4] tools/rtla: Remove unneeded nr_cpus members Costa Shulyupin
2026-02-09 9:24 ` [PATCH v2 4/4] tools/rtla: Remove unneeded nr_cpus from for_each_monitored_cpu Costa Shulyupin
2026-02-10 21:07 ` Crystal Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95b45cb5db8d3f3b8202eff5c754e4c0c95769de.camel@redhat.com \
--to=crwood@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=costa.shul@redhat.com \
--cc=ipravdin.official@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglozar@redhat.com \
--cc=wander@redhat.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®