From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54EA7C7618F for ; Mon, 22 Jul 2019 17:11:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 342802190F for ; Mon, 22 Jul 2019 17:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730633AbfGVRLe (ORCPT ); Mon, 22 Jul 2019 13:11:34 -0400 Received: from smtprelay0124.hostedemail.com ([216.40.44.124]:42271 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727880AbfGVRLd (ORCPT ); Mon, 22 Jul 2019 13:11:33 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 3F99C182CED2A; Mon, 22 Jul 2019 17:11:32 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: skirt20_47526e5f3694d X-Filterd-Recvd-Size: 4087 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Mon, 22 Jul 2019 17:11:30 +0000 (UTC) Message-ID: <95b640fd89baacb0817126ddfb5a762d522eebea.camel@perches.com> Subject: Re: [PATCH 1/2] HID: core: Add hid printk_once macros From: Joe Perches To: stillcompiling@gmail.com, Jiri Kosina , Benjamin Tissoires , "open list:HID CORE LAYER" , open list Date: Mon, 22 Jul 2019 10:11:28 -0700 In-Reply-To: <20190722163642.10417-1-stillcompiling@gmail.com> References: <20190722163642.10417-1-stillcompiling@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-07-22 at 10:36 -0600, stillcompiling@gmail.com wrote: > From: Joshua Clayton > > Make available printk_once variants to hid_warn() etc > > Signed-off-by: Joshua Clayton This seems OK, but I suggest a slightly different style: > diff --git a/include/linux/hid.h b/include/linux/hid.h [] > @@ -1179,4 +1179,23 @@ do { \ > #define hid_dbg(hid, fmt, arg...) \ > dev_dbg(&(hid)->dev, fmt, ##arg) > > +#define hid_level_once(level, hid, fmt, arg...) \ > + dev_level_once(level, &(hid)->dev, fmt, ##arg) This one is probably not useful in actual code. > +#define hid_emerg_once(hid, fmt, arg...) \ > + dev_emerg_once(&(hid)->dev, fmt, ##arg) Even though I introduced those macros originally, it's now a more common style to use: #define hid_emerg_once(hid, fmt, ...) \ dev_emerg_once(&(hid)->dev, fmt, ##__VA_ARGS__) etc... And trivially: hid_printk, hid_emerg, hid_crit, and hid_alert aren't used at all and could all be removed. I'm not sure there is a use case for any of them. Perhaps: --- include/linux/hid.h | 39 +++++++++++++++++++++------------------ 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/include/linux/hid.h b/include/linux/hid.h index d770ab1a0479..5d2c4b63954f 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -1160,23 +1160,26 @@ do { \ printk(KERN_DEBUG "%s: " format, __FILE__, ##arg); \ } while (0) -#define hid_printk(level, hid, fmt, arg...) \ - dev_printk(level, &(hid)->dev, fmt, ##arg) -#define hid_emerg(hid, fmt, arg...) \ - dev_emerg(&(hid)->dev, fmt, ##arg) -#define hid_crit(hid, fmt, arg...) \ - dev_crit(&(hid)->dev, fmt, ##arg) -#define hid_alert(hid, fmt, arg...) \ - dev_alert(&(hid)->dev, fmt, ##arg) -#define hid_err(hid, fmt, arg...) \ - dev_err(&(hid)->dev, fmt, ##arg) -#define hid_notice(hid, fmt, arg...) \ - dev_notice(&(hid)->dev, fmt, ##arg) -#define hid_warn(hid, fmt, arg...) \ - dev_warn(&(hid)->dev, fmt, ##arg) -#define hid_info(hid, fmt, arg...) \ - dev_info(&(hid)->dev, fmt, ##arg) -#define hid_dbg(hid, fmt, arg...) \ - dev_dbg(&(hid)->dev, fmt, ##arg) +#define hid_err(hid, fmt, ...) \ + dev_err(&(hid)->dev, fmt, ##__VA_ARGS__) +#define hid_notice(hid, fmt, ...) \ + dev_notice(&(hid)->dev, fmt, ##__VA_ARGS__) +#define hid_warn(hid, fmt, ...) \ + dev_warn(&(hid)->dev, fmt, ##__VA_ARGS__) +#define hid_info(hid, fmt, ...) \ + dev_info(&(hid)->dev, fmt, ##__VA_ARGS__) +#define hid_dbg(hid, fmt, ...) \ + dev_dbg(&(hid)->dev, fmt, ##__VA_ARGS__) + +#define hid_err_once(hid, fmt, ...) \ + dev_err_once(&(hid)->dev, fmt, ##__VA_ARGS__) +#define hid_notice_once(hid, fmt, ...) \ + dev_notice_once(&(hid)->dev, fmt, ##__VA_ARGS__) +#define hid_warn_once(hid, fmt, ...) \ + dev_warn_once(&(hid)->dev, fmt, ##__VA_ARGS__) +#define hid_info_once(hid, fmt, ...) \ + dev_info_once(&(hid)->dev, fmt, ##__VA_ARGS__) +#define hid_dbg_once(hid, fmt, ...) \ + dev_dbg_once(&(hid)->dev, fmt, ##__VA_ARGS__) #endif