From: Auger Eric <eric.auger@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>, kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] kvm-vfio: Decouple only when we match a group
Date: Wed, 14 Jun 2017 14:31:44 +0200 [thread overview]
Message-ID: <95b74824-5ae6-ab00-7a34-96f269114f7a@redhat.com> (raw)
In-Reply-To: <20170609215944.31986.32841.stgit@gimli.home>
Hi Alex,
On 09/06/2017 23:59, Alex Williamson wrote:
> Unset-KVM and decrement-assignment only when we find the group in our
> list. Otherwise we can get out of sync if the user triggers this for
> groups that aren't currently on our list.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> virt/kvm/vfio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
This patch and 3/7 do not apply on 4.12-rc5 as there are small conflicts
with
commit 121f80ba68f1a5779a36d7b3247206e60e0a7418
KVM: PPC: VFIO: Add in-kernel acceleration for VFIO
Besides
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
>
> diff --git a/virt/kvm/vfio.c b/virt/kvm/vfio.c
> index d32f239eb471..db9036ef8c73 100644
> --- a/virt/kvm/vfio.c
> +++ b/virt/kvm/vfio.c
> @@ -201,18 +201,16 @@ static int kvm_vfio_set_group(struct kvm_device *dev, long attr, u64 arg)
> continue;
>
> list_del(&kvg->node);
> + kvm_arch_end_assignment(dev->kvm);
> + kvm_vfio_group_set_kvm(kvg->vfio_group, NULL);
> kvm_vfio_group_put_external_user(kvg->vfio_group);
> kfree(kvg);
> ret = 0;
> break;
> }
>
> - kvm_arch_end_assignment(dev->kvm);
> -
> mutex_unlock(&kv->lock);
>
> - kvm_vfio_group_set_kvm(vfio_group, NULL);
> -
> kvm_vfio_group_put_external_user(vfio_group);
>
> kvm_vfio_update_coherency(dev);
>
next prev parent reply other threads:[~2017-06-14 12:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 21:59 [PATCH 0/7] vfio: Fix release ordering races and use driver_override Alex Williamson
2017-06-09 21:59 ` [PATCH 1/7] vfio: Fix group release deadlock Alex Williamson
2017-06-14 12:31 ` Auger Eric
2017-06-09 21:59 ` [PATCH 2/7] kvm-vfio: Decouple only when we match a group Alex Williamson
2017-06-12 16:28 ` Paolo Bonzini
2017-06-14 12:31 ` Auger Eric [this message]
2017-06-09 21:59 ` [PATCH 3/7] vfio: New external user group/file match Alex Williamson
2017-06-12 16:27 ` Paolo Bonzini
2017-06-14 12:42 ` Auger Eric
2017-06-09 21:59 ` [PATCH 4/7] iommu: Add driver-not-bound notification Alex Williamson
2017-06-09 22:21 ` Joerg Roedel
2017-06-09 22:43 ` Alex Williamson
2017-06-10 21:39 ` Joerg Roedel
2017-06-14 12:52 ` Auger Eric
2017-06-09 22:00 ` [PATCH 5/7] vfio: Create interface for vfio bus drivers to register Alex Williamson
2017-06-14 13:17 ` Auger Eric
2017-06-09 22:00 ` [PATCH 6/7] vfio: Register pci, platform, amba, and mdev bus drivers Alex Williamson
2017-06-14 13:17 ` Auger Eric
2017-06-09 22:00 ` [PATCH 7/7] vfio: Use driver_override to avert binding to compromising drivers Alex Williamson
2017-06-19 14:03 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95b74824-5ae6-ab00-7a34-96f269114f7a@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®