From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A43D2FB085 for ; Wed, 28 Jan 2026 16:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769617349; cv=none; b=K1v7fdsia0b4gedodE94CdTDL3TR1y7c+vX5o7RtYiLA5jwTD7J3tNQmwCCbTX+6LUrKdUY5gdnwmLDkrV+Zs64x/HWKXV22eFRzo/kWHfVKah4pmftpgIaIKrHq8Z+Ild769CoTBqrbJ1GqS5sy6UWGPjhNpXBBj9kDtqln4GM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769617349; c=relaxed/simple; bh=BFmYWAlpvFX/+2manpRQERqUJt3ncwaRQx6a7NzM0fs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WMpEjAMT/yhxaGLfhgw1CUnDdcH9NA2YlzmJG5ahf6jCTe+Y64zLrFrl13Pnv75lK5mmgHlId3vI8yTkVg190btUye+db+i7PR9InAMvBmSdd6+nJ3y7GLB/NfmO6XlafPkqYqX3bRROJZ0BfwUa+nAO8dh8H347UBsrbab3v28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hZqSl8XU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FPMlbX9j; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hZqSl8XU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FPMlbX9j" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60SFerE44008468 for ; Wed, 28 Jan 2026 16:22:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cm4xp5YKm3EkGWrIxhnF9M2qAJpvBH5Bb3MxePIzadc=; b=hZqSl8XUYtd3AQLc YU2K7rkc7G7GFzcXuBhta+OFdFVYBNq+/eFjkoXlICR6KTDHf4TfD+/1R1w17ZC6 bXQge7sXQxcXjOKSRfK4Wz/0jENVluooQUuzcVRNnohqAORvVPzmeOF60HCMlAHs bwFEOQ1EjaFNXoXBmUrS6GYaZPuY8sumMRDHcEmhhzNkYPY4CIQNiYQsVA9lOgOj oV2Qf1sLVshf9AXkuqMAew4JU4oSGGw0emAKckNr6hv1/KrxR6tFo9Pt0PMXeuhK J3M37nZrbBhGFKa1HL4w4JC6VAGJz4352Z+i+lroXCwoMsqdLuC+WwnBy6ID8DKi PQ7h1Q== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4by1jx4bng-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 16:22:27 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34ab8693a2cso4438889a91.0 for ; Wed, 28 Jan 2026 08:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769617347; x=1770222147; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cm4xp5YKm3EkGWrIxhnF9M2qAJpvBH5Bb3MxePIzadc=; b=FPMlbX9jI/clA/DaeEuOBE1swu4GwqnxQDf3rq44rY6pRGqIj0JXn5MOV40uBFTcvh YiBqHeNlyZad5A7UDgxAzCkmpjvSSpRpnbt+xlctc5+HF0YhatKcYvngGxKjvEOrhyTr XlE6iPsRgSkBi6W2NQbJu2kusbZ7AzKIE/i5B7kWpRf3xal7Nkh54VbZqxt1OUbFuWoc MnR1BJTlHhaUq6x4XCfyf1fbZDycFUsuWS7TBtgnF5YTTCKBl1IlRNa1zjAdUtuZA4I6 /sviP8z+2kizJdgL/rqckA0qOHY676pc+l97f2Ofg16ost1jJcF6gi5sbCCUW78/tK5F hxbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769617347; x=1770222147; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cm4xp5YKm3EkGWrIxhnF9M2qAJpvBH5Bb3MxePIzadc=; b=DiLmJL+CzVt+/B8YpY84nDEzIw6whj46UPMYeGaPu21f9KJm1bHGVOLVOMwRgHhdF2 bhBmroahf2tlnsB221tDoKMdXXiSbI60IwJeTSjTT0Vfbut0tuJQwITBIckN0GQVbPU+ 8KJ5vSWwJOuFGRZ2TUFXzC+hG5uBNyUUiwkPiJCWowstgIWli10QB+ZCVfh6UVXVM3Lb 9aLUorP8Bai7g4C9OYMRXaqvoaQbNEiJmy28ASBnSbmjhG2JWDggLZpa7AbIPgXE9USc WYuy8vHqFqCQnjfvf1WiUZ7uWjDAJ6nnbnMPhl5YLGnYnjmOif5WqfCmaVluNP/anS0H 6/iQ== X-Forwarded-Encrypted: i=1; AJvYcCVQ8Rmtl+KUampU1BhF34WsnBuvYPKCSZGTEJaUYBAkyK3vrq0k6BOUy9sJgwWHlNN8dYKIF/XKcF2BHI8=@vger.kernel.org X-Gm-Message-State: AOJu0YwU1FuQ+HknXOnJnqIYE/xMePqQVR2jMLR+pACVndW1ZOQ0im/I cBsbSYkWD7O/X/d7ppnUAdEXLUY6wqHfvBmuu37+qDHpEYxbQ2ulMlK3oTDCTygH4b28CrWHqDG YaesaC6O79NOXfID4LvxfWqWDUOzvoyTeUuzuRal2c5AbWeQiszicg8k2grQPZZHScOk= X-Gm-Gg: AZuq6aJNm9rfq8xKYPhW96472fz6b6TtwhsyhG5uu0K4rd368PCWU++nc5N6C8EzOdm lhUZ555/YaMDN3dp1PRIkoEceym9Xj+6mkqkYNMjl9PZQ2xaVOSNZmbI9GOxMTMGiyA8BlewRJq qBII/NuLBPy5u/WhUANd09RLj1gH6EwyjEqQ4WdrWOJ7Fkk3n0AnSBVnX4QJwch/5kImQFaM10n 7O46JSIkP0zQmmXJ2Yjm5v9OTIIZfWUi7JHTEOE6ZyPiJK78sSj70mujWPDl07B07sOsadJ1OW0 ImqJt8XzSBHhQvtELgRPl/HK8QQ1xL61sxaPr+ejrK0HM5Mdo3FTsgVbGcyDwhaCtTvYGr8hLKy shCtipuVJPqQWpY7kXx08CuNbmk8OHp1gSug2/wNSFQ== X-Received: by 2002:a17:90b:58ce:b0:341:8c8b:b8e6 with SMTP id 98e67ed59e1d1-353fecf4952mr5634288a91.16.1769617347129; Wed, 28 Jan 2026 08:22:27 -0800 (PST) X-Received: by 2002:a17:90b:58ce:b0:341:8c8b:b8e6 with SMTP id 98e67ed59e1d1-353fecf4952mr5634245a91.16.1769617346339; Wed, 28 Jan 2026 08:22:26 -0800 (PST) Received: from [192.168.1.2] ([49.204.110.251]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3540f2f0283sm3487846a91.5.2026.01.28.08.22.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 08:22:25 -0800 (PST) Message-ID: <95bdb386-1635-4f8b-84dd-b5123d271b7d@oss.qualcomm.com> Date: Wed, 28 Jan 2026 21:52:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] spi: geni-qcom: Fix abort sequence execution for serial engine errors To: Konrad Dybcio , Mark Brown , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260122151008.2149252-1-praveen.talari@oss.qualcomm.com> <20260122151008.2149252-3-praveen.talari@oss.qualcomm.com> <9d9d4d3d-42bf-4f4a-99d3-19df73f89c30@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <9d9d4d3d-42bf-4f4a-99d3-19df73f89c30@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: GG8hPzqoTbgPgtGuXjFmlD8YKXyT7rQZ X-Authority-Analysis: v=2.4 cv=duPWylg4 c=1 sm=1 tr=0 ts=697a37c3 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=hmzEZbfuJy6/QR5cQt8XuQ==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Lg4E7-zU6_iSQFpiOd0A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDEzNCBTYWx0ZWRfX68h6JIrF3FQX ojR1ckqtFDgG9VbxNE1AaTiyZYXVJNpVqFf/T2/bhN+FPdGZJWAAosjNxmpgrsO5AW1A5jX47jx Y+gAdHVXeL/pCDEtZDHLZE8jNlEqpMnPcRuP/ORNTnMFeiTiNdhgc/XYCJQ34kuUEkxmVydKVWk r+7K25pwePHGf5pZUCSNaLUZhyO7zrRQzs+UddIxaJmKvqwXbeLHdlWfiRjrrn3UgJs4E/85LqA RMrv2QcjHdo4sk2O3bC0Y5Cdbo483/UanN2YIFCVXDUjHD7yp0EiTjdjVGNmrcZ/GRNj+q2aid9 Dwqjkc9ULGRqlHORTp03qqRM1bQQQxLCWx6E1iZ77HlQqdA8J9n1U/jQ+T+HcWmo1GOkmR4wpFW 6cpOndN+nV2u2dcQAspM3Ke3iNN8t47WqNznvgsBDIaZSHIGYt604DEUkvw/E6GISK31YOwC4fk jft0hE7omqgpwih1+bw== X-Proofpoint-GUID: GG8hPzqoTbgPgtGuXjFmlD8YKXyT7rQZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_03,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280134 HI Konrad, Thank you for review. On 1/27/2026 6:47 PM, Konrad Dybcio wrote: > On 1/22/26 4:10 PM, Praveen Talari wrote: >> The driver currently skips the abort sequence for target mode when serial >> engine errors occur. This leads to improper error recovery as the serial >> engine may remain in an undefined state without proper cleanup, potentially >> causing subsequent operations to fail or behave unpredictably. >> >> Fix this by ensuring the abort sequence and DMA reset always execute during >> error recovery, as both are required for proper serial engine error >> handling. >> >> Signed-off-by: Praveen Talari >> --- >> drivers/spi/spi-geni-qcom.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c >> index f5d05025b196..e5320e2fb834 100644 >> --- a/drivers/spi/spi-geni-qcom.c >> +++ b/drivers/spi/spi-geni-qcom.c >> @@ -167,7 +167,7 @@ static void handle_se_timeout(struct spi_controller *spi, >> * doesn`t support CMD Cancel sequnece >> */ >> spin_unlock_irq(&mas->lock); >> - goto reset_if_dma; >> + goto abort; >> } >> >> reinit_completion(&mas->cancel_done); >> @@ -178,6 +178,7 @@ static void handle_se_timeout(struct spi_controller *spi, >> if (time_left) >> goto reset_if_dma; >> >> +abort: >> spin_lock_irq(&mas->lock); > > Now that the jump is just 5 LoC, you can dispose of the goto and change it > to an if-statement Is the modification below good? diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index f5d05025b196..4feaf24d47ea 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -167,16 +167,15 @@ static void handle_se_timeout(struct spi_controller *spi, * doesn`t support CMD Cancel sequnece */ spin_unlock_irq(&mas->lock); - goto reset_if_dma; - } - - reinit_completion(&mas->cancel_done); - geni_se_cancel_m_cmd(se); - spin_unlock_irq(&mas->lock); + } else { + reinit_completion(&mas->cancel_done); + geni_se_cancel_m_cmd(se); + spin_unlock_irq(&mas->lock); - time_left = wait_for_completion_timeout(&mas->cancel_done, HZ); - if (time_left) - goto reset_if_dma; + time_left = wait_for_completion_timeout(&mas->cancel_done, HZ); + if (time_left) + goto reset_if_dma; + } spin_lock_irq(&mas->lock); reinit_completion(&mas->abort_done); Thanks, Praveen Talari > > Konrad