From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 455AAEDE983 for ; Thu, 14 Sep 2023 06:23:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235330AbjINGXF (ORCPT ); Thu, 14 Sep 2023 02:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234896AbjINGXD (ORCPT ); Thu, 14 Sep 2023 02:23:03 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C35E0 for ; Wed, 13 Sep 2023 23:22:59 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9a64619d8fbso79168966b.0 for ; Wed, 13 Sep 2023 23:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694672578; x=1695277378; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7IY6Klcup6lhl/U3i4EA23kuZdk+E7DI+uCdmyLnRtE=; b=jqYrseqPyH21d5ws8e1CcSoeZVI45XIXn1hiUuNUPmrvJ+VQIf6ofDdaNN5dKDVS+M 2IwsxHi0e4y5lfzhAdGiiGBAUmuwhFrEgrwjoW1hfMRQYIMBLg112dYI3mfq9Su0ei4D 9QDQZLW8dWiemwLj+x0Ag/VaSHk8AUEZwuNbuOr2YNxFDhkHEKG+qPSHldMaEAB7e3SA ruWROaSiycEiaOBgeaPwD0S6EsdY1AfdkcLG4d/4L2WCdtlRyPpYHtfv1Ay0z5OZEcc2 2hjNl4r7/b9lbdmRtqSv8BOyoAHSU6LKEG2hemcGunZl0DQhUeMoIjIDIzHPagWOSnDV iUgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694672578; x=1695277378; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7IY6Klcup6lhl/U3i4EA23kuZdk+E7DI+uCdmyLnRtE=; b=MUIBc5HVnYnLjurldea8bOvr2iqOxaKPY0aPiQiQul6mCfYoUwA6njpj+p22l2vKbV 8VjSP96rgLMoBnYo577ovUhRWxbxkgio1ibBwYeF7dobB0/e+Dg5UPsxg2uIwo5O9oUr 3a+pjrZ01kfsEZsogkcrPezl1pthioxxxR40swAekvGB4VkMj1+Y3zG8k6CQ1tV/30qz VTw4oKyhT4vuoXxP8jpxV54DsfvaqbUBv1U55iXazAE+zeORRk+JcYl7I+9X/KduYjlI 7rPxRWFutU4zBhIA7c/znJ8cMsLSMQvQfHj5nrnlD2w0gloLL/5FLPt21GZ5jHEuHz+6 ysWQ== X-Gm-Message-State: AOJu0Ywy3CapVK2OnmRsHpotjwG7L+O0BYUWUp4R+8PFxcyDKKQP65n+ UaPsqtVOwkSID74G7qelBGYKyQ== X-Google-Smtp-Source: AGHT+IGKIIEs8IOe0HhBpjx4EsRiO8dHrpPLhJSDgfHSmzRmaGEaG5r/fh7DRpWKCw5ScNBiYpvtxQ== X-Received: by 2002:a17:907:7811:b0:9a9:e4f8:3501 with SMTP id la17-20020a170907781100b009a9e4f83501mr3510882ejc.43.1694672577897; Wed, 13 Sep 2023 23:22:57 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id kt27-20020a170906aadb00b0099d959f9536sm527418ejb.12.2023.09.13.23.22.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Sep 2023 23:22:57 -0700 (PDT) Message-ID: <95bf5c64-3fb3-6ee0-4290-3696d4b72883@linaro.org> Date: Thu, 14 Sep 2023 08:22:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 1/2] dt-bindings: input: touchscreen: document Himax HX852x(ES) Content-Language: en-US To: Stephan Gerhold , Dmitry Torokhov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff LaBundy , Jonathan Albrieux References: <20230913-hx852x-v1-0-9c1ebff536eb@gerhold.net> <20230913-hx852x-v1-1-9c1ebff536eb@gerhold.net> From: Krzysztof Kozlowski In-Reply-To: <20230913-hx852x-v1-1-9c1ebff536eb@gerhold.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/09/2023 15:25, Stephan Gerhold wrote: > Himax HX852x(ES) is a touch panel controller with optional support > for capacitive touch keys. > > Unfortunately, the model naming is quite unclear and confusing. There > seems to be a distinction between models (e.g. HX8526) and the "series" > suffix (e.g. -A, -B, -C, -D, -E, -ES). But this doesn't seem to be > applied very consistently because e.g. HX8527-E(44) actually seems to > belong to the -ES series. ... > + touchscreen-inverted-x: true > + touchscreen-inverted-y: true > + touchscreen-size-x: true > + touchscreen-size-y: true > + touchscreen-swapped-x-y: true > + > + linux,keycodes: > + minItems: 1 > + maxItems: 4 > + > +additionalProperties: false > + > +required: If there is going to be resend, required: goes before additionalProperties:. In any case: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof