From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F21173BF679 for ; Fri, 29 May 2026 09:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780046693; cv=none; b=ZNUbuYZCvIBUDaeOJ8mR1JjlLge4Dr6H9FHvnBKOLDYFCidETvKqZImZl1GvvQllZNxzcJiTZ6vSjDXhty9QCUfIxAHpxhsrYJjC+Z5uslnYk54xuRvYXuslq6vS3EXS5KTRVWRdG4iEFVpstGVpwq8lMRHxg8N+5wacEsemMOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780046693; c=relaxed/simple; bh=o4sUJ27v7ooORme6fNzh5GE20SY6LLW/dSjlsVpGr/I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BVO026Qft+Mxoqzl1qF9la2kOop90HT1q9yT4psAbnSzaQvBSwNWHDmPw7Xy3ip3YYFOihY+xFR9Zo+pnFmYoJFHMAUzOBGd865JAKxO8EX45fo5I1u+CsBHdJIFmaXOEqQZx+jxLWNRxVREQC32RwU/rxXRnVjufxEuLFgm5Iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MMlQkBu4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z9gw2Y04; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MMlQkBu4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z9gw2Y04" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64T4TD214193333 for ; Fri, 29 May 2026 09:24:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XVKptdVMaslRjADnb9LxrFMeUYcIm3eFjbr7EQiByDY=; b=MMlQkBu47y7y8i4d P0U0AgCGNXa5btwDSf7xcZbwiCvFVzGSiU33BXJ3sa1xYJ+nXXdR4hA2EMNaWnbO NZISikq+ARksdmF/YGs1FwGbRygVn8fr/mCBvrZeaXuG3GIRJmD9yMy8qbNf220q KIlbhm+C5eGeAiTG56Ql0kuu2/cS9yOS8B6OYS/DAYYGd8UHCk+xpWsmnbrw+rA/ fI76xP1kMAqW2iWud1NE1JbuudQ+oWKTGQhlxiIQEOC6lFI1u5+UAayoKOdxyRZc 45x09hgMC45GqbFcG/0Gu2cpnqANuWmDG4tFeoQuuu0pxW8F+tiDFGPbckZ+bya+ atMFEw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ef3te15ug-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 29 May 2026 09:24:49 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-36642d2f4deso26054272a91.3 for ; Fri, 29 May 2026 02:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780046688; x=1780651488; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XVKptdVMaslRjADnb9LxrFMeUYcIm3eFjbr7EQiByDY=; b=Z9gw2Y04Ot+D8E46bX15NeHZK58vvR7YqUuH10Cbr+UdK791kClQE1/zHUB1CLy27T pGm19VWplMrlN/dCnOIdXKaQWGOZY3KOlPTCpo+MejVHmmcoW8tJ3W0v6Djg8dQr2MIL FAlJfqRGtGAHkcfSeJsmgmIKUcFmKMgldbTx+Di6hs73cJLB5MBbtYYGRaJu637S53TY rcuj3vHI/ixEW/MAzTiKZVuSu3FrJ95RVmGWYugsESiv+X7+zkzH7nNAMErGMRNaefez HjymWt33qSv1ddyHoO5fRhVxiwRe1GqPUyMHiL1+9V8UxeXeeyoOBsExIVYFrlVKjCDy hXqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780046688; x=1780651488; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XVKptdVMaslRjADnb9LxrFMeUYcIm3eFjbr7EQiByDY=; b=BdwMdLOjZ3Ph0lwgHYdhe7XwLw+UH+VgwBzBSf1s1aVddfT0XVID/684CGa8uhToQc YCTnWfZf3gGmNHDABiUIZinGuIzdnCV6xrak9/FTijXV+SQJsaSEda27JX5M1y9dBqC6 JlljGrsY109i0Rjb4o01q+O67WxyKzOwloQcRlQGkgHUWfctABXRTgJbS2fd2Rv28Ovn Us/OoQnvvLESjGfIxYaFJASN1NjRjENNLZGmxgPIKAtCGqfxS1T7MaGH4Gw2Mrcyo9uk CCGEJtw+Mkslldee8HLhNRALvgQb5kn767KhwCjxuJQ0ZnbU5MEWI8WKXQUA54iWG4tt Cx3A== X-Forwarded-Encrypted: i=1; AFNElJ8eyTqA9LvBCFwDBi8LohZLnpAsU7n3zy6rcz3GEBtFJOESlM9SG0gkkE75yv5QBK95MeN9FsHRu+heT5Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyDB4vmNo6Ulvj4nLqcxTw9kNGsOF1k6JPHhB9UL+BbT4cwhr45 DMGgyJjk6YhoBCo+S04rFa/S6HZC8A35EyclEp4lNLEvLBFvssRTXG+/B6Slvf5joxrBzXCMDvA qENrtkuQi9kQQ+SuA6e5wuCPb+rGP5MvK6awPxK9dys0U9flq5x4jYJ653pH/Fui/c5U= X-Gm-Gg: Acq92OFJvoaPJ7do+a4B69iOgZvwdebL7KJ8a0e5OF9qI4K6hnJVlWoEYvtRrDhyz/t UyVsSRBVJgX243CH+UKOCoWSezjt37IK2YcVz/4TcHHpf+BfK6rI3f/RQoHwJiCNmeoFJI507Zt 3hw64iEjG6isH0gq6RgvH+4fbrA/1/olaisg7/IoBxMFnM+UpketTaF5wL6UKv+fQ2mNXsclL9w HPQJlE4Q0zDUCMSUAnQKue+ntuBB2GtAdmzBS8HvDW10rnLRcK2Vj+TiQKli0UMgFBTH/jNfh7U 4+nRHAPg44Y0Tz49gdSTv9/Nx2or0q/wwPZk8i9im5A9mEGBt3a4b3OVzV68vtFROafjKStmJds qb/xxF71spLlqfLq3a1im9hM8QHHiw+Oc0zQGy7bO+fQEOwAUu+DhczbdGoDOtQ== X-Received: by 2002:a17:90b:2f07:b0:36a:5d1f:7ac with SMTP id 98e67ed59e1d1-36bbcac99femr2572471a91.3.1780046688470; Fri, 29 May 2026 02:24:48 -0700 (PDT) X-Received: by 2002:a17:90b:2f07:b0:36a:5d1f:7ac with SMTP id 98e67ed59e1d1-36bbcac99femr2572446a91.3.1780046687963; Fri, 29 May 2026 02:24:47 -0700 (PDT) Received: from [192.168.1.2] ([117.192.250.176]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36bc0ae339csm1468021a91.12.2026.05.29.02.24.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2026 02:24:47 -0700 (PDT) Message-ID: <95c74b63-2155-4118-9c99-da483ade3203@oss.qualcomm.com> Date: Fri, 29 May 2026 14:54:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] clk: qcom: Add support for Qualcomm GPU Clock Controller on Shikra To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Loic Poulain , Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260528-shikra-dispcc-gpucc-v2-0-953f246a0fbb@oss.qualcomm.com> <20260528-shikra-dispcc-gpucc-v2-5-953f246a0fbb@oss.qualcomm.com> Content-Language: en-US From: Imran Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: itO-l_-yUrJRJ4lmU2IdogLN8v2u2dAi X-Proofpoint-GUID: itO-l_-yUrJRJ4lmU2IdogLN8v2u2dAi X-Authority-Analysis: v=2.4 cv=daSwG3Xe c=1 sm=1 tr=0 ts=6a195b61 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=MYhr4v4WboA43l5+MyccHQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=ub0LQIPdQfE24AbRluEA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI5MDA5MiBTYWx0ZWRfX8rfvYTqwOCwz NKR5vODe+AvaLs7TB/UsroQiTIJjGLpI7Hj98NpbgPY1lFzGw3YfOSWsxsifkRHQqX1HKF2zB5T tr9JN9X/CdF5y9SUGwlpRo2qTZfr6gEZE/3B9vjvNz1ZoTxBypcKNSvgXjL0QlBL9BWZkLbcJEq t7WGnFXj2Z47LVjKPQQQU7n0r6LdB3ln/h5VXhy/t4VKynGVWB4dspMbedOTtG8legCc8NndDI5 W8JmIl/PHejFOmeN8y770Mu2O69kSovXOjNgKt2Vyc0pP2v+yGiEzY8USkqttj3uYvW9PiEUEmT yMTlmHXsgo7f9/QPERBJiCronWSCt3r/ernkd16PrnDazLraw48oCv95VpxlAm72oJXF1koogXN rDX+EvUHHrbGci4WvI4dZayDjCNALiZzwg//kFORivedXc3FxngLPbuI8aC2OtTSWeHMCXwAmZm EZZ+95W5McmzMKifukg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-29_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605290092 On 28-05-2026 07:16 pm, Dmitry Baryshkov wrote: > On Thu, May 28, 2026 at 03:37:06PM +0530, Imran Shaik wrote: >> The Qualcomm Shikra GPU clock controller is similar to QCM2290 GPUCC >> hardware block, with minor differences. Drop modelling of critical >> clocks and keep them enabled at probe time, update the QCM2290 GPUCC >> driver to align with the latest common qcom_cc_probe() model. Update the >> GDSC *_wait_val and flags which are applicable for both QCM2290 and Shikra. > > There are a lot of separate, unrelated changes. Split your patches (not > only this one) following the 'atomic logical changes' approach. > Sure, will split the patches in next series. Thanks, Imran >> Signed-off-by: Imran Shaik >> --- >> drivers/clk/qcom/gpucc-qcm2290.c | 174 +++++++++++++++++---------------------- >> 1 file changed, 74 insertions(+), 100 deletions(-) >>