From: Jarod Wilson <jarod@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, j.vosburgh@gmail.com,
vfalico@gmail.com, andy@greyhouse.net, netdev@vger.kernel.org
Subject: Re: [PATCH net] bonding: fix accounting of active ports in 3ad
Date: Fri, 19 May 2017 18:15:57 -0400 [thread overview]
Message-ID: <95c9a6b9-ac60-caa1-416d-c74e1aea08f4@redhat.com> (raw)
In-Reply-To: <20170519.171417.473208349438307952.davem@davemloft.net>
On 2017-05-19 5:14 PM, David Miller wrote:
> From: Jarod Wilson <jarod@redhat.com>
> Date: Wed, 17 May 2017 11:11:44 -0400
>
>> As of 7bb11dc9f59d and 0622cab0341c, bond slaves in a 3ad bond are not
>> removed from the aggregator when they are down, and the active slave count
>> is NOT equal to number of ports in the aggregator, but rather the number
>> of ports in the aggregator that are still enabled.
> ...
>> Remedy it by using the same logic introduced in
>> 7bb11dc9f59d in __bond_3ad_get_active_agg_info(), so sysfs, procfs and
> ^^^^^^^^^^^^
>> netlink all report the number of active ports.
>
> I think you mean to reference commit 0622cab0341c here not 7bb11dc9f59d.
D'oh, yes, you are entirely correct. Should I submit a v2 with that
correction?
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2017-05-19 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 15:11 Jarod Wilson
2017-05-19 21:14 ` David Miller
2017-05-19 22:15 ` Jarod Wilson [this message]
2017-05-19 23:17 ` David Miller
2017-05-19 23:43 ` [PATCH net v2] " Jarod Wilson
2017-05-22 16:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95c9a6b9-ac60-caa1-416d-c74e1aea08f4@redhat.com \
--to=jarod@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®