From: Baolin Wang <baolin.wang@linaro.org>
To: dan.j.williams@intel.com, vkoul@kernel.org, eric.long@unisoc.com
Cc: broonie@kernel.org, baolin.wang@linaro.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RESEND PATCH 3/7] dmaengine: sprd: Fix the last link-list configuration
Date: Tue, 6 Nov 2018 13:01:33 +0800 [thread overview]
Message-ID: <95cbea4b835bb2689036afe78ff0b2239a24f352.1541480353.git.baolin.wang@linaro.org> (raw)
In-Reply-To: <cover.1541480353.git.baolin.wang@linaro.org>
In-Reply-To: <cover.1541480353.git.baolin.wang@linaro.org>
From: Eric Long <eric.long@spreadtrum.com>
We will pass sglen as 0 configure the last link-list configuration
when filling the descriptor, which will cause the incorrect link-list
configuration. Thus we should check if the sglen is 0 to configure
the correct link-list configuration.
Signed-off-by: Eric Long <eric.long@spreadtrum.com>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/dma/sprd-dma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index 4f3587b..e6a74dc 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -697,7 +697,8 @@ static int sprd_dma_fill_desc(struct dma_chan *chan,
hw->cfg |= SPRD_DMA_LINKLIST_EN;
/* link-list index */
- temp = (sg_index + 1) % sglen;
+ temp = sglen ? (sg_index + 1) % sglen : 0;
+
/* Next link-list configuration's physical address offset */
temp = temp * sizeof(*hw) + SPRD_DMA_CHN_SRC_ADDR;
/*
--
1.7.9.5
next prev parent reply other threads:[~2018-11-06 5:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 5:01 [RESEND PATCH 0/7] Add some fixes and new feature for SPRD DMA Baolin Wang
2018-11-06 5:01 ` [RESEND PATCH 1/7] dmaengine: sprd: Remove direction usage from struct dma_slave_config Baolin Wang
2018-11-06 5:01 ` [RESEND PATCH 2/7] dmaengine: sprd: Get transfer residue depending on the transfer direction Baolin Wang
2018-11-06 5:01 ` Baolin Wang [this message]
2018-11-06 5:01 ` [RESEND PATCH 4/7] dmaengine: sprd: Set cur_desc as NULL when free or terminate one dma channel Baolin Wang
2018-11-06 5:01 ` [RESEND PATCH 5/7] dmaengine: sprd: Support DMA link-list cyclic callback Baolin Wang
2018-11-06 5:01 ` [RESEND PATCH 6/7] dmaengine: sprd: Support DMA 2-stage transfer mode Baolin Wang
2018-11-06 5:01 ` [RESEND PATCH 7/7] dmaengine: sprd: Add me as one of the module authors Baolin Wang
2018-11-26 6:49 ` [RESEND PATCH 0/7] Add some fixes and new feature for SPRD DMA Baolin Wang
2018-12-05 8:57 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95cbea4b835bb2689036afe78ff0b2239a24f352.1541480353.git.baolin.wang@linaro.org \
--to=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.long@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®