From: Bart Van Assche <bvanassche@acm.org>
To: Ye Bin <yebin10@huawei.com>,
martin.petersen@oracle.com, jejb@linux.ibm.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: Fix incorrect usage of shost_for_each_device
Date: Mon, 18 May 2020 07:39:30 -0700 [thread overview]
Message-ID: <95d13fe2-e267-a536-def4-083a20c016be@acm.org> (raw)
In-Reply-To: <20200518074420.39275-1-yebin10@huawei.com>
On 2020-05-18 00:44, Ye Bin wrote:
> shost_for_each_device(sdev, shost) \
> for ((sdev) = __scsi_iterate_devices((shost), NULL); \
> (sdev); \
> (sdev) = __scsi_iterate_devices((shost), (sdev)))
>
> When terminating shost_for_each_device() iteration with break or return,
> scsi_device_put() should be used to prevent stale scsi device references from
> being left behind.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2020-05-18 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 7:44 Ye Bin
2020-05-18 14:39 ` Bart Van Assche [this message]
2020-05-20 2:30 ` Martin K. Petersen
2020-06-04 6:05 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95d13fe2-e267-a536-def4-083a20c016be@acm.org \
--to=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome