mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Lyle <mlyle@lyle.org>
To: Liang Chen <liangchen.linux@gmail.com>, linux-bcache@vger.kernel.org
Cc: i@coly.li, kent.overstreet@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] bcache: safeguard a dangerous addressing in closure_queue
Date: Thu, 12 Oct 2017 22:48:51 -0700	[thread overview]
Message-ID: <95ddfc9f-b01e-3346-4ebf-d15d73644d35@lyle.org> (raw)
In-Reply-To: <20171013053049.11875-1-liangchen.linux@gmail.com>

Hi Liang--

Thanks for the quick turnaround.  I've added this to bcache-for-next.

On 10/12/2017 10:30 PM, Liang Chen wrote:
> The use of the union reduces the size of closure struct by taking advantage
> of the current size of its members. The offset of func in work_struct equals
> the size of the first three members, so that work.work_func will just
> reference the forth member - fn.
> 
> This is smart but dangerous. It can be broken if work_struct or the other
> structs get changed, and can be a bit difficult to debug.
> 
> Signed-off-by: Liang Chen <liangchen.linux@gmail.com>

Reviewed-by: Michael Lyle <mlyle@lyle.org>

-Mike

      reply	other threads:[~2017-10-13  5:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13  5:30 Liang Chen
2017-10-13  5:48 ` Michael Lyle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95ddfc9f-b01e-3346-4ebf-d15d73644d35@lyle.org \
    --to=mlyle@lyle.org \
    --cc=i@coly.li \
    --cc=kent.overstreet@gmail.com \
    --cc=liangchen.linux@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®