From: Roger Quadros <rogerq@kernel.org>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Aswath Govindraju <a-govindraju@ti.com>,
Felipe Balbi <balbi@kernel.org>,
Rui Miguel Silva <rui.silva@linaro.org>, Bin Liu <b-liu@ti.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 5/6] usb: cdns3: Use platform_get_irq_byname() to get the interrupt
Date: Mon, 20 Dec 2021 12:48:26 +0200 [thread overview]
Message-ID: <95e016e9-4259-c1d6-f73c-ad79b7cef413@kernel.org> (raw)
In-Reply-To: <20211220010411.12075-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
On 20/12/2021 03:04, Lad Prabhakar wrote:
> platform_get_resource_byname(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq_byname().
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> drivers/usb/cdns3/cdns3-plat.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
> index 4d0f027e5bd3..dc068e940ed5 100644
> --- a/drivers/usb/cdns3/cdns3-plat.c
> +++ b/drivers/usb/cdns3/cdns3-plat.c
> @@ -13,6 +13,7 @@
> */
>
> #include <linux/module.h>
> +#include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> @@ -65,13 +66,14 @@ static int cdns3_plat_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, cdns);
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "host");
> - if (!res) {
> - dev_err(dev, "missing host IRQ\n");
> - return -ENODEV;
> - }
> + ret = platform_get_irq_byname(pdev, "host");
> + if (ret < 0)
> + return ret;
>
> - cdns->xhci_res[0] = *res;
> + cdns->xhci_res[0].start = ret;
> + cdns->xhci_res[0].end = ret;
> + cdns->xhci_res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(ret);
> + cdns->xhci_res[0].name = "host";
>
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "xhci");
> if (!res) {
>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
--
cheers,
-roger
next prev parent reply other threads:[~2021-12-20 10:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 1:04 [PATCH 0/6] usb: sound/soc: Use platform_get_irq*() variants to fetch IRQ's Lad Prabhakar
2021-12-20 1:04 ` [PATCH 1/6] usb: host: fotg210: Use platform_get_irq() to get the interrupt Lad Prabhakar
2021-12-20 10:21 ` Geert Uytterhoeven
2021-12-20 1:04 ` [PATCH 2/6] usb: renesas_usbhs: " Lad Prabhakar
2021-12-20 1:04 ` [PATCH 3/6] usb: dwc3: Drop unneeded calls to platform_get_resource_byname() Lad Prabhakar
2021-12-20 10:47 ` Roger Quadros
2021-12-20 1:04 ` [PATCH 4/6] usb: isp1760: Use platform_get_irq() to get the interrupt Lad Prabhakar
2021-12-20 10:25 ` Geert Uytterhoeven
2021-12-20 15:37 ` Rui Miguel Silva
2021-12-20 1:04 ` [PATCH 5/6] usb: cdns3: Use platform_get_irq_byname() " Lad Prabhakar
2021-12-20 10:48 ` Roger Quadros [this message]
2021-12-20 1:04 ` [PATCH 6/6] usb: musb: dsps: " Lad Prabhakar
2021-12-21 7:51 ` [PATCH 0/6] usb: sound/soc: Use platform_get_irq*() variants to fetch IRQ's Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95e016e9-4259-c1d6-f73c-ad79b7cef413@kernel.org \
--to=rogerq@kernel.org \
--cc=a-govindraju@ti.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=rui.silva@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®