From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5218C2FD1B3 for ; Fri, 14 Nov 2025 08:33:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763109196; cv=none; b=uqq3zdXegvsx+wb4nrxClaVIS4MROM7Z/SMFec1tPewEbCjkWngLmJLlHEIl5A4ISWcPQz4BbEi0gcxPGzvzlMFhR21sMD4qIUOqDO9XHuK7Dk0xjLElzz9B7oihXMiL5q1B1rCeW42SEOhFOvD8RtBmScoCFN3iDsn9BpHgSXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763109196; c=relaxed/simple; bh=PFl33I0QJqg/12ihlGpsei/r6GgKWpKb7KCY1L2LsGY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MB/rPteX4Gx5YD6SCNKbFrIWbJU63AWx3uLMocRbeNzKeY4B3rku+EJtKiLkRNa7P82NlOLyGeH1vncSODYZAO/dEkwWEyhAYcpHF40pmOM8+B7IDg3gXJLWZlve/zNXFUImtUsn0VMHo19zsYt/ogyVsLrtc1idEEXOELdrnhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J1V0ndcd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J1V0ndcd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74B3CC19424; Fri, 14 Nov 2025 08:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763109195; bh=PFl33I0QJqg/12ihlGpsei/r6GgKWpKb7KCY1L2LsGY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=J1V0ndcdbmJYb817ivKEItL2rF4KI8nAuQGaxTw7ZVBI+LbR1RTSstti1Fm4IzhiY VzfYk8Q66tG3c7SGE97UTkwH3vaKsELxUkz/zws2peiK5UA1Hv1SiNOKxg5htGU06U +WQSI9qwkp1O5BH8tny+ZmVb4Hu/cX/kdOuu8d2T8Y7gSxxKOqXTZwpf4CmJqkrpw9 96Iyf55ubQo0ob2h9TBcjn1gA4caqz1BqSB8e+NmevZZQ1Hmp7qgtvs9tB0asx5Xv/ 86hCNcS3CvgtobtHS3+6a8vx98BPwizKfvVDfnY+2JjVhcvMFQcSyMejS7BqAmPQK4 w4/Cx+Y28i6Jg== Message-ID: <95e27bd3-6ce7-46a3-81d5-0fc830908b10@kernel.org> Date: Fri, 14 Nov 2025 09:33:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gpu/drm/nouveau: fix return type in nouveau_dmem_migrate_to_ram() To: Balbir Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org Cc: kernel test robot , Andrew Morton , Zi Yan , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Oscar Salvador , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20251114012221.2634832-1-balbirs@nvidia.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <20251114012221.2634832-1-balbirs@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14.11.25 02:22, Balbir Singh wrote: > ret of type vm_fault_t is reused to capture the return value of > nouveau_dmem_copy_folio(), which returns an int. Use a new variable > err to fix the issue. The issue is not new, prior to this the function > called was called nouveau_dmem_copy_one() and ret was used to capture > it's value. > > The bug does not cause a real issue at runtime, the value is used > as a boolean to check if nouveau_dmem_copy_folio() succeeded or failed. > The different types should not impact the execution of the code at > runtime. > Also, as commented previously, the prefix in the subject does not match existing norms. Take a look at git log --oneline drivers/gpu/drm/nouveau/nouveau_dmem.c and note how it's commonly something along the lines of "drm/nouveau" or better "drm/nouveau/dmem". The only patch that uses "gpu/drm/nouveau" is from you recently. In fact, there is no other patch in the codebase that uses that prefix. -- Cheers David