From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E7D0C4708C for ; Sat, 29 May 2021 02:36:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 079A3611AB for ; Sat, 29 May 2021 02:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbhE2CiV (ORCPT ); Fri, 28 May 2021 22:38:21 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:2340 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbhE2CiU (ORCPT ); Fri, 28 May 2021 22:38:20 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4FsQYd5WR5z19Vjt; Sat, 29 May 2021 10:32:05 +0800 (CST) Received: from dggpemm500004.china.huawei.com (7.185.36.219) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Sat, 29 May 2021 10:36:42 +0800 Received: from [10.174.177.91] (10.174.177.91) by dggpemm500004.china.huawei.com (7.185.36.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Sat, 29 May 2021 10:36:42 +0800 Subject: Re: [PATCH -next] sched: make sched_set_stop_task() static To: , , , CC: , , , , , References: <20210529022956.43858-1-cuibixuan@huawei.com> From: Bixuan Cui Message-ID: <95e6bf7d-7d1d-3aed-3bd6-0695b1cab12e@huawei.com> Date: Sat, 29 May 2021 10:36:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20210529022956.43858-1-cuibixuan@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.91] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500004.china.huawei.com (7.185.36.219) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/29 10:29, Bixuan Cui wrote: > make W=1 generates the following warning for kernel/sched/core.c: > warning: no previous prototype for ‘sched_set_stop_task’ [-Wmissing-prototypes] > > Signed-off-by: Bixuan Cui > --- > kernel/sched/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index adea0b1e8036..1c1e9612018b 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -3209,7 +3209,7 @@ int select_task_rq(struct task_struct *p, int cpu, int wake_flags) > return cpu; > } > > -void sched_set_stop_task(int cpu, struct task_struct *stop) > +static void sched_set_stop_task(int cpu, struct task_struct *stop) > { > static struct lock_class_key stop_pi_lock; > struct sched_param param = { .sched_priority = MAX_RT_PRIO - 1 }; Hi, This patch will cause compilation errors. Please ignore it. :-( Thanks Bixuan Cui >