From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3F3237C936 for ; Mon, 6 Jul 2026 04:55:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783313759; cv=none; b=hBFR1gE32NkxQKtUNWzDUa0rEUqnZIeEjlfRhPQKWmply3w/5/Pk+EleAPLZ7sim6RD2AhPWQMfah1qUQssq6tQs/pnK/LleLNAATJ7raE/rhHbSZJqsd9RiImzWK141TIEppv3vqlTT0J6agLHPer2qp9Sf7uXBUQ3bFNYKRCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783313759; c=relaxed/simple; bh=YmgsfoXmP3wicea3p38VOglMuty4QAN7Ko28KEOX1Hc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WRivAHliy9Cg0/gbCbtW/MRmDTtSUahQflY7inYOML7uB247yMd+YEGD/mV6oldMsPjgO3IHtIUM3xJ36SIZBPACKZh4zFkF0Ft0OhxO+HNYoesDckKaJveoRQotyFGiuVmlnJwRv7jGda7EY35h+losnS8C2UruO/F3rpYt0kA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BtuYZphI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z3Jr5zap; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BtuYZphI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z3Jr5zap" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66641Zla3615523 for ; Mon, 6 Jul 2026 04:55:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JvLKKEyLLlv8tWw8qJtzyelBHieDthun419uycWn1Dc=; b=BtuYZphIK7UnAPPa qYGHPuM+VD3C6WvezTLdqIjiYVGHLzNLv6RSapQqEJ2excDEyUkD/0AEcWQjp5ej 4HI3bMiV8UCRYHw/YXMP72BUtTB2CANb5/xl2wJKaV5lc87Ax6wEFDsEhbUsTXur RNx2Hm91I1sPL4Fp17l4JFxQuB37ZPnouzzUHhLqbWpMJkm6xOuGNEQuSB8vkr4v iHs+mInjL3lcrCXDe3aaUW3MnfspbyT4APEA3ecMXRsbeK03HAVvm7fbyNR3ckpu 4lDTqZIfECL8APV6bvyHqU87nPrqklBdw7zS2B0zT/os5ltI50S9QbhC5yDZwUWY z7D7UA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6td3ccrw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 04:55:57 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3811ae55313so2040862a91.3 for ; Sun, 05 Jul 2026 21:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783313756; x=1783918556; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JvLKKEyLLlv8tWw8qJtzyelBHieDthun419uycWn1Dc=; b=Z3Jr5zap9lUWE5NcKmoo9cq4VyYd8OfMJGVQ6b4AKiCEBOMaj87jG60tHh+PoJe8zn Nx8ZhE9BKLjIcVtnjd3NzKx5w1mutKKi3zTqyOYyg8ICK2g1jmoefVbycgr3tmk9H52N kXxEAYauB1ur/Gpn1QujPW4nmKf8HSlqLi2eYH0Gypm76IOueG94Oj57ecdMJqSBmwjO qx3Kf+rydvZdq4PIXZqotXQc7paiAki1F1wUbnFuaUEYZS5b6RS5letdZKyVFgu5RA9Y FV8jSmCzURwxVusAJCv4/HNWsKhhgQjNktQG3QrTiH0PV1JuPBsAg8/ZazyRiFkh9NoQ dAYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783313756; x=1783918556; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JvLKKEyLLlv8tWw8qJtzyelBHieDthun419uycWn1Dc=; b=KqeYxbXQl93AjUxAOtcNAeVqdHVe50nwhv/PRBofstM2RrgQ/9xeDlY7Mz3BlV0LTs cCipEE+mjMKl0WqAmV4cq0GbRB4s0q0EacwjQyPNexmU61XnNZA3AweSOe4wtEdTAkiV OoSYiLzcf2cqhCBRlKfRL+5ZWzEAoJunYHnHlZ0Wo4gA/mInrlR3EKr3uSnVsHzv2kig AqjlNDMFMKiXWGtjnlas/xItLuNyZmkynZ2h+BQvot6C4kqWI0ConVdrQVkkOz9RHAi6 3Yv8phVdScBFaJo40XMX+hCiMZYwDIJJhsDrhJ7MBe7x1khVGDI9XA3rbP1W2nXnFxJD bHzw== X-Forwarded-Encrypted: i=1; AHgh+RqQ8MpQ4nYeCjy+hq5ihgRH8puztUX2gqhQeGIv0S9UXUmpzZh7Y47j1yPvD4ZoAYYiYWyuMA7BCEeSnpY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6WkfBbjQf+/rrtWJwBC2+aLFx6kKRRUlAz1c6cxogWrDrVJhw 5KuyfI+4YNx3B+P0jrbbMi322jv7AbTuQbw39HIO5jr44PsPdbCYVygW2AMdYHkr8phZofvuO0k c5+zrtbqPoc7TtkqmZnuLoCClN4W2DwzaFOplrVCNsGkwF/xFEomUF1/tbv5fPHZiFuE= X-Gm-Gg: AfdE7cnEfzhEK+i7/cnTUj8rL/BC0dfaz+7odwKmMELbs4ADPmu5IBjKris7Pcm+eTK aNI+0O2eqIfTkn4YfTba4oDEoyD4wGSjC+h3yhZs0fTb3aIwlk2XsznISZoihJ0wYfVNPPHlJ5e nDo40L9wouyqEi6mv9jWnt9t5eSoTRS3I97JB8W0p1yZOow3latf0p120vQcjlGE+/Hc926rtnO wCgd7v0ItWXpO6weXmv3BuqEOYfDyNDVY2k54S+Zo9k7s6oxIGHp18k9oYsejdZ3Y5WYH2q/Xm2 694YEEpccN/8yWjhtlqQv48SRBA6G/ixZMdktJuTBQLbkO1jYKZt6BX1XEN8lMgDDopOqgnXsmG DYkL8bSuULNJmVXKDwENfwTa4ZKUAtgXMzActu+0N X-Received: by 2002:a17:90b:35cf:b0:381:9b7b:35e5 with SMTP id 98e67ed59e1d1-382800d1a6emr8328717a91.4.1783313756487; Sun, 05 Jul 2026 21:55:56 -0700 (PDT) X-Received: by 2002:a17:90b:35cf:b0:381:9b7b:35e5 with SMTP id 98e67ed59e1d1-382800d1a6emr8328696a91.4.1783313755987; Sun, 05 Jul 2026 21:55:55 -0700 (PDT) Received: from [10.204.78.130] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3114fe08b1bsm12946548eec.26.2026.07.05.21.55.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jul 2026 21:55:55 -0700 (PDT) Message-ID: <95e8281c-91e9-4444-8b83-ea87243122c9@oss.qualcomm.com> Date: Mon, 6 Jul 2026 10:25:47 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 40/42] misc: fastrpc: Use devm_of_reserved_mem_device_init() To: Mukesh Ojha , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-mmc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, openbmc@lists.ozlabs.org, sound-open-firmware@alsa-project.org, Srinivas Kandagatla Cc: Konrad Dybcio References: <20260703193855.110619-1-mukesh.ojha@oss.qualcomm.com> <20260705194019.2565498-8-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: <20260705194019.2565498-8-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDA0NSBTYWx0ZWRfX28UfiX+aR9hh JGcmcBHL06fSWf3Y+M+kiLGTk8F25gz+pc4tHXvtkfCMa3dqb17gel72Bix728t6ec0FGX8dy4F mCnzzEp2PFF64CPIjnAWFJuZ+RZQUA0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDA0NSBTYWx0ZWRfXzHTrR2nEQgBb KY5WG4fegOSW98xp2nEreo+2ka68l2ksZzFAnYC8bQGydPQBViiNiVMKnKoOdTw11aey4C9jFh0 +T+jAZxLTuE0nVgw4mAby1w4B2P/sikxbYtlzFRs3qmEKtdOrOpznalJviC3E8Zq3jjUZ30bAxL GvkwJzplY79JYNtDn6V1FzJaFY3fplfcPkk3AHg9B/VcR8B1pPHxjVg9my1sa8E+6LxlGuWhVY+ atp2F8j5zVuOAfepdHPNez5+bYS9yzcaFPXbJev6fugwq+tBjD0HbujokSjzQ53lqZi1KsAs6rz HEbd7nJhlTpl35TFflePw2OnvD2cTit6jd+dNIH+szD00wJFDjJ/Sawm151G6jUN3PQQbeB93HO kU12ZSBk0LhzyjEeVSaiXDM0UAZTkHTdUjdTpBWw6UuFZSN5psl1pVLVL12wmZhJxHoNdbSzn2N p2J3M+fRi0WTV+AF6uQ== X-Proofpoint-GUID: aXp0ZF_4FsBOYQ303hS_pEMihgzeqFcc X-Proofpoint-ORIG-GUID: aXp0ZF_4FsBOYQ303hS_pEMihgzeqFcc X-Authority-Analysis: v=2.4 cv=b9GCJNGx c=1 sm=1 tr=0 ts=6a4b355d cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=ee02QKOXNWxg8IJ2rEsA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060045 On 06-07-2026 01:10, Mukesh Ojha wrote: > Use the devres-managed devm_of_reserved_mem_device_init() to ensure > the reserved memory region is released on device removal, fixing a > missing of_reserved_mem_device_release() in fastrpc_rpmsg_remove(). nit: I see this change is also fixing fastrpc_rpmsg_probe() early failure leaks as well as -EPROBE_DEFER retry paths which could be added to the commit message. Reviewed-by: Ekansh Gupta > > Signed-off-by: Mukesh Ojha > --- > drivers/misc/fastrpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index d86e79134c68..c4e05b0db527 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -2396,7 +2396,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) > return -EINVAL; > } > > - if (of_reserved_mem_device_init_by_idx(rdev, rdev->of_node, 0)) > + if (devm_of_reserved_mem_device_init(rdev)) > dev_info(rdev, "no reserved DMA memory for FASTRPC\n"); > > vmcount = of_property_read_variable_u32_array(rdev->of_node,