mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wang, Sen" <sen@ti.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Mark Brown <broonie@kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	<linux-sound@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] ASoC: simple-card-utils: support system-clock-id DT property
Date: Tue, 16 Jun 2026 16:14:44 -0500	[thread overview]
Message-ID: <95e84e30-673f-4638-8d0a-1d0d756c209c@ti.com> (raw)
In-Reply-To: <20260607163845.652bcc73@kemnade.info>

On 6/7/2026 9:38 AM, Andreas Kemnade wrote:
> Hi,
> 
> On Fri, 15 May 2026 11:13:56 -0500
> Sen Wang <sen@ti.com> wrote:
> 
>> Adding an optional, u32 system-clock-id DT property into the generic machine
>> driver so clocking topology info can be exposed in DT.
>>
> while having this binding would solve some of my problem. I am wondering
> whether is the right approach. What about modelling the clocks involved
> using the clk framework, so let some more codecs/dais be clock provider.
> So things can be configured that way.
> E.g. tlv320aic32x4-clk.c
> 
> Same for set_div() which is also unavailable in these generic cards.
> 

Hi Andreas, just got back from break, sorry for the delayed message.

I agree with you, in retrospect, this patch is indeed a hasty patch that 
only covers up the legacy clk-id scheme rather than adapting the modern 
clk framework.

Modeling individual cpu/codec DAI clocks does seem to be the way to go,
not the one patch fix-all solution I'd hope for, but I still wanted to 
see if I can reuse the existing CCF patterns for drivers with 
clk-id/div-id as an alternative.

Best,
Sen Wang


      reply	other threads:[~2026-06-16 21:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 16:13 Sen Wang
2026-05-15 16:13 ` [PATCH v2 1/2] dt-bindings: sound: simple-card: add system-clock-id property Sen Wang
2026-05-16  9:54   ` Krzysztof Kozlowski
2026-05-16 10:17     ` Wang, Sen
2026-05-15 16:13 ` [PATCH v2 2/2] ASoC: simple-card-utils: support system-clock-id DT property Sen Wang
2026-05-15 19:32 ` [PATCH v2 0/2] " Wang, Sen
2026-06-07 14:38 ` Andreas Kemnade
2026-06-16 21:14   ` Wang, Sen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95e84e30-673f-4638-8d0a-1d0d756c209c@ti.com \
    --to=sen@ti.com \
    --cc=andreas@kemnade.info \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®