From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9A4D3590A4 for ; Mon, 2 Feb 2026 10:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770027660; cv=none; b=a/L3ZKo/ETL0Orn20J7bTs5gnxSECmA1FF+s9gEFd4sPExZ4QzZHGM3GIvHv9hiiG8e7yaqtwBbfGCGcoU/jetWZ0vrGDmdCZvcWmIwGUPb9cUiIOyKZOO+136bPTLaHOLK+tm6KqGueRfyTJx9lX5w4Xf9RjW0BfTHjRkvs8aA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770027660; c=relaxed/simple; bh=69fDhM2MNSYKxaIMW4WQElFr9savBfG6n3ZiVVmCrvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TYyN5vVRrDTdS9IXSPtrgcgBP4+FBNTVbnpr8aSCdH0Hgye8bsZUN2RHjm35aEnEW3lBIPU8yxjfK8Bqpcc5NdFiFv1rHw0cS4ImdlqPHoKrwpDGxZBDAv6S9n0I0OZ+u8rW767JByywOp+NKAsY/hMSa6ePp9f9gQcTrNRk8SQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LfeWzLyn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DgM9nJmR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LfeWzLyn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DgM9nJmR" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61285c8N1305591 for ; Mon, 2 Feb 2026 10:20:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lbbM/5o1YHALe2TiY8ThEdvZflmJ7vTUzQzZZ/lJdhI=; b=LfeWzLynzkq8Bv5t C5MPnSHxOjq7oh8+tX3T0NiQvQR2iJagb03UIXhw4YYpRldzv7mK76JRIMTT5C+8 RSYQ90Ruaq/rcLQUwmG+H/y2qFwQzXp2cRq6nipWHxfmUWC+kwiejHBXa+oAx4dp CLqb8Fp+4FGZUuI+XYAsW7tLSLrMrcni8rjJK7LQt7HnVB+veTd4Clfb6fSJERBI DWfy78k6fBcX9c+TS5GDG0LxfWZtzAAiR1t+Q/103u1cazi70eDoOjWV+t2m4+IM 8syjT4XJKblKheZWb2OQWqavVmagmNKgLBe3zj5BFOZR4sSNyrxuJmpRkStZO6mQ 1XS+rQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c1arrw0c8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 10:20:57 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-890072346c2so8874446d6.3 for ; Mon, 02 Feb 2026 02:20:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770027657; x=1770632457; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lbbM/5o1YHALe2TiY8ThEdvZflmJ7vTUzQzZZ/lJdhI=; b=DgM9nJmRGGu6UR2y3scKn06pD4TyiNASqJ6XStODlNHZLZTplMSsNXTCWxHkmEWZ1i ZwLD0Pcw7Ioiq6fbG3/8icM+9Fsr0uW+MWyQxxy0BTIeRh6kaawbDwbNYMLwlR50F2pr cTzLbvWhieTonCMm6pcQaSKdfLXAo07coQiCgby999sCH8FuWIXEaGRBcmeCI82rfPID bQIeJGd6l/l5WTXQVzgb042SQBt2Bf3X0L/QaaJzAjp5y9S3ucrvXOq9r9D19jzxkQTq X+tU4gblPNaSJGv5z2MFsoJrC4Dt6pyT5dWEfUEK6+gAXxJLhOItZ8HaxlcciDgiHte5 1ckA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770027657; x=1770632457; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lbbM/5o1YHALe2TiY8ThEdvZflmJ7vTUzQzZZ/lJdhI=; b=Yp8C80QJDmqKgMYxXq63xqa1uaIxTw2yt456UL9YgQO/RfX7UFxcO/2RfiBJHE/Xio SC6aAC+EywmflV2fNKa8OZVtA63D43C0T3qLd4OOLxMCAFH26+1H27xsDGMmjqXY+iFF nczfXTLVgzbwvIRCP74XRMdb++C+OQqEO8SfFvcLCgvpONLxx2ak2hiZlVTfUDYQAn+6 iAD1pM9FDQq6oU71KWrdereb1Dp3vgjWwPRnFVCilJ1ACFosy7l9aVDOCsSwemz5YMvf JzV4PTXW8wkLNYN7GiwfQk7s8tgCKAoUs1O7oyjkGNpdaEy07rYdoLaye4wDOHeIiUHS eQKA== X-Forwarded-Encrypted: i=1; AJvYcCVNiOHGhH5jpvZN5aJbYV15/pSN7mnD6x3q4k6aeLBB61H+GHZDYbeaZdIPEEgdfIJLg2aerQ0zsPecVdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ1Sj7cWX1TK6pbPFEH+F+j/bgD/FfhUPyHPqhfTjqwPUSwdiG oaZMyNd6alv7s6sQrvpuWiHKsFL/22Gr/irXFnrK+yHYZJxHWBx5BdQ9b4SoUmQjQ6C9QO/0eSs L7/uTSXbKGq7/guXWeKsj2obZN9coL+Fz4sW9318eH2W/q4cLzsWWouGyO89LkcAwjpw= X-Gm-Gg: AZuq6aKOBEt/CjB4HEUl3UM83MDuPI8Yn+vcjpz0jtyaQ/i8acN/F4q2SB/Sje3tN8P 3l/XiwBtWTVQagX/xYKoXROtBwZE8HyXHaEY7YPZiVfluN6rSCaH4yYw0dolB8GzoHFhUkokCKE Da2Whjnr6Pue0eQtDilhIlUSTzTiwNPre+5QAWkTvzMSXnfw+rOfkV7hIr64oPB6TNPOtZASNTH gHIwqP7cNW8elbN/Qi4cN9hmXc8WWGwvYDdYUEuG/hwKi23yh2eVeyDdxAsOaOaPdCVj3uHYgPd q1HYtkTWrgHOGKbeIPHT7zYl6muaMW6yPAu5lccPLGbTx0+srMCDmv82oqBcFROqzOZjtLfpA2b KfzHSxryV48955ZkmLpdoMwvLn0kKXM9Qoykfu30DRcpoMC9nrSjInHpkRoLUlzr96Fw= X-Received: by 2002:a05:6214:4d03:b0:894:6c97:691b with SMTP id 6a1803df08f44-894ea075718mr115131456d6.6.1770027657252; Mon, 02 Feb 2026 02:20:57 -0800 (PST) X-Received: by 2002:a05:6214:4d03:b0:894:6c97:691b with SMTP id 6a1803df08f44-894ea075718mr115131106d6.6.1770027656840; Mon, 02 Feb 2026 02:20:56 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4453094sm7382716a12.14.2026.02.02.02.20.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 02:20:55 -0800 (PST) Message-ID: <95ec1fa0-5f0b-4dc2-a420-599d61f5e11d@oss.qualcomm.com> Date: Mon, 2 Feb 2026 11:20:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/8] media: iris: scale MMCX power domain on SM8250 To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jonathan Marek , Ulf Hansson , "Rafael J. Wysocki" , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Stanimir Varbanov , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Konrad Dybcio , Bryan O'Donoghue , Dikshita Agarwal Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20260201-iris-venus-fix-sm8250-v2-0-6f40d2605c89@oss.qualcomm.com> <20260201-iris-venus-fix-sm8250-v2-4-6f40d2605c89@oss.qualcomm.com> <95977a30-616c-44af-ac93-90bae2bed298@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: Jk7SmGzPNSNwNccPy2RCN6DxUAfj-hTG X-Authority-Analysis: v=2.4 cv=FNYWBuos c=1 sm=1 tr=0 ts=69807a89 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=PIOu0JlNxAVOzX5nUJ4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA4NiBTYWx0ZWRfX0eUX0qU3uRFe +bnplASOcOaKvLuUYfnZM1PjNT7pgriS0rRHxKzIHj09ywuiUfK5bIlQouD8vC7aVOFMYT23lko My+f0rJ2pssx2UgnTaEI2mSGxf7GGANW3f/IGAS0zgSWx6GcfoJZ1ElB8tjOWtbD9RyCMNVNLOH JgNuElCf646GWBK0W3meLdWEqdh0A4HpGktkvPRFBFsBFsiXsEKtoD/17FJXK4ZrJsZL4YdTws1 kXjo0me1MNzWC5JYR7dDBNczfjpyuDTDAH3un5wmGJbz0BYyG1Ij0R15QgDm3Z491Tk8JdNyXPR 2ShZ8Wv48iF7KahFI28jFD75Re/EZV8QfvOsfvuQxD7l8BhPeb9OTjE/+w1KO8OcCQMXcxYsSFY mYxJNspBVVSfjKT4nVl+N+ZNG9rprZXOPtua55GfaxuEGmYnXRsAfEbMoiJNFLFitGbUaDiTCJi yjPG9jVVe8vbOx+iNUQ== X-Proofpoint-GUID: Jk7SmGzPNSNwNccPy2RCN6DxUAfj-hTG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_03,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020086 On 2/2/26 11:12 AM, Dmitry Baryshkov wrote: > On 02/02/2026 12:07, Konrad Dybcio wrote: >> On 2/1/26 11:49 AM, Dmitry Baryshkov wrote: >>> On SM8250 most of the video clocks are powered by the MMCX domain, while >>> the PLL it powered on by the MX domain. Extend the driver to support >>> scaling both power domains, while keeping compatibitility with the >>> existing DTs, which define only the MX domain. >>> >>> Fixes: 79865252acb6 ("media: iris: enable video driver probe of SM8250 SoC") >>> Signed-off-by: Dmitry Baryshkov >>> --- >>>   drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 +- >>>   drivers/media/platform/qcom/iris/iris_probe.c         | 7 +++++++ >>>   2 files changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c >>> index df8e6bf9430e..aa71f7f53ee3 100644 >>> --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c >>> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c >>> @@ -281,7 +281,7 @@ static const struct bw_info sm8250_bw_table_dec[] = { >>>     static const char * const sm8250_pmdomain_table[] = { "venus", "vcodec0" }; >>>   -static const char * const sm8250_opp_pd_table[] = { "mx" }; >>> +static const char * const sm8250_opp_pd_table[] = { "mx", "mmcx" }; >>>     static const struct platform_clk_data sm8250_clk_table[] = { >>>       {IRIS_AXI_CLK,  "iface"        }, >>> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c >>> index 7b612ad37e4f..74ec81e3d622 100644 >>> --- a/drivers/media/platform/qcom/iris/iris_probe.c >>> +++ b/drivers/media/platform/qcom/iris/iris_probe.c >>> @@ -64,6 +64,13 @@ static int iris_init_power_domains(struct iris_core *core) >>>           return ret; >>>         ret =  devm_pm_domain_attach_list(core->dev, &iris_opp_pd_data, &core->opp_pmdomain_tbl); >>> +    /* backwards compatibility for incomplete ABI SM8250 */ >>> +    if (ret == -ENODEV && >>> +        of_device_is_compatible(core->dev->of_node, "qcom,sm8250-venus")) { >>> +        iris_opp_pd_data.num_pd_names--; >> >> You're decrementing 1 to 0 @ this point in the series > > Why? > >  .opp_pd_tbl_size = ARRAY_SIZE(sm8250_opp_pd_table), > >  .num_pd_names = core->iris_platform_data->opp_pd_tbl_size, > > So here the nom_pd_names is decremented from 2 to 1 You're right, I was looking at the wrong file Konrad