From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 73CB03054E4 for ; Fri, 24 Oct 2025 08:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761296195; cv=none; b=BVLWOH8cpJQpLdIzlJi7M4uV72cbx6SYwAwwf4NrXD1kZqljj19r6yTfP5I5P38wnMMDkYJIbgkLXl6leoEVvRMifAVNdt7f9sntIVmDzmNEyxzupKP1Cgf/8LRXGEl/U0eYkm6uyT+HyAWebS2b+Yz4kxQZDnpkRFo1RFBw+68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761296195; c=relaxed/simple; bh=6Rb3pGmcQ3WWjYFKgBeNCXjNeL3qm6EeK5c4MJTNmAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BR2oq84S1eRhOdLX2WymmtZ5nPlftOesavfqVnp9hjvnGZV8yLVw3xyxjPrB1szfvCluTEJMxOHB00jMdEyQtULvBO2GUa5LY9sIrRIbV3tqRCInmHco7tyCyg0m2aMs06U9NzxKK9YENJqnUu81y5XozLp/Pke57VEem0na5Cc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 04B261516; Fri, 24 Oct 2025 01:56:25 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B384A3F63F; Fri, 24 Oct 2025 01:56:31 -0700 (PDT) Message-ID: <95ee2490-6904-4a24-93db-411c489bd2b4@arm.com> Date: Fri, 24 Oct 2025 09:56:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 2/2] arm64/mm: Add remaining TLBI_XXX_MASK macros To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev References: <20251024040207.137480-1-anshuman.khandual@arm.com> <20251024040207.137480-3-anshuman.khandual@arm.com> From: Ben Horgan Content-Language: en-US In-Reply-To: <20251024040207.137480-3-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Anshuman, On 10/24/25 05:02, Anshuman Khandual wrote: > Add remaining TLBI_XXX_MASK macros and replace current open encoded fields. > While here replace hard coded page size based shifts but with derived ones > via ilog2() thus adding some required context. > > TLBI_TTL_MASK has been split into separate TLBI_TTL_MASK and TLBI_TG_MASK > as appropriate because currently it simultaneously contains both page size > and translation table level information. KVM on arm64 has been updated to > accommodate these changes to TLBI_TTL_MASK. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: kvmarm@lists.linux.dev > Signed-off-by: Anshuman Khandual > --- > arch/arm64/include/asm/tlbflush.h | 26 ++++++++++++++++++-------- > arch/arm64/kvm/nested.c | 8 +++++--- > 2 files changed, 23 insertions(+), 11 deletions(-) > The code looks correct to me, no functional changes. I however, don't have any experience with this code and so don't know whether the split of TTL into TG and TTL is a good idea or not and if the kvm naming is best to stay the same or be updated to match this. Thanks, Ben