Re: [PATCH RESEND v5 0/5] stratix10: Add framework for asynchronous communication with SDM

[Mahesh Rao <mahesh.rao@altera.com>]

Hi Dinh,
	I hope you're doing well. It's been a while since I submitted the patch 
set, could you please take a moment to review it when you get a chance?

@Mathew Gerlach, I have addressed your comments. Please let me know if 
there’s anything else needed.

Best wishes
Mahesh Rao
	

On 08-07-2025 10:19 am, Mahesh Rao via B4 Relay wrote:
> The patch set includes the following changes:
> 
> - Add protection for querying memory objects in
>    multi-threaded flow.
> - Add support to generate and maintain message id
>    and client id for asynchronous communication with SDM.
> - Add framework to communicate with Secure Device
>    Manager(SDM) asynchronously by sending a request
>    and polling for response.
> - Add commands for performing Remote System Update
>    (RSU) operations asynchronously.
> - Migrate RSU driver to use the asynchronous
>    communication framework.
> 
> ---
> - Link to v5: https://lore.kernel.org/r/20250620-sip_svc_upstream-v5-0-732d4ac08a32@altera.com
> 
> Changes in v5:
> - Use FIELD_PREP, FIELD_GET() and GENMASK() for bit
>    manipulation for ids.
> - Bring down probing when stratix10_svc_async_init()
>    fails.
> - Other minor fixes.
> 
> - Link to v4: https://lore.kernel.org/r/20250610-sip_svc_upstream-v4-0-bcd9d6089071@altera.com
> 
> Changes in v4:
> - Added description for svc_mem_lock mutex.
> - Wrapped commit message and comments in source
>    code to kernel coding style as per coding style.
> - Added minor code fixes.
> - Moved variables to the top of the function
> - Removed HWMON support from in the patch-set, this
>    will be sent in a separate patch-set.
> - Added support for RSU commands to asynchronously
>    communicate with SDM.
> - Migrated RSU driver to use the supported
>    asynchronous commands.
> 
> - Link to v3: https://lore.kernel.org/r/20250526-sip_svc_upstream-v3-0-6a08a4502de3@altera.com
> 
> Changes in v3:
> - Changed "Stratix 10" to "Stratix10" in the commit
>    message and in source code.
> - Simplified stratix10_svc_add_async_client() by removing
>    redundant code for async common channel initialization.
> - Fixed resource cleanup on negative path in
>    stratix10_svc_remove_async_client() and stratix10_svc_async_init().
> - Removed optional interrupt handler support, will send the patches
>    in a separate patch-set.
> 
> - Link to v2: https://lore.kernel.org/r/20250512-sip_svc_upstream-v2-0-fae5c45c059d@altera.com
> 
> Changes in v2:
> - Added Reviewed by tag from Rob Herring for dt-binding
>    patch.
> - Resending the patch-set as there is no response from
>    the maintainers for the previous patch submission.
> 
> - Link to v1: https://lore.kernel.org/r/20250422-sip_svc_upstream-v1-0-088059190f31@altera.com
> 
> ---
> Mahesh Rao (5):
>        firmware: stratix10-svc: Add mutex lock and unlock in stratix10 memory allocation/free
>        firmware: stratix10-svc: Implement ID pool management for asynchronous operations
>        firmware: stratix10-svc: Add initial support for asynchronous communication with Stratix10 service channel
>        firmware: stratix10-svc: Add support for RSU commands in asynchronous framework
>        firmware: stratix10-rsu: Migrate RSU driver to use stratix10 asynchronous framework.
> 
>   drivers/firmware/stratix10-rsu.c                   | 272 +++---
>   drivers/firmware/stratix10-svc.c                   | 954 ++++++++++++++++++++-
>   include/linux/firmware/intel/stratix10-smc.h       |  76 ++
>   .../linux/firmware/intel/stratix10-svc-client.h    |  92 ++
>   4 files changed, 1253 insertions(+), 141 deletions(-)
> ---
> base-commit: 47633099a672fc7bfe604ef454e4f116e2c954b1
> change-id: 20250131-sip_svc_upstream-e78d8c9b4335
> 
> Best regards,