From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 127D4C43334 for ; Tue, 19 Jul 2022 14:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239470AbiGSOuJ (ORCPT ); Tue, 19 Jul 2022 10:50:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238614AbiGSOtt (ORCPT ); Tue, 19 Jul 2022 10:49:49 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BF12DF65; Tue, 19 Jul 2022 07:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658242187; x=1689778187; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=hHKtJ6+Dxw4RZU20X6JIbyKBSqc3/xUJvDskXuGrQIc=; b=Lc+qJn4qMJQJDWWaDlCmrIPKgBmUkq9tjBUc/+ESu/N20pEntfpo0bYM YE74x8lRrex7wrg06u9oznax2BsPv6TzIeTmQIUyxQakaJLxvfGgm4NGE xFWdgwSaNawk9D5xZzeBcXROccqbodpYY9FmQbjL0Tb96K3LBXPwV9Uoe VVXoasAwcv9qKVDZFTwF4t+CYwzTJMnLnTbBDa99h8XpWh0adH0vPdG4a vvSP4afxeEmexsC3BwxeFFyBi4cCXRDiubiKnIIYOAiapVIfzqAJA324y 5AMO6SlZvniyEJrpLy/0RkYXa8THxuNjbDYeKCTteKGXXKaSvFgEdb3oF Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="287661303" X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="287661303" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 07:49:47 -0700 X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="594852649" Received: from kckollur-mobl1.amr.corp.intel.com (HELO [10.212.118.182]) ([10.212.118.182]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 07:49:45 -0700 Message-ID: <95fc3b8f-7556-371d-2817-7e0d811de24a@linux.intel.com> Date: Tue, 19 Jul 2022 09:49:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH] docs: driver-api: firmware: add driver firmware guidelines. Content-Language: en-US To: Dave Airlie , Rodrigo Vivi Cc: alsa-devel@alsa-project.org, "open list:DOCUMENTATION" , Greg Kroah-Hartman , Jonathan Corbet , Linux Wireless List , LKML , linux-block@vger.kernel.org, "Luis R. Rodriguez" , Daniel Vetter , Network Development , "dri-devel@lists.sf.net" , Dave Airlie , Linus Torvalds , Linux Media Mailing List References: <20220718072144.2699487-1-airlied@gmail.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/18/22 19:29, Dave Airlie wrote: >>> +* Firmware should be versioned with at least a major/minor version. It >>> + is suggested that the firmware files in linux-firmware be named with >>> + some device specific name, and just the major version. The >>> + major/minor/patch versions should be stored in a header in the >>> + firmware file for the driver to detect any non-ABI fixes/issues. The >>> + firmware files in linux-firmware should be overwritten with the newest >>> + compatible major version. Newer major version firmware should remain >>> + compatible with all kernels that load that major number. >> >> would symbolic links be acceptable in the linux-firmware.git where >> the _.bin is a sym link to _..bin >> >> or having the _.bin really to be the overwritten every minor >> update? > > I don't think providing multiple minor versions of fw in > linux-firmware is that interesting. > Like if the major is the same, surely you always want the newer ones. > As long as the > ABI doesn't break. Otherwise we are just wasting disk space with fws > nobody will be using. It was my understanding that once a firmware file is in linux-firmware it's there forever. There are tons of existing symlinks to point to the latest version, but the previous versions are not removed/overwritten. see random examples: ls -lR /lib/firmware | grep t4fw ls -lR /lib/firmware | grep fw_release