From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757665AbbA0CFf (ORCPT ); Mon, 26 Jan 2015 21:05:35 -0500 Received: from mail-by2on0080.outbound.protection.outlook.com ([207.46.100.80]:55120 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755358AbbA0CFc (ORCPT ); Mon, 26 Jan 2015 21:05:32 -0500 Date: Mon, 26 Jan 2015 18:05:23 -0800 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Andreas =?utf-8?Q?F=C3=A4rber?= CC: Linus Walleij , Rob Herring , Pawel Moll , Mark Rutland , , Ian Campbell , Laurent Pinchart , Heiko Stuebner , , Bjorn Andersson , Michal Simek , , Beniamino Galvani , , "Ivan T. Ivanov" , Kumar Gala , Grant Likely , , Alessandro Rubini Subject: Re: [PATCH v4 6/7] ARM: zynq: DT: Add pinctrl information References: <1420818231-13451-1-git-send-email-soren.brinkmann@xilinx.com> <1420818231-13451-7-git-send-email-soren.brinkmann@xilinx.com> <54C6D44C.4060106@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54C6D44C.4060106@suse.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-7.5.0.1018-21286.003 X-TM-AS-User-Approved-Sender: Yes;Yes Message-ID: <95fcb833572949c9aa2f406c0b147d1f@BL2FFO11FD060.protection.gbl> X-EOPAttributedMessage: 0 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=soren.brinkmann@xilinx.com; unipv.it; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(377424004)(51704005)(86362001)(19580405001)(104016003)(85182001)(53416004)(87936001)(19580395003)(83506001)(106466001)(6806004)(47776003)(74316001)(2950100001)(77156002)(92566002)(50466002)(62966003)(92726002)(110136001)(54356999)(85202003)(23676002)(76176999)(50986999)(108616004)(46102003)(107986001)(24736002)(23106004);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB019;H:xsj-pvapsmtpgw01;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB019; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:BL2FFO11HUB019; X-Forefront-PRVS: 046985391D X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB019; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2015 02:05:30.2994 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB019 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-01-27 at 12:57AM +0100, Andreas Färber wrote: > Am 09.01.2015 um 16:43 schrieb Soren Brinkmann: > > Add pinctrl descriptions to the zc702 and zc706 device trees. > > > > Signed-off-by: Soren Brinkmann > > Tested-by: Andreas Färber > > --- > > Changes since v1: > > - remove 'pinctrl-' prefix for pinctrl sub-nodes > > - separate config and mux nodes > > > > Changes since RFC v2: > > - add pinconf properties to zc702 mdio node > > - remove arguments from bias-related props > > > > Changes since RFC v1: > > - separate DT changes into their own patch > > --- > > arch/arm/boot/dts/zynq-7000.dtsi | 8 +- > > arch/arm/boot/dts/zynq-zc702.dts | 181 +++++++++++++++++++++++++++++++++++++++ > > arch/arm/boot/dts/zynq-zc706.dts | 152 ++++++++++++++++++++++++++++++++ > > 3 files changed, 340 insertions(+), 1 deletion(-) > [...] > > diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts > > index 280f02dd4ddc..4995412f116f 100644 > > --- a/arch/arm/boot/dts/zynq-zc702.dts > > +++ b/arch/arm/boot/dts/zynq-zc702.dts > [...] > > @@ -50,15 +52,24 @@ > > status = "okay"; > > phy-mode = "rgmii-id"; > > phy-handle = <ðernet_phy>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_gem0_default>; > > > > ethernet_phy: ethernet-phy@7 { > > reg = <7>; > > }; > > }; > > > > +&gpio0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_gpio0_default>; > > On linux-next the equivalent no longer works for the Parallella, with > gpio failing to probe. > > If I move these two properties to the leds node (for which I am > configuring gpio 7) then I get a heartbeat as before. I think for USB I have a fix (see other email with patch), but LEDs seem to be broken too. On my zc702 I get: of_get_named_gpiod_flags: parsed 'gpios' property of node '/leds/ds23[0]' - status (-517) 517 is probe deferral. Looks like the LED driver needs to learn to defer probing when the GPIO driver isn't available yet. Sören