From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828AbdBMPGB (ORCPT ); Mon, 13 Feb 2017 10:06:01 -0500 Received: from mail-db5eur01on0137.outbound.protection.outlook.com ([104.47.2.137]:51968 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752054AbdBMPFj (ORCPT ); Mon, 13 Feb 2017 10:05:39 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH] [TRIVIAL] kasan: Add a prototype of task_struct to avoid warning To: Masami Hiramatsu References: <148699609915.25482.4216286293667050154.stgit@devbox> CC: , , Alexander Potapenko , Dmitry Vyukov From: Andrey Ryabinin Message-ID: <96010656-62a2-a4e1-3fc2-1c41b6caffe3@virtuozzo.com> Date: Mon, 13 Feb 2017 18:06:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <148699609915.25482.4216286293667050154.stgit@devbox> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: DB6P191CA0024.EURP191.PROD.OUTLOOK.COM (10.175.236.162) To HE1PR0801MB2057.eurprd08.prod.outlook.com (10.168.95.22) X-MS-Office365-Filtering-Correlation-Id: a6617477-84cf-4d3f-6766-08d45421c30c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0801MB2057; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2057;3:IlPP+8PVsvAbUBhNtF06x2qMLEW9jpMIKSIHdlgvbRqZ3FqHDFKF8netdAdXc8kexlNBJ7VdtX/8QOPLdh+KI7SDshHuNzlQ2Kz4vz/K5GrtGMiuy56LqlhWfxwhIhRVIc/7e55CE7giGt9ckSilptqLPqaK02eWadG8SmPTX/g7HMd8MahnrBPBK0FtkvtclR92OihdfaswJSq2YxV5uZx8G/8RHlzL2H6pAmunTZ2mMOyS4SOlWVrCXfHC4+iQt3rnUeIgk11UGeIK8M44Ew==;25:vNXltvaXs0ZnvyNVOy8e+OKw5hP5TLtSdXkCjYMSKIK43kCSPkN0H/BNRQ8gl0CVbfCjKUVYMi8XxvSy0cVHF/g64ZKT+hK8fYjPrcp+SmgEKidllYgkPDgnvJyeYACmH+7zfKJUm2Jj9l9OByQDEYownDXpfWWyWWXEaMmZagUz4ZH5YnRz3YBZ+tHzH/uDQKQkEJSEvIx9w1oTlq7DvMcFNiaKeKBlL6/iuXgRyhUE1O6bxFOq7tX9XJ5AhgGpYlRNui2JSCvlGU9DkBOXvQwygD+eM9lERAVe1AcJjaXN+MQjS5NqJCxj5nbMxQPmKAlZ4lvUM/6vYR/VVCf22MO8hDvDrqxewTmq+WXPxLmrWzkki0znLm1DU7nyJqtm+4EhbH/jYXkZRwSrGdI9NHxWrNk/wUZdFEzA6YlrlFwr1TKq52h7UOELsyNdtE7dlMnw5FwSgDvoRHkWfU30Jg== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2057;31:F91kBhDVHWcQBweG+lw6d/TTO4kvV9wqIJ95XTcSYHlqla5+xKOZD1JNVrBMdJGO6rlFeiqCaQgC0YBC2vncAwStfrbUZaJ1TNJNIO3hA3Af2AS/EaXcHLf/pe5/WrqDXZllbmw7v3WNZx/1uv7jBesh8Kdmq0yy1aLFoamNNm8C6b6CbL3CZTSSsJUPCXoubzPfrL/PIXHpeiZYOsSVHNMj3WPiuOVnzRqoUSSzT7Hj75nVFAPmGO7TIlax1sIoFWyni/L82EMpblaNILvZkA==;20:T8Zaq5V4rnxMSU94ZhcflsWZx+OH4eay7G3Bf9NBcIBMHlDW9alj0Hzs6/6OvsIWbqpS9vrhPxciC+wSAzjmTIt7dYT4ir0VOyApsbGGkevAVzbdfUNre78PVgIgLHkhEpciOePqzNR6x3AUWsWsIq0deEpJrgfxxk0hangYkXBaiNCSjHSJNi4xWtysWqq9sG0TNnUp7fyQ4zeMbw2Y/S8mXtVx5/HCe1vnD2ksEWnTaBo2tGOLVi4CgXXYh33D+iA1ogiJj6NM1pyOg2rpcl4MwqbvmZtTGe2Y2qImX1wlYC/eM9bNafCVLSzuGKpxEMZSUDmHa22H1XF8BJyobVL91CzrFi7i4iMSvul3Mh4pPVx2Jrp8gNhCJKTxPxpy3LI0J8qMfvghoQETIpwT21MHry1jlj7K8q3fwvM8GwI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211936372134217)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123558025)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148);SRVR:HE1PR0801MB2057;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB2057; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2057;4:M1H+13ye3rC5eU10FqmQVuCaoWFUSPkDrthG2pCVK+93i9NX5T/pS+EtW0w/ujL/auKLs4cwAkz6ApGpOoFy9yQHDV6vt2cfyTckMMBOu34XTPt3JSszG2/HEq29dJWr1iS1+ESX/+MV7WrNPKWZdZ9NrFmPcf8JDJdAjCh0HWTBlDMllpnzvgXQSAkUt9qd+D3KC7VCDCay8TPW4bs3bVZ7Ib9avycUJj6f1GAFRIwpMGN5pSxQetvg57z8Cev9/PGvUUsvJ0tdyzG7YzbGwkTZe+X8/sqRThsEqjtFp9DX1R/M8uWnt8LKV1p3/O7+KauKF2fEBO6Q0IgJhhN6y580e4m6+Ph1Bs7/b+Q3m3gcRVUvBKiLFX+2ciko8z1i0r9ianOKShg1TEr+NHgPO/DnaSH+J8i4gD7GD4eTykKkp/e8z5T/lX/BaNZOouPP84rc4X3fysENTgbDJvyv3WV7/3WHX3bN2yqWfVA/FSq2U7F3X2eZPnFWGnmeWutxRAsUWv0Ff9toykIaRXIEi/RAW6DbmVjivshOTbZuu+3208Bo660P+vkxeWYZ1NvaeaHZE2Zat7Z13ZMsPayGBVdBgmZsifggDoVKf/87QRbGhYQr1lrsbd8eY19OeaRYA/ohIHTphJ1LFcOinGhThU8h7W6AS122oBv99SSx0A130WK2WvTumYiSIg/a+Czn X-Forefront-PRVS: 02176E2458 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39450400003)(39410400002)(39830400002)(377454003)(199003)(189002)(24454002)(92566002)(105586002)(8676002)(50986999)(2906002)(189998001)(4001350100001)(97736004)(230700001)(65826007)(106356001)(90366009)(7736002)(64126003)(110136004)(6246003)(38730400002)(50466002)(81156014)(81166006)(25786008)(53546003)(83506001)(101416001)(305945005)(36756003)(54906002)(6486002)(77096006)(54356999)(229853002)(76176999)(4326007)(53936002)(31696002)(2950100002)(575784001)(86362001)(68736007)(33646002)(5660300001)(65806001)(66066001)(23676002)(65956001)(6116002)(42186005)(6916009)(31686004)(3846002)(47776003);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB2057;H:[172.16.25.12];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA4MDFNQjIwNTc7MjM6OUh6UWhIbHBvSlJxem84ZmI1TU5oc0E1?= =?utf-8?B?dGs3T2F4TGtQblk4ZnVrY3VKNmdiTnBtVWM5ckF5cG9wOHdEZjNiN0VRVjA1?= =?utf-8?B?Rm43d3BUZ0ZOTUFNVENwMTZzckExN2owcUkyZExZSDkwL25TS0tIdDNPOFgr?= =?utf-8?B?WWxZYWxiaExtSlA2bUN4L0xKM0pvalJjcnNJU2hpY3hheE9HSldRbVNEUkxU?= =?utf-8?B?L2VoY1FNWFY1WE5iQVYrOXBNR0ViS2phNDMvRHNoOWh4V01xYVpucWYrL29H?= =?utf-8?B?ZVVvd0lrWFhDUlBBT0tGais1a2FKcDRWWkgwTHVSaDhOclNrN3hDUmNDbU4y?= =?utf-8?B?YUVhU2l6Q1NQL0NHbS95TThUSlYzSDIzcnZTTGV4VjBXSEFPbmsvWi9LcWh0?= =?utf-8?B?Ui84WmUxaTZzeklBZXVRRE9yR1JZWUtiSk9nNUJ3NGZTUHdWVk1UMW4rMzFL?= =?utf-8?B?bWRhbkZZSlhPYzlqTW05NzQ2MlRSRmoxbHJYc1lDOE51QzA3Y0pLRms5SzRl?= =?utf-8?B?UlF5K0xhdk9HendJWVp4Q0JIcldjd2cyUXRnNG5SUFJmUkdydUlTR2lzMUlr?= =?utf-8?B?a1lKMnVXYUZHREVxQS9aakVTbEdsU2pLMC9uRkJIT0w4QjB0emdQaVBiOTRF?= =?utf-8?B?NUo4YzYrOStMVzVwQ1FjZ251TGFuMnV5OFJ1ZzFtRk50clpVdDZnRjBJMU9q?= =?utf-8?B?emI3RVpYUUU3bGMzNEoyWlphMWRVaGVrek16Q0lyOEtDeGxCQmZrTzVDZ0Nt?= =?utf-8?B?SVBvR041VUNDb3R1SkFwUTVpUEtWTWVBQkdtcXF5ak5lMVNBZnNFclZEUmY3?= =?utf-8?B?QXEzeXpiL1k3WHZla2VFMndCVzQyV2pNeDd2b1Z6SldDdFhSREFqT2xCR3ZK?= =?utf-8?B?WXhibG5tRHRrOE1WQTIxMEFaU3BLZFdJdU1UalJMTlVsV0toL3Y3cXdSWWh5?= =?utf-8?B?RFl6VmNoR3paNzVURzJVUUtuSCtiK1JpQVkwK29zQldxRG9zRndjRUI4V0tU?= =?utf-8?B?WVhLVERpclNjOTN3Vm1LVXgycU9pVnI5RzlGWlZxZUJnaUMxbWpaMGVTSXhU?= =?utf-8?B?YldaaWd0L3ZKMGV0d2plYlNROGlpaHUrN3pkK0hKNVl3Q21tUDN1Q01vV0Y2?= =?utf-8?B?N29zcjRDYm1VMThqcTVQZWlvaVRFMitjdXJSb0hhWjQreWljQU9qaVQwMkpY?= =?utf-8?B?cDUwV3daZlZ6Q1ZnWVdDK3N0dkF2OWhReFA4WlJiUHhYcFlHanhNVjNuU2cr?= =?utf-8?B?K3hsRzRqcjFqTlhmQ3N1bDNpYi8yb3JVajk2L3NYdG1WSThlVkhYMURsT2Zl?= =?utf-8?B?YW4rakJaVjRwOWxyNWg5VFNNTUx2NmFnamw4RkdMaEFmWUtpUzR2azBWTkRW?= =?utf-8?B?S2Rob0NVUmE0MlgyMWdCODg2elB5MXdDU21JTTJDZFdKbE5Ddzh2MG55VVFh?= =?utf-8?B?bUZRMHB4YW90RjRtbUxQRGsvMWczQmtWTSs5VHNlU0d3NitvVFZ4L1owOGM0?= =?utf-8?B?eDVmc2RzcmN1R29HSlpjWFZHTFBhcXVrYm9wTDdGUzVFNHRVQXRZSmhpUE9D?= =?utf-8?B?UC8xdEROY1U1bzFzSVZRMEZoQTFJbWZnNVE2dkZKN25lcVFzekVQV1dQY2Ey?= =?utf-8?B?bmhzNGN4Q3pEbnRKK2g1OVFxWXkydDE4UGNldnpFL1dZWVQxZEMvaTVxd05h?= =?utf-8?B?ZmF1ajIveVJGK05NKy9ZbFJ2RVVtQ3hMbFprVjBoVFdEbVhhWkRJeEF5b2xv?= =?utf-8?B?RWtwU09Qa29vOTl4QUZMeUZ3ckJzZk9nSjdhYTUyM1h3cG0vWGNxMzBhbVpL?= =?utf-8?B?MFlmNjh0WmVvb3BQMlY5MWFSaUJtT0FTY3ovRDlsMGEraWs1Mk1NREpObTF5?= =?utf-8?B?VE9jdTZ3R1VJRHhUUElsWW05RlJ6UkorNzZ6TkpuUkxabWhmaVpvZ0RsSktF?= =?utf-8?B?UFRtTEY4TWZ4LzExU1lxb3VGN0Z1ak4rZ25lb21PTUJ4bTVXeGduREV5REd2?= =?utf-8?B?dHBmZHBxMlBtc3JlVXAwUXh3eHAzSHJCN1pXLzdBPT0=?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2057;6:tSqueIgUfVMfI4Qq5ZaBqsA3Zff2HjqMBt3Iqc5CYWrJCQo/simcofcN/V5/p1OZt1to8Dym/+Gj6EEIrM7YxblkpMwt2Se1DdT/s49APXZX+T7KGXnazujMtMqACBA3okijW65c/cN/934KcTA0ly46z0AcpJX7QiBK2JUX/ETVPuBkCbQEvjITnJcICpSElNewsAAiNcDMCBrIwSE8ejly4OxM/ck7sY/s3SN3jYMA5PF/GzKkjpPAvolAexjMmAEzLBgnGc66ynovnbU5YarS3CxEh3H3rWInQshvfroEdiLeDoQ6KlvOqyCWttQG2AWr9Dediue87hs2/HUOXSiNOpb6vqhq5qYOq4hPRqJsaNMkU1s5wNyCVzgZhqbFNARm6TFAs0XV1cEbFHMLlg==;5:66Tuo+lMe/OS7OyfHfSMfSG5wdP6Y0kfvotL/syIoEbeF+kjjIZiscZuXbw/WYYr5cA695DrSifa/KmuTwn0txOPDqzB56K22y/2jG91oC0dZhhPNO2iqVJqyezIptXixmISwHJvza7qR99SCKRjag==;24:GzAOyI0bWoL1KiD9zYuF0LVzgcSt/Mj6RoZdZwPTJuELyRdkM7/KvprGo9BHXUB8FpOboysPogD4/v9IpFiw2LyGwEeWadKhetibCivUKWA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2057;7:wwiVnw+fGwrzRJeOWI7rblfy5daDHd0wUtIqs548UprBgi8JpxVkn1y6U8WEDYGruYcqQRf7afDxVYqV3wMSnIt6CMkDUwbQzSAEbHwh6Iq0MkqoQ+D4zJa5V1xdluTEiTrJmaOA+Kl/6mtlmdXDmuxfOeMCKrLqgO/YSwXyLUO2Kly4EgozvZSDKvvQ5gwrSKbWikhDWwi+YoA6P55mcfeodeWo70iVeKAyC1gSnMq42digAIpl4J3wNylMpw6wGnU5Ic6LJtgk8DsWqYXoWtdtekZIwyZVaJ8vinxrDlH4sJNhoYklHZY0PYNxVpmeP1/Igr2LgKQ10j/Edp6IVslV0Iegyjzf4GSPjBPdxmxIx+CWaUKTjn1kJU9htA/814aQ1CwEaxkFU6L9GDY5IRl3ZlAhGrQdFK76pHFOuK7ofvkHBe3iHtIbHNsTYxlBCaWNrYRztaL5YCu+Z2ky6TMR6AXPzptDCpmvTW7TwCikwqBT9ZPHz1oJqkSp9vB4j5IyITeQ82l3sP0LCt360Q==;20:AuE3y03ETq3XDMqoZsms/7I6k//+zKMB6myNdPERBt7APDNAutWp6mRqpP+J0XF3qSzExu/D7qzmGqLc9YE2n2YiXP9T/tqoz0kkIgFMtXHuQPGWaIGGqbVAEv9uVRlQ2SDorP3hQl6YUSFU9j8FJy3B/doFJchKjp36HjigZPk= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2017 15:05:34.1209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2057 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/13/2017 05:28 PM, Masami Hiramatsu wrote: > Add a prototype of task_struct to fix below warning on arm64. > > CC arch/arm64/kernel/probes/kprobes.o > In file included from /tmp/linux/arch/arm64/kernel/probes/kprobes.c:19:0: > /tmp/linux/include/linux/kasan.h:81:53: warning: 'struct task_struct' declared inside parameter list will not be visible outside of this definition or declaration > static inline void kasan_unpoison_task_stack(struct task_struct *task) {} > ^~~~~~~~~~~ What tree is that? I can't see how is this possible on upstream or -next. kasan.h includes linux/sched.h so it supposed to know about task_struct. Also is the first include in kprobes, so it can't be a header recursion. BTW, arch/arm64/kernel/probes/kprobes.c no longer needs since commit ad05711cec12131e1277ce749a99d08ecf233aa7 ("arm64: Remove stack duplicating code from jprobes") > As same as other types (kmem_cache, page, and vm_struct) > this adds a prototype of task_struct data structure on > top of kasan.h. > > Signed-off-by: Masami Hiramatsu > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Dmitry Vyukov > --- > include/linux/kasan.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 820c0ad..c9df9e1 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -7,6 +7,7 @@ > struct kmem_cache; > struct page; > struct vm_struct; > +struct task_struct; > > #ifdef CONFIG_KASAN > >