From: David Howells <dhowells@redhat.com>
To: joe@perches.com, akpm@linux-foundation.org, hannes@stressinduktion.org
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, dwmw2@infradead.org
Subject: Please discard "checkpatch: warn when using extern with function prototypes in .h files"
Date: Mon, 02 Sep 2013 14:51:33 +0100 [thread overview]
Message-ID: <9606.1378129893@warthog.procyon.org.uk> (raw)
I noticed that a patch got committed to checkpatch to complain about function
prototypes prefixed by "extern".
Please discard/revert this patch:
commit 7cd0f806622836e386ef18ad1950a9a729803019
Author: Joe Perches <joe@perches.com>
Date: Wed Aug 28 10:16:00 2013 +1000
checkpatch: warn when using extern with function prototypes in .h files
Using the extern keyword on function prototypes is superfluous visual
noise so suggest removing it.
This is inaccurate. It's actually a useful visual cue - so if anything, please
make checkpatch indicate that it be added to all future function prototypes.
David
next reply other threads:[~2013-09-02 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 13:51 David Howells [this message]
2013-09-02 16:21 ` [PATCH] checkpatch: Make extern in .h prototypes quieter Joe Perches
2013-09-02 20:51 ` Geert Uytterhoeven
2013-09-02 20:58 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9606.1378129893@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=hannes@stressinduktion.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®