mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: YueHaibing <yuehaibing@huawei.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] drm/vboxvideo: Remove unused including <linux/version.h>
Date: Wed, 20 Mar 2019 10:13:44 +0100	[thread overview]
Message-ID: <9607344f-7312-0ceb-7744-d3084efda16c@redhat.com> (raw)
In-Reply-To: <20190320015429.86347-1-yuehaibing@huawei.com>

Hi,

On 20-03-19 02:54, YueHaibing wrote:
> Remove including <linux/version.h> that don't need it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Thank you for the patch, it looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

I will pick this up and push it to drm-misc-next

Regards,

Hans

> ---
>   drivers/gpu/drm/vboxvideo/vbox_drv.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.h b/drivers/gpu/drm/vboxvideo/vbox_drv.h
> index 6dea8bf5f045..ece31f395540 100644
> --- a/drivers/gpu/drm/vboxvideo/vbox_drv.h
> +++ b/drivers/gpu/drm/vboxvideo/vbox_drv.h
> @@ -14,7 +14,6 @@
>   #include <linux/io.h>
>   #include <linux/irqreturn.h>
>   #include <linux/string.h>
> -#include <linux/version.h>
>   
>   #include <drm/drm_encoder.h>
>   #include <drm/drm_fb_helper.h>
> 
> 
> 
> 
> 

      reply	other threads:[~2019-03-20  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  1:54 YueHaibing
2019-03-20  9:13 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9607344f-7312-0ceb-7744-d3084efda16c@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®