From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBosYYWNF0e7rXq9EIUNKAnzOImBB6XXGS57waN0z+jlJUVlgoMwAAy6gDp4CZd5HmCS/cvJm ARC-Seal: i=1; a=rsa-sha256; t=1516216425; cv=none; d=google.com; s=arc-20160816; b=sUNK39dB2KmIToEAKOLndzeYSFZIvXPWglse5hXZOaSj3nPw5KsiQ/59c9c7J8wyfF O6vY0XdZOirfgA9WFCOwpWEE+cl83KAC9wg0Lv3+bWh6Ak4NkcBa3AY4Txp/LsZhwGJN AyU8isyMTIrw3f/yvss433GDXcQg498wJZ99RKsgEz6o6K+c84eblqNVGkYCzu9f9qEx qH3liKdj+7/gYRkJ9J/w95NiDV/5SnrL7hmPd4hK3r7jLWH71fS943I0WfOE6g5F/ISg alo6K6ITCdfsWfrDPCMlGqVugI3CNzmY/hFOANUKxhd4FYp0GNxm1lvOEZbOTBwzBXj3 Pjlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=AydyPY002uGDxHqIiJTpwWUipvTiUi2kKQfkGtlPMp8=; b=BwzHGDo9KXdTw0RRqkwCLr6H1t4IDeKeQ0OrRmnzk+TLPzGUCK+o22G5OkY/qZscKa mIHd7CYsyynSoUjvWtXwAkJ9pyDdjOX2PlxyBwGhNQq8OIdsERfC0G9KKfwUt5RSpleA CbI4f/CE8HEz6HoF0GXDn6Ddpdrck8/hk2NqBebbQS4Ug2ttoBOKyG1eFOMSs+UZdAcs ATlOoVtU4iFmBW1LIMCHiEXn+6MNLZHrC6gwqu1cO/MgMLJdZIZ35JpT0cnF4M892jhA k3H720Y06/WMzTlGWtV3TW989b/IQdrJcS4x3q9s0fOKIasphns93J1H1LGViKwSkUos 3Yvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=i3F/NxEa; spf=pass (google.com: best guess record for domain of rdunlap@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=rdunlap@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=i3F/NxEa; spf=pass (google.com: best guess record for domain of rdunlap@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=rdunlap@infradead.org Subject: Re: [PATCH v4] input: pxrc: new driver for PhoenixRC Flight Controller Adapter To: Marcus Folkesson , Dmitry Torokhov , Jonathan Corbet , Tomohiro Yoshidomi , David Herrmann , Philippe Ombredanne , Kate Stewart , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180117190716.22380-1-marcus.folkesson@gmail.com> From: Randy Dunlap Message-ID: <9607d51a-4382-396c-a4bd-46bbb24ba46e@infradead.org> Date: Wed, 17 Jan 2018 11:13:43 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180117190716.22380-1-marcus.folkesson@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589509666987149281?= X-GMAIL-MSGID: =?utf-8?q?1589868154728671721?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 01/17/2018 11:07 AM, Marcus Folkesson wrote: > This driver let you plug in your RC controller to the adapter and > use it as input device in various RC simulators. > > Signed-off-by: Marcus Folkesson > --- > diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig > index f3c2f6ea8b44..18ab6dafff41 100644 > --- a/drivers/input/joystick/Kconfig > +++ b/drivers/input/joystick/Kconfig > @@ -351,4 +351,13 @@ config JOYSTICK_PSXPAD_SPI_FF > > To drive rumble motor a dedicated power supply is required. > > +config JOYSTICK_PXRC > + tristate "PhoenixRC Flight Controller Adapter" > + depends on USB_ARCH_HAS_HCD > + select USB Drop the (first) depends and change "select USB" to "depends on USB". Argh, there are lots of input/ drivers that do that. That's bad/wrong. A driver should not select (enable) an entire subsystem. If the user had the subsystem disabled, it should stay that way. Dmitry, you can expect some patches... > + help > + Say Y here if you want to use the PhoenixRC Flight Controller Adapter. > + > + To compile this driver as a module, choose M here: the > + module will be called pxrc. > endif -- ~Randy