From: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
To: Brian Cain <brian.cain@oss.qualcomm.com>, linux-kernel@vger.kernel.org
Cc: sid.manning@oss.qualcomm.com, peterz@infradead.org,
pierrick.bouvier@oss.qualcomm.com, linux-hexagon@vger.kernel.org,
paulmck@kernel.org, Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH] smp: align struct __call_single_node to 8 bytes
Date: Wed, 23 Sep 2026 08:05:41 +0200 [thread overview]
Message-ID: <960849ac-e359-4432-a89e-88401440fd88@oss.qualcomm.com> (raw)
In-Reply-To: <20260906023905.2517725-1-brian.cain@oss.qualcomm.com>
On 2026-09-06 4:39, Brian Cain wrote:
> Consumers walking call_single_queue cast each node to call_single_data_t
> and, given that type's declared over-alignment, the compiler may load
> llist.next and u_flags as one naturally aligned double word. Embedders
"Embedders" is not easy to understand for non-native English speaker,
is it a typo? Regardless:
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
> such as task_struct::wake_entry only guarantee pointer alignment, which
> faults on strict-alignment 32-bit architectures like hexagon.
>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: "Paul E. McKenney" <paulmck@kernel.org>
> Cc: Frederic Weisbecker <frederic@kernel.org>
> Cc: linux-hexagon@vger.kernel.org
> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
> ---
> include/linux/smp_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
prev parent reply other threads:[~2026-09-23 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 2:39 Brian Cain
2026-09-23 6:05 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=960849ac-e359-4432-a89e-88401440fd88@oss.qualcomm.com \
--to=philmd@oss.qualcomm.com \
--cc=brian.cain@oss.qualcomm.com \
--cc=frederic@kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=sid.manning@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®