From: "Laurențiu Nicola" <lnicola@dend.ro>
To: "Thomas Gleixner" <tglx@linutronix.de>
Cc: mingo@kernel.org, bp@alien8.de, x86@kernel.org,
trivial@kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Tom Lendacky" <thomas.lendacky@amd.com>
Subject: Re: [PATCH] x86/irq: Lower unhandled irq error severity
Date: Mon, 30 Nov 2020 19:22:12 +0200 [thread overview]
Message-ID: <96085c8a-b144-4fd3-b1fb-45763b5b64a4@www.fastmail.com> (raw)
In-Reply-To: <87lfeiiy10.fsf@nanos.tec.linutronix.de>
On Mon, Nov 30, 2020, at 18:56, Thomas Gleixner wrote:
> Laurentiu,
>
> On Fri, Nov 27 2020 at 10:03, Laurențiu Nicola wrote:
> > On Fri, Nov 27, 2020, at 02:12, Thomas Gleixner wrote:
> >> On Thu, Nov 26 2020 at 09:47, Laurențiu Nicola wrote:
> >> > These messages are described as warnings in the MSI code.
> >>
> >> Where and what has MSI to do with these messages?
> >
> > There's a comment referring to it as a warning, but an error seemed a more appropriate severity:
> >
> > * If the vector is unused, then it is marked so it won't
> > * trigger the 'No irq handler for vector' warning in
> > * common_interrupt().
>
> That's a description for the logic in the MSI code which is required to
> _NOT_ trigger the 'No irq handler' message. If that message appears then
> something _is_ badly wrong. Either the kernel screwed up or something in
> the BIOS/firmware/hardware is bonkers.
Agreed, just pointing out that the MSI code refers to it as a warning (as opposed to a critical error).
>
> >> > Spotted because they break quiet boot on a Ryzen 5000 CPU.
> >>
> >> They don't break the boot.
> >>
> >> The machine boots fine, but having interrupts raised on a vector which
> >> is unused is really bad.
> >
> > That's right, sorry. It still boots, but it's no longer "quiet",
> > that's what I meant.
>
> Right, but surpressing that is not a solution.
I'm just downgrading it from "emergency" to "error". It will still be displayed for most users snd anyone looking in dmesg. But I'm unlikely to convince my motherboard manufacturer to fix this in the BIOS, and the errors are basically unactionable and uninformative (unlike say "can't set up page mappings" or "your CPU might be on fire" which would really imply a crash soon).
The messages themselves are only a cosmetic issue -- they replace the BIOS logo that would otherwise stay up until the display manager started.
But if you think this should really be an "emerg" message, I'm not going to insist anymore. I'm sure you have more important patches to review :-).
Thanks,
Laurențiu
next prev parent reply other threads:[~2020-11-30 17:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201126074734.12664-1-lnicola@dend.ro>
2020-11-27 0:12 ` Thomas Gleixner
2020-11-27 8:03 ` Laurențiu Nicola
2020-11-30 16:56 ` Thomas Gleixner
2020-11-30 17:22 ` Laurențiu Nicola [this message]
2020-11-30 23:34 ` Thomas Gleixner
2020-12-01 8:18 ` Laurențiu Nicola
2020-12-01 10:38 ` Thomas Gleixner
2020-12-01 10:41 ` Laurențiu Nicola
2020-12-01 14:36 ` Tom Lendacky
2020-12-01 14:44 ` Laurențiu Nicola
2020-12-01 17:05 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96085c8a-b144-4fd3-b1fb-45763b5b64a4@www.fastmail.com \
--to=lnicola@dend.ro \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=trivial@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®